mirror of
				https://github.com/python/cpython.git
				synced 2025-10-31 13:41:24 +00:00 
			
		
		
		
	Raise SystemError when size < 0 is passed into PyString_FromStringAndSize,
PyBytes_FromStringAndSize or PyUnicode_FromStringAndSize. [issue2587]
This commit is contained in:
		
							parent
							
								
									f108320055
								
							
						
					
					
						commit
						c00eb73a30
					
				
					 3 changed files with 18 additions and 0 deletions
				
			
		|  | @ -161,6 +161,11 @@ PyBytes_FromStringAndSize(const char *bytes, Py_ssize_t size) | |||
|     Py_ssize_t alloc; | ||||
| 
 | ||||
|     assert(size >= 0); | ||||
|     if (size < 0) { | ||||
|         PyErr_SetString(PyExc_SystemError, | ||||
|             "Negative size passed to PyBytes_FromStringAndSize"); | ||||
|         return NULL; | ||||
|     } | ||||
| 
 | ||||
|     new = PyObject_New(PyBytesObject, &PyBytes_Type); | ||||
|     if (new == NULL) | ||||
|  |  | |||
|  | @ -56,6 +56,11 @@ PyString_FromStringAndSize(const char *str, Py_ssize_t size) | |||
| { | ||||
| 	register PyStringObject *op; | ||||
| 	assert(size >= 0); | ||||
| 	if (size < 0) { | ||||
| 		PyErr_SetString(PyExc_SystemError, | ||||
| 		    "Negative size passed to PyString_FromStringAndSize"); | ||||
| 		return NULL; | ||||
| 	} | ||||
| 	if (size == 0 && (op = nullstring) != NULL) { | ||||
| #ifdef COUNT_ALLOCS | ||||
| 		null_strings++; | ||||
|  |  | |||
|  | @ -465,6 +465,14 @@ PyObject *PyUnicode_FromUnicode(const Py_UNICODE *u, | |||
| PyObject *PyUnicode_FromStringAndSize(const char *u, Py_ssize_t size) | ||||
| { | ||||
|     PyUnicodeObject *unicode; | ||||
| 
 | ||||
| 	assert(size <= 0); | ||||
| 	if (size < 0) { | ||||
| 		PyErr_SetString(PyExc_SystemError, | ||||
| 		    "Negative size passed to PyUnicode_FromStringAndSize"); | ||||
| 		return NULL; | ||||
| 	} | ||||
| 
 | ||||
|     /* If the Unicode data is known at construction time, we can apply
 | ||||
|        some optimizations which share commonly used objects. | ||||
|        Also, this means the input must be UTF-8, so fall back to the | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Gregory P. Smith
						Gregory P. Smith