Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-03 23:21:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

bpo-42278: Use tempfile.TemporaryDirectory rather than tempfile.mktemp in pydoc (GH-23200)

Browse source 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
This commit is contained in:
E-Paine 2021-08-29 12:07:51 +01:00 • committed by GitHub
parent 2a8127cafe
commit c9227df5a9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Lib/pydoc.py
View file

@ -1618,13 +1618,14 @@ def pipepager(text, cmd):
def tempfilepager(text, cmd): def tempfilepager(text, cmd):
"""Page through text by invoking a program on a temporary file.""" """Page through text by invoking a program on a temporary file."""
import tempfile import tempfile
filename = tempfile.mktemp() with tempfile.TemporaryDirectory() as tempdir:
with open(filename, 'w', errors='backslashreplace') as file: filename = os.path.join(tempdir, 'pydoc.out')
file.write(text) with open(filename, 'w', errors='backslashreplace',
try: encoding=os.device_encoding(0) if
sys.platform == 'win32' else None
) as file:
file.write(text)
os.system(cmd + ' "' + filename + '"') os.system(cmd + ' "' + filename + '"')
finally:
os.unlink(filename)
def _escape_stdout(text): def _escape_stdout(text):
# Escape non-encodable characters to avoid encoding errors later # Escape non-encodable characters to avoid encoding errors later

2
Misc/NEWS.d/next/Security/2021-08-29-12-39-44.bpo-42278.jvmQz_.rst Normal file
View file

@ -0,0 +1,2 @@
Replaced usage of :func:`tempfile.mktemp` with
:class:`~tempfile.TemporaryDirectory` to avoid a potential race condition.