mirror of
				https://github.com/python/cpython.git
				synced 2025-10-31 21:51:50 +00:00 
			
		
		
		
	gh-135329: Use longer timeout in pyrepl test_repl_eio() (#139503)
Replace hardcoded 5 seconds with support.SHORT_TIMEOUT.
Fix the following error on slow CI such as GitHub Action UBSan:
test test_pyrepl failed -- Traceback (most recent call last):
  File "Lib/test/test_pyrepl/test_unix_console.py", line 362, in test_repl_eio
    _, err = proc.communicate(timeout=5)  # sleep for pty to settle
             ~~~~~~~~~~~~~~~~^^^^^^^^^^^
  File "Lib/subprocess.py", line 1219, in communicate
    stdout, stderr = self._communicate(input, endtime, timeout)
                     ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "Lib/subprocess.py", line 2126, in _communicate
    self._check_timeout(endtime, orig_timeout, stdout, stderr)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "Lib/subprocess.py", line 1266, in _check_timeout
    raise TimeoutExpired(
    ...<2 lines>...
            stderr=b''.join(stderr_seq) if stderr_seq else None)
subprocess.TimeoutExpired: Command '[...]' timed out after 5 seconds
			
			
This commit is contained in:
		
							parent
							
								
									f3d7faeafa
								
							
						
					
					
						commit
						c985822d86
					
				
					 1 changed files with 3 additions and 1 deletions
				
			
		|  | @ -6,6 +6,7 @@ | |||
| import sys | ||||
| import unittest | ||||
| from functools import partial | ||||
| from test import support | ||||
| from test.support import os_helper, force_not_colorized_test_class | ||||
| from test.support import script_helper | ||||
| 
 | ||||
|  | @ -359,7 +360,8 @@ def test_repl_eio(self): | |||
|             self.fail("Child process failed to start properly") | ||||
| 
 | ||||
|         os.kill(proc.pid, signal.SIGUSR1) | ||||
|         _, err = proc.communicate(timeout=5)  # sleep for pty to settle | ||||
|         # sleep for pty to settle | ||||
|         _, err = proc.communicate(timeout=support.SHORT_TIMEOUT) | ||||
|         self.assertEqual( | ||||
|             proc.returncode, | ||||
|             1, | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Victor Stinner
						Victor Stinner