Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-03 23:21:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

GH-137573: mark _PyOptimizer_Optimize as no inline (GH-137731)

Browse source 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
This commit is contained in:
Sachin Shah 2025-08-14 03:00:00 -05:00 • committed by GitHub
parent 7a703c8f19
commit c9d7065188
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Misc/NEWS.d/next/C_API/2025-08-13-13-41-04.gh-issue-137573.r6uwRf.rst Normal file
View file

@ -0,0 +1,2 @@
Mark ``_PyOptimizer_Optimize`` as :c:macro:`Py_NO_INLINE` to
prevent stack overflow crashes on macOS.

3
Python/optimizer.c
View file

@ -109,7 +109,8 @@ uop_optimize(_PyInterpreterFrame *frame, _Py_CODEUNIT *instr,
/* Returns 1 if optimized, 0 if not optimized, and -1 for an error. /* Returns 1 if optimized, 0 if not optimized, and -1 for an error.
* If optimized, *executor_ptr contains a new reference to the executor * If optimized, *executor_ptr contains a new reference to the executor
*/ */
int // gh-137573: inlining this function causes stack overflows
Py_NO_INLINE int
_PyOptimizer_Optimize( _PyOptimizer_Optimize(
_PyInterpreterFrame *frame, _Py_CODEUNIT *start, _PyInterpreterFrame *frame, _Py_CODEUNIT *start,
_PyExecutorObject **executor_ptr, int chain_depth) _PyExecutorObject **executor_ptr, int chain_depth)