Issue #27223: aio: Fix _read_ready and _write_ready to respect _conn_lost.

Patch by Łukasz Langa.
This commit is contained in:
Yury Selivanov 2016-06-11 11:19:47 -04:00
parent 8ace13be39
commit ca2e0a48cf
3 changed files with 29 additions and 18 deletions

View file

@ -569,6 +569,7 @@ def close(self):
self._loop.remove_reader(self._sock_fd)
if not self._buffer:
self._conn_lost += 1
self._loop.remove_writer(self._sock_fd)
self._loop.call_soon(self._call_connection_lost, None)
# On Python 3.3 and older, objects with a destructor part of a reference
@ -662,6 +663,8 @@ def resume_reading(self):
logger.debug("%r resumes reading", self)
def _read_ready(self):
if self._conn_lost:
return
try:
data = self._sock.recv(self.max_size)
except (BlockingIOError, InterruptedError):
@ -721,6 +724,8 @@ def write(self, data):
def _write_ready(self):
assert self._buffer, 'Data should not be empty'
if self._conn_lost:
return
try:
n = self._sock.send(self._buffer)
except (BlockingIOError, InterruptedError):
@ -891,6 +896,8 @@ def resume_reading(self):
logger.debug("%r resumes reading", self)
def _read_ready(self):
if self._conn_lost:
return
if self._write_wants_read:
self._write_wants_read = False
self._write_ready()
@ -923,6 +930,8 @@ def _read_ready(self):
self.close()
def _write_ready(self):
if self._conn_lost:
return
if self._read_wants_write:
self._read_wants_write = False
self._read_ready()
@ -1000,6 +1009,8 @@ def get_write_buffer_size(self):
return sum(len(data) for data, _ in self._buffer)
def _read_ready(self):
if self._conn_lost:
return
try:
data, addr = self._sock.recvfrom(self.max_size)
except (BlockingIOError, InterruptedError):