Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-31 21:51:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-121474: Add threading.Barrier parties arg sanity check. (GH-121480)

Browse source
This commit is contained in:
Clinton 2024-07-30 04:53:07 -04:00 • committed by GitHub
parent 3a9b2aae61
commit d27a53fc02
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/test/lock_tests.py
View file

@ -1013,6 +1013,10 @@ def multipass(self, results, n):
self.assertEqual(self.barrier.n_waiting, 0) self.assertEqual(self.barrier.n_waiting, 0)
self.assertFalse(self.barrier.broken) self.assertFalse(self.barrier.broken)
def test_constructor(self):
self.assertRaises(ValueError, self.barriertype, parties=0)
self.assertRaises(ValueError, self.barriertype, parties=-1)
def test_barrier(self, passes=1): def test_barrier(self, passes=1):
""" """
Test that a barrier is passed in lockstep Test that a barrier is passed in lockstep

2
Lib/threading.py
View file

@ -689,6 +689,8 @@ def __init__(self, parties, action=None, timeout=None):
default for all subsequent 'wait()' calls. default for all subsequent 'wait()' calls.
""" """
if parties < 1:
raise ValueError("parties must be > 0")
self._cond = Condition(Lock()) self._cond = Condition(Lock())
self._action = action self._action = action
self._timeout = timeout self._timeout = timeout

2
Misc/NEWS.d/next/Library/2024-07-08-03-45-34.gh-issue-121474.NsvrUN.rst Normal file
View file

@ -0,0 +1,2 @@
Fix missing sanity check for ``parties`` arg in :class:`threading.Barrier`
constructor. Patch by Clinton Christian (pygeek).