Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-03 23:21:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Issue #28704: Fix create_unix_server to support Path-like objects

Browse source
This commit is contained in:
Yury Selivanov 2016-11-15 15:26:34 -05:00
parent 0ed20cdfb7
commit d7c151871e
2 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/asyncio/unix_events.py
View file

@ -39,6 +39,13 @@ def _sighandler_noop(signum, frame):
pass pass
try:
_fspath = os.fspath
except AttributeError:
# Python 3.5 or earlier
_fspath = lambda path: path
class _UnixSelectorEventLoop(selector_events.BaseSelectorEventLoop): class _UnixSelectorEventLoop(selector_events.BaseSelectorEventLoop):
"""Unix event loop. """Unix event loop.
@ -256,6 +263,7 @@ def create_unix_server(self, protocol_factory, path=None, *,
raise ValueError( raise ValueError(
'path and sock can not be specified at the same time') 'path and sock can not be specified at the same time')
path = _fspath(path)
sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
# Check for abstract socket. `str` and `bytes` paths are supported. # Check for abstract socket. `str` and `bytes` paths are supported.

10
Lib/test/test_asyncio/test_unix_events.py
View file

@ -4,6 +4,7 @@
import errno import errno
import io import io
import os import os
import pathlib
import signal import signal
import socket import socket
import stat import stat
@ -251,6 +252,15 @@ def test_create_unix_server_existing_path_sock(self):
srv.close() srv.close()
self.loop.run_until_complete(srv.wait_closed()) self.loop.run_until_complete(srv.wait_closed())
@unittest.skipUnless(hasattr(os, 'fspath'), 'no os.fspath')
def test_create_unix_server_pathlib(self):
with test_utils.unix_socket_path() as path:
path = pathlib.Path(path)
srv_coro = self.loop.create_unix_server(lambda: None, path)
srv = self.loop.run_until_complete(srv_coro)
srv.close()
self.loop.run_until_complete(srv.wait_closed())
def test_create_unix_server_existing_path_nonsock(self): def test_create_unix_server_existing_path_nonsock(self):
with tempfile.NamedTemporaryFile() as file: with tempfile.NamedTemporaryFile() as file:
coro = self.loop.create_unix_server(lambda: None, file.name) coro = self.loop.create_unix_server(lambda: None, file.name)