Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-26 19:24:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-137838: Move _PyUOpInstruction buffer to PyInterpreterState (gh-138918)

Browse source
This commit is contained in:
Donghee Na 2025-09-17 18:50:16 +01:00 • committed by GitHub
parent a9b6b09141
commit d873fb42f3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 87 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Python/optimizer.c
View file

@ -116,7 +116,10 @@ _PyOptimizer_Optimize(
_PyExecutorObject **executor_ptr, int chain_depth)
{
_PyStackRef *stack_pointer = frame->stackpointer;
assert(_PyInterpreterState_GET()->jit);
PyInterpreterState *interp = _PyInterpreterState_GET();
assert(interp->jit);
assert(!interp->compiling);
interp->compiling = true;
// The first executor in a chain and the MAX_CHAIN_DEPTH'th executor *must*
// make progress in order to avoid infinite loops or excessively-long
// side-exit chains. We can only insert the executor into the bytecode if
@ -126,10 +129,12 @@ _PyOptimizer_Optimize(
PyCodeObject *code = _PyFrame_GetCode(frame);
assert(PyCode_Check(code));
if (progress_needed && !has_space_for_executor(code, start)) {
interp->compiling = false;
return 0;
}
int err = uop_optimize(frame, start, executor_ptr, (int)(stack_pointer - _PyFrame_Stackbase(frame)), progress_needed);
if (err <= 0) {
interp->compiling = false;
return err;
}
assert(*executor_ptr != NULL);
@ -143,6 +148,7 @@ _PyOptimizer_Optimize(
* it might get confused by the executor disappearing,
* but there is not much we can do about that here. */
Py_DECREF(*executor_ptr);
interp->compiling = false;
return 0;
}
insert_executor(code, start, index, *executor_ptr);
@ -152,6 +158,7 @@ _PyOptimizer_Optimize(
}
(*executor_ptr)->vm_data.chain_depth = chain_depth;
assert((*executor_ptr)->vm_data.valid);
interp->compiling = false;
return 1;
}
@ -1280,7 +1287,14 @@ uop_optimize(
{
_PyBloomFilter dependencies;
_Py_BloomFilter_Init(&dependencies);
_PyUOpInstruction buffer[UOP_MAX_TRACE_LENGTH];
PyInterpreterState *interp = _PyInterpreterState_GET();
if (interp->jit_uop_buffer == NULL) {
interp->jit_uop_buffer = (_PyUOpInstruction *)_PyObject_VirtualAlloc(UOP_BUFFER_SIZE);
if (interp->jit_uop_buffer == NULL) {
return 0;
}
}
_PyUOpInstruction *buffer = interp->jit_uop_buffer;
OPT_STAT_INC(attempts);
char *env_var = Py_GETENV("PYTHON_UOPS_OPTIMIZE");
bool is_noopt = true;