Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-26 11:14:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-127146: Emscripten: Fix pathlib glob_dotdot test (#135624)

Browse source 
The Emscripten path resolver uses the same mechanism for resolving `..`
at a file system root as for resolving symlinks. This is because
roots don't store their mountpoints. If the parent of a node is itself,
it is a root but it might be a mountpoint in some other file system.

If a path has enough `..`'s at the root, it will return ELOOP.
Enough turns out to be 49.
This commit is contained in:
Hood Chatham 2025-06-17 20:20:43 -07:00 • committed by GitHub
parent ce58afb400
commit e4ccd46bf7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/test/test_pathlib/test_pathlib.py
View file

@ -2954,7 +2954,13 @@ def test_glob_dotdot(self):
else: else:
# ".." segments are normalized first on Windows, so this path is stat()able. # ".." segments are normalized first on Windows, so this path is stat()able.
self.assertEqual(set(p.glob("xyzzy/..")), { P(self.base, "xyzzy", "..") }) self.assertEqual(set(p.glob("xyzzy/..")), { P(self.base, "xyzzy", "..") })
self.assertEqual(set(p.glob("/".join([".."] * 50))), { P(self.base, *[".."] * 50)}) if sys.platform == "emscripten":
# Emscripten will return ELOOP if there are 49 or more ..'s.
# Can remove when https://github.com/emscripten-core/emscripten/pull/24591 is merged.
NDOTDOTS = 48
else:
NDOTDOTS = 50
self.assertEqual(set(p.glob("/".join([".."] * NDOTDOTS))), { P(self.base, *[".."] * NDOTDOTS)})
def test_glob_inaccessible(self): def test_glob_inaccessible(self):
P = self.cls P = self.cls