Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2026-01-06 15:32:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

gh-87347: Fix test_pymem_new() reference leak (#94330)

Browse source 
Delete the allocated object with Py_DECREF() rather than
PyObject_Free().

Rename also test_pymem_new() to test_pyobject_new().
This commit is contained in:
Victor Stinner 2022-06-27 23:46:22 +02:00 • committed by GitHub
parent acc6468f7e
commit edb10cab39
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Modules/_testcapimodule.c
View file

@ -4189,39 +4189,39 @@ test_pymem_alloc0(PyObject *self, PyObject *Py_UNUSED(ignored))
}
static PyObject *
test_pymem_new(PyObject *self, PyObject *Py_UNUSED(ignored))
test_pyobject_new(PyObject *self, PyObject *Py_UNUSED(ignored))
{
char *ptr;
PyObject *obj;
PyTypeObject *type = &PyBaseObject_Type;
PyTypeObject *var_type = &PyLong_Type;
// PyObject_New()
ptr = PyObject_New(char, type);
if (ptr == NULL) {
obj = PyObject_New(PyObject, type);
if (obj == NULL) {
goto alloc_failed;
}
PyObject_Free(ptr);
Py_DECREF(obj);
// PyObject_NEW()
ptr = PyObject_NEW(char, type);
if (ptr == NULL) {
obj = PyObject_NEW(PyObject, type);
if (obj == NULL) {
goto alloc_failed;
}
PyObject_Free(ptr);
Py_DECREF(obj);
// PyObject_NewVar()
ptr = PyObject_NewVar(char, var_type, 3);
if (ptr == NULL) {
obj = PyObject_NewVar(PyObject, var_type, 3);
if (obj == NULL) {
goto alloc_failed;
}
PyObject_Free(ptr);
Py_DECREF(obj);
// PyObject_NEW_VAR()
ptr = PyObject_NEW_VAR(char, var_type, 3);
if (ptr == NULL) {
obj = PyObject_NEW_VAR(PyObject, var_type, 3);
if (obj == NULL) {
goto alloc_failed;
}
PyObject_Free(ptr);
Py_DECREF(obj);
Py_RETURN_NONE;
@ -6326,7 +6326,7 @@ static PyMethodDef TestMethods[] = {
{"with_tp_del", with_tp_del, METH_VARARGS},
{"create_cfunction", create_cfunction, METH_NOARGS},
{"test_pymem_alloc0", test_pymem_alloc0, METH_NOARGS},
{"test_pymem_new", test_pymem_new, METH_NOARGS},
{"test_pyobject_new", test_pyobject_new, METH_NOARGS},
{"test_pymem_setrawallocators",test_pymem_setrawallocators, METH_NOARGS},
{"test_pymem_setallocators",test_pymem_setallocators, METH_NOARGS},
{"test_pyobject_setallocators",test_pyobject_setallocators, METH_NOARGS},