From eff4a06829fd87755dbee9f3fd371451385855a0 Mon Sep 17 00:00:00 2001
From: LloydZ <35182391+cocolato@users.noreply.github.com>
Date: Thu, 16 Apr 2026 04:09:27 +0000
Subject: [PATCH] update comment

---
 Objects/typeobject.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index 45404b02a4a..2e1ae0bbc94 100644
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -6420,16 +6420,18 @@ void
 _PyType_SetFlagsRecursive(PyTypeObject *self, unsigned long mask, unsigned long flags)
 {
     BEGIN_TYPE_LOCK();
-     /* Invalidate the old version before changing flags. This must happen
-         before types_stop_world(); immutable/static-builtin types are
-         skipped because set_flags_recursive() does not touch them. */
+    /* Ideally, changing flags and invalidating the old version tag would
+       happen in one step. But type_modified_unlocked() is re-entrant and
+       cannot run with the world stopped, so we must invalidate first.
+       Immutable/static-builtin types are skipped because
+       set_flags_recursive() does not modify them. */
     if (!PyType_HasFeature(self, Py_TPFLAGS_IMMUTABLETYPE) &&
         (self->tp_flags & mask) != flags)
     {
         type_modified_unlocked(self);
     }
-     /* Keep TYPE_LOCK held while waiting for stop-the-world so no thread
-         can reassign a version tag before the flag update. */
+    /* Keep TYPE_LOCK held while waiting for stop-the-world so no thread
+       can reassign a version tag before the flag update. */
     type_lock_prevent_release();
     types_stop_world();
     set_flags_recursive(self, mask, flags);