Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-08 06:10:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

[3.14] gh-137308: Replace a single docstring with pass in -OO mode (GH-137318) (#137322)

Browse source 
Co-authored-by: sobolevn <mail@sobolevn.me>
This commit is contained in:
Miss Islington (bot) 2025-08-08 17:04:10 +02:00 • committed by GitHub
parent f1248cfac0
commit f17d77f112
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 154 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

125
Lib/test/test_ast/test_ast.py
View file

@ -220,6 +220,131 @@ def test_negative_locations_for_compile(self):
# This also must not crash:
ast.parse(tree, optimize=2)
def test_docstring_optimization_single_node(self):
# https://github.com/python/cpython/issues/137308
class_example1 = textwrap.dedent('''
class A:
"""Docstring"""
''')
class_example2 = textwrap.dedent('''
class A:
"""
Docstring"""
''')
def_example1 = textwrap.dedent('''
def some():
"""Docstring"""
''')
def_example2 = textwrap.dedent('''
def some():
"""Docstring
"""
''')
async_def_example1 = textwrap.dedent('''
async def some():
"""Docstring"""
''')
async_def_example2 = textwrap.dedent('''
async def some():
"""
Docstring
"""
''')
for code in [
class_example1,
class_example2,
def_example1,
def_example2,
async_def_example1,
async_def_example2,
]:
for opt_level in [0, 1, 2]:
with self.subTest(code=code, opt_level=opt_level):
mod = ast.parse(code, optimize=opt_level)
self.assertEqual(len(mod.body[0].body), 1)
if opt_level == 2:
pass_stmt = mod.body[0].body[0]
self.assertIsInstance(pass_stmt, ast.Pass)
self.assertEqual(
vars(pass_stmt),
{
'lineno': 3,
'col_offset': 4,
'end_lineno': 3,
'end_col_offset': 8,
},
)
else:
self.assertIsInstance(mod.body[0].body[0], ast.Expr)
self.assertIsInstance(
mod.body[0].body[0].value,
ast.Constant,
)
compile(code, "a", "exec")
compile(code, "a", "exec", optimize=opt_level)
compile(mod, "a", "exec")
compile(mod, "a", "exec", optimize=opt_level)
def test_docstring_optimization_multiple_nodes(self):
# https://github.com/python/cpython/issues/137308
class_example = textwrap.dedent(
"""
class A:
'''
Docstring
'''
x = 1
"""
)
def_example = textwrap.dedent(
"""
def some():
'''
Docstring
'''
x = 1
"""
)
async_def_example = textwrap.dedent(
"""
async def some():
'''Docstring
'''
x = 1
"""
)
for code in [
class_example,
def_example,
async_def_example,
]:
for opt_level in [0, 1, 2]:
with self.subTest(code=code, opt_level=opt_level):
mod = ast.parse(code, optimize=opt_level)
if opt_level == 2:
self.assertNotIsInstance(
mod.body[0].body[0],
(ast.Pass, ast.Expr),
)
else:
self.assertIsInstance(mod.body[0].body[0], ast.Expr)
self.assertIsInstance(
mod.body[0].body[0].value,
ast.Constant,
)
compile(code, "a", "exec")
compile(code, "a", "exec", optimize=opt_level)
compile(mod, "a", "exec")
compile(mod, "a", "exec", optimize=opt_level)
def test_slice(self):
slc = ast.parse("x[::]").body[0].value.slice
self.assertIsNone(slc.upper)