mirror of
https://github.com/python/cpython.git
synced 2025-11-09 01:51:26 +00:00
bpo-25532: Protect against infinite loops in inspect.unwrap() (#1717)
Some objects (like test mocks) auto-generate new objects on attribute access, which can lead to an infinite loop in inspect.unwrap(). Ensuring references are retained to otherwise temporary objects and capping the size of the memo dict turns this case into a conventional exception instead.
This commit is contained in:
parent
e377416c10
commit
f9169ce6b4
3 changed files with 28 additions and 3 deletions
|
|
@ -3554,6 +3554,19 @@ def test_builtins_have_signatures(self):
|
|||
self.assertIsNone(obj.__text_signature__)
|
||||
|
||||
|
||||
class NTimesUnwrappable:
|
||||
def __init__(self, n):
|
||||
self.n = n
|
||||
self._next = None
|
||||
|
||||
@property
|
||||
def __wrapped__(self):
|
||||
if self.n <= 0:
|
||||
raise Exception("Unwrapped too many times")
|
||||
if self._next is None:
|
||||
self._next = NTimesUnwrappable(self.n - 1)
|
||||
return self._next
|
||||
|
||||
class TestUnwrap(unittest.TestCase):
|
||||
|
||||
def test_unwrap_one(self):
|
||||
|
|
@ -3609,6 +3622,11 @@ class C:
|
|||
__wrapped__ = func
|
||||
self.assertIsNone(inspect.unwrap(C()))
|
||||
|
||||
def test_recursion_limit(self):
|
||||
obj = NTimesUnwrappable(sys.getrecursionlimit() + 1)
|
||||
with self.assertRaisesRegex(ValueError, 'wrapper loop'):
|
||||
inspect.unwrap(obj)
|
||||
|
||||
class TestMain(unittest.TestCase):
|
||||
def test_only_source(self):
|
||||
module = importlib.import_module('unittest')
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue