Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-08 06:10:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix error path in _imp__set_lazy_attributes_impl

Browse source
This commit is contained in:
Bénédikt Tran 2025-12-07 11:54:47 +01:00 • committed by T. Wouters
parent 301481631f
commit f96a99c222
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Python/import.c
View file

@ -5464,12 +5464,15 @@ _imp__set_lazy_attributes_impl(PyObject *module, PyObject *child_module,
} }
child_dict = get_mod_dict(child_module); child_dict = get_mod_dict(child_module);
if (child_dict == NULL || !PyDict_CheckExact(child_dict)) { if (child_dict == NULL) {
goto error;
}
else if (!PyDict_CheckExact(child_dict)) {
goto done; goto done;
} }
assert(PyAnySet_CheckExact(lazy_submodules)); assert(PyAnySet_CheckExact(lazy_submodules));
PyObject *attr_name;
Py_ssize_t pos = 0; Py_ssize_t pos = 0;
PyObject *attr_name;
Py_hash_t hash; Py_hash_t hash;
while (_PySet_NextEntry(lazy_submodules, &pos, &attr_name, &hash)) { while (_PySet_NextEntry(lazy_submodules, &pos, &attr_name, &hash)) {
if (_PyDict_Contains_KnownHash(child_dict, attr_name, hash)) { if (_PyDict_Contains_KnownHash(child_dict, attr_name, hash)) {
@ -5491,10 +5494,11 @@ _imp__set_lazy_attributes_impl(PyObject *module, PyObject *child_module,
goto error; goto error;
} }
} }
done: done:
ret = Py_NewRef(Py_None); ret = Py_NewRef(Py_None);
error: error:
Py_XDECREF(lazy_modules); Py_XDECREF(lazy_modules);
Py_XDECREF(child_dict); Py_XDECREF(child_dict);
return ret; return ret;