Stowage/cpython
2
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-31 05:31:20 +00:00
Code Issues Projects Releases Packages Wiki Activity
68865 commits 7 branches 633 tags 3.6 GiB
Commit graph

153 commits

Author SHA1 Message Date
Gregory P. Smith
1f8a40b81d remove the long obsolete mention of universal newlines mode only being 
available when configured at compile time.
 2013-03-20 18:32:03 -07:00
Serhiy Storchaka
b3f194d109 Issue #16903: Popen.communicate() on Unix now accepts strings when 
universal_newlines is true as on Windows.
 2013-02-04 16:47:39 +02:00
Andrew Svetlov
08bab07291 Keep ref to ECHILD in local scope (#16650) 2012-12-24 20:06:35 +02:00
Gregory P. Smith
12489d98e6 Fixes issue #16140: The subprocess module no longer double closes its 
child subprocess.PIPE parent file descriptors on child error prior to
exec().

This would lead to race conditions in multithreaded programs where
another thread opened a file reusing the fd which was then closed out
from beneath it by the errant second close.
 2012-11-11 01:37:02 -08:00
Gregory P. Smith
3aee222122 Remove the subprocess "bad exception data" warning (formerly a print!) 
all together and just include the repr of the data in the exception
itself instead of the useless string "Unknown".

This code path is unlikely to even be possible to take given the
nature of the pipe it gets subprocess data from.
 2012-11-11 00:04:13 -08:00
Gregory P. Smith
f44c9da166 Rename a local variable for readability and change a "this can't 
happen" print() call into a RuntimeWarning as it should've been in the
first place.  Because nothing should ever cause unexpected stdout output.
 2012-11-10 23:33:17 -08:00
Gregory P. Smith
3d8e776cd9 Fixes issue #16327: The subprocess module no longer leaks file descriptors 
used for stdin/stdout/stderr pipes to the child when fork() fails.
 2012-11-10 22:32:22 -08:00
Gregory P. Smith
2ec82331b2 Fixes issue #14396: Handle the odd rare case of waitpid returning 0 when 
not expected in subprocess.Popen.wait().
 2012-11-10 20:52:29 -08:00
Gregory P. Smith
5591b02a4c Fixes Issue #16114: The subprocess module no longer provides a 
misleading error message stating that args[0] did not exist when
either the cwd or executable keyword arguments specified a path that
did not exist.

It now keeps track of if the child got as far as preexec and reports it if
not back to the parent via a special "noexec" error message value in
the error pipe so that the cwd can be blamed for a failed chdir
instead of the exec of the executable being blamed instead.

The executable is also always reported accurately when exec fails.

Unittests enhanced to cover these cases.
 2012-10-10 03:34:47 -07:00
Gregory P. Smith
3905171f1e Fixes issue #15756: subprocess.poll() now properly handles errno.ECHILD 
to return a returncode of 0 when the child has already exited or cannot
be waited on.
 2012-09-29 11:40:38 -07:00
Andrew Svetlov
828607170d Issue #15595: Fix subprocess.Popen(universal_newlines=True) 
for certain locales (utf-16 and utf-32 family).

Patch by Chris Jerdonek.
 2012-08-19 22:13:41 +03:00
Antoine Pitrou
1f9a835400 Issue #14252: Fix subprocess.Popen.terminate() to not raise an error under Windows when the child process has already exited. 2012-03-11 19:29:12 +01:00
Charles-François Natali
134a8baed9 Issue #12650: Fix a race condition where a subprocess.Popen could leak 
resources (FD/zombie) when killed at the wrong time.
 2011-08-18 18:49:39 +02:00
Ross Lagerwall
d98646e430 Issue #12607: In subprocess, fix issue where if stdin, stdout or stderr is 
given as a low fd, it gets overwritten.
 2011-07-27 07:16:31 +02:00
Antoine Pitrou
ab85ff3d1a Issue #12591: Improve support of "universal newlines" in the subprocess 
module: the piped streams can now be properly read from or written to.

(this was broken due to the 2.x to 3.x transition; communicate() support
is still sketchy)
 2011-07-23 22:03:45 +02:00
Victor Stinner
2cfb6f3aa0 Issue #12493: subprocess: communicate() handles EINTR 
subprocess.Popen.communicate() now also handles EINTR errors if the process has
only one pipe.
 2011-07-05 14:00:56 +02:00
Victor Stinner
f1512a2967 Close #12383: Fix subprocess module with env={}: don't copy the environment 
variables, start with an empty environment.
 2011-06-21 17:18:38 +02:00
Victor Stinner
87b9bc3893 Close #12085: Fix an attribute error in subprocess.Popen destructor if the 
constructor has failed, e.g. because of an undeclared keyword argument. Patch
written by Oleg Oshmyan.
 2011-06-01 00:57:47 +02:00
Gregory P. Smith
0ef3e399b8 normalize whitespace. 2011-05-11 22:20:11 -07:00
Gregory P. Smith
c9557af441 merge - 7a3f3ad83676 Fixes Issue #12044. 2011-05-11 22:18:23 -07:00
Brian Curtin
08fd8d93f7 merge 2011-04-29 16:11:30 -05:00
Brian Curtin
8b8e7f467f Further fix #7838. CREATE_NEW_CONSOLE was exposed, but none of the 
constants to be used for STARTUPINFO were exposed due to the change.
 2011-04-29 15:48:13 -05:00
Ross Lagerwall
02ba73c0ef Merge with 3.1 2011-04-05 15:48:47 +02:00
Ross Lagerwall
4f61b02520 Issue #10963: Ensure that subprocess.communicate() never raises EPIPE. 2011-04-05 15:34:00 +02:00
Antoine Pitrou
7b98d02302 Issue #11459: A bufsize value of 0 in subprocess.Popen() really creates 
unbuffered pipes, such that select() works properly on them.
 2011-03-19 17:04:13 +01:00
Antoine Pitrou
877766dee8 Issue #11459: A bufsize value of 0 in subprocess.Popen() really creates 
unbuffered pipes, such that select() works properly on them.
 2011-03-19 17:00:37 +01:00
Ezio Melotti
3b3499ba69 #11565: Merge with 3.1. 2011-03-16 11:35:38 +02:00
Ezio Melotti
13925008dc #11565: Fix several typos. Patch by Piotr Kasprzyk. 2011-03-16 11:05:33 +02:00
Antoine Pitrou
c99823211b In subprocess, wrap pipe fds before launching the child. Hopefully this 
will fix intermittent failures on some buildbots (issue #8458).
 2011-01-04 19:07:07 +00:00
Antoine Pitrou
47f14bade8 Un-complicate some code 2011-01-03 23:42:01 +00:00
Antoine Pitrou
f50a6b6b6d Merged revisions 87695 via svnmerge from 
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r87695 | antoine.pitrou | 2011-01-03 19:23:55 +0100 (lun., 03 janv. 2011) | 5 lines

  Issue #10806, issue #9905: Fix subprocess pipes when some of the standard
  file descriptors (0, 1, 2) are closed in the parent process.  Initial
  patch by Ross Lagerwall.
........
 2011-01-03 18:36:36 +00:00
Antoine Pitrou
c9c83ba896 Issue #10806, issue #9905: Fix subprocess pipes when some of the standard 
file descriptors (0, 1, 2) are closed in the parent process.  Initial
patch by Ross Lagerwall.
 2011-01-03 18:23:55 +00:00
Victor Stinner
667d4b577f Issue #10763: subprocess.communicate() closes stdout and stderr if both are 
pipes (bug specific to Windows).

Improve also the unit test: write a portable unit test.
 2010-12-25 22:40:32 +00:00
Gregory P. Smith
b740e76af0 Merged revisions 87233 via svnmerge from 
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r87233 | gregory.p.smith | 2010-12-14 06:38:00 -0800 (Tue, 14 Dec 2010) | 4 lines

  Issue #1731717: Fixed the problem where subprocess.wait() could cause an
  OSError exception when The OS had been told to ignore SIGCLD in our process
  or otherwise not wait for exiting child processes.
........
 2010-12-14 15:16:24 +00:00
Gregory P. Smith
e85db2bbb8 Issue #1731717: Fixed the problem where subprocess.wait() could cause an 
OSError exception when The OS had been told to ignore SIGCLD in our process
or otherwise not wait for exiting child processes.
 2010-12-14 14:38:00 +00:00
Gregory P. Smith
8edd99d085 Issue #6559: fix the subprocess.Popen pass_fds implementation. Add a unittest. 
Issue #7213: Change the close_fds default on Windows to better match the new
default on POSIX.  True when possible (False if stdin/stdout/stderr are
supplied).

Update the documentation to reflect all of the above.
 2010-12-14 13:43:30 +00:00
Gregory P. Smith
51ee270876 issue7213: Open the pipes used by subprocesses with the FD_CLOEXEC flag from 
the C code, using pipe2() when available.  Adds unittests for close_fds and
cloexec behaviors.
 2010-12-13 07:59:39 +00:00
Gregory P. Smith
f560485388 Get rid of the close_fds DeprecationWarning. Changes the default on a per 
platform basis.  It remains False on Windows and changes to True on all
other platforms (POSIX).  Based on python-dev discussion and
http://bugs.python.org/issue7213.
 2010-12-13 06:45:02 +00:00
Gregory P. Smith
8c647cd737 clarify the docs and new warning message. 2010-12-04 18:11:44 +00:00
Gregory P. Smith
d4cc7bf993 issue6559: Adds a pass_fds parameter to subprocess.Popen that allows the caller 
to list exactly which file descriptors should be kept open.
 2010-12-04 11:22:11 +00:00
Gregory P. Smith
d23047b62c issue7213 + issue2320: Cause a DeprecationWarning if the close_fds argument is 
not passed to subprocess.Popen as the default value will be changing in a
future Python to the safer and more often desired value of True.

DeprecationWarnings that show up in a lot of existing code are controversial
and have caused pain in the past.  I'd like to leave this on for 3.2 beta1 and
see how things go.  We can remove the warning if it is deemed too noisy during
any betas.  (case study: the md5 and sha module DeprecationWarnings are loathed
around the world as those modules were never going to be removed in 2.x and
2to3 has a fixer for code that uses them)
 2010-12-04 09:10:44 +00:00
Brian Curtin
79cdb661f5 Fix #10554. Added context manager support to Popen objects. 
Added a few common Popen uses to the tests like we've done for a few other
instances of adding context managers. Eventually the entire test suite
could be converted to use the context manager format.
 2010-12-03 02:46:02 +00:00
Benjamin Peterson
b8bc439b20 don't shadow globals 2010-11-20 18:24:54 +00:00
Benjamin Peterson
5f78040057 add filename to ENOENT message #4925 2010-11-20 18:07:52 +00:00
Georg Brandl
8ffe0bc55f Merged revisions 76923,76926,77009,77082-77083,77085,77087,77121 via svnmerge from 
svn+ssh://svn.python.org/python/branches/py3k

................
  r76923 | georg.brandl | 2009-12-20 15:24:06 +0100 (So, 20 Dez 2009) | 1 line

  #7493: more review fixes.
................
  r76926 | georg.brandl | 2009-12-20 15:38:23 +0100 (So, 20 Dez 2009) | 9 lines

  Recorded merge of revisions 76925 via svnmerge from
  svn+ssh://pythondev@svn.python.org/python/trunk

  ........
    r76925 | georg.brandl | 2009-12-20 15:33:20 +0100 (So, 20 Dez 2009) | 1 line

    #7381: subprocess documentation and library docstring consistency fixes.
  ........
................
  r77009 | georg.brandl | 2009-12-23 11:30:45 +0100 (Mi, 23 Dez 2009) | 1 line

  #7417: add signature to open() docstring.
................
  r77082 | georg.brandl | 2009-12-28 08:59:20 +0100 (Mo, 28 Dez 2009) | 1 line

  #7577: fix signature info for getbufferproc.
................
  r77083 | georg.brandl | 2009-12-28 09:00:47 +0100 (Mo, 28 Dez 2009) | 9 lines

  Merged revisions 77081 via svnmerge from
  svn+ssh://pythondev@svn.python.org/python/trunk

  ........
    r77081 | georg.brandl | 2009-12-28 08:59:05 +0100 (Mo, 28 Dez 2009) | 1 line

    #7577: fix signature of PyBuffer_FillInfo().
  ........
................
  r77085 | georg.brandl | 2009-12-28 09:02:38 +0100 (Mo, 28 Dez 2009) | 9 lines

  Merged revisions 77084 via svnmerge from
  svn+ssh://pythondev@svn.python.org/python/trunk

  ........
    r77084 | georg.brandl | 2009-12-28 09:01:59 +0100 (Mo, 28 Dez 2009) | 1 line

    #7586: fix typo.
  ........
................
  r77087 | georg.brandl | 2009-12-28 09:10:38 +0100 (Mo, 28 Dez 2009) | 9 lines

  Recorded merge of revisions 77086 via svnmerge from
  svn+ssh://pythondev@svn.python.org/python/trunk

  ........
    r77086 | georg.brandl | 2009-12-28 09:09:32 +0100 (Mo, 28 Dez 2009) | 1 line

    #7381: consistency update, and backport avoiding ``None >= 0`` check from py3k.
  ........
................
  r77121 | georg.brandl | 2009-12-29 22:38:35 +0100 (Di, 29 Dez 2009) | 1 line

  #7590: exception classes no longer are in the "exceptions" module. Also clean up text that was written with string exceptions in mind.
................
 2010-10-06 07:17:29 +00:00
Brian Curtin
19651369e4 Adjust #8956 to add the bad signal number to the exception message. 2010-09-07 13:24:38 +00:00
Brian Curtin
5c997b8d90 Fix #8956. ValueError message was only mentioning one signal. 
Rather than list out the three signals (or more over time), the message was
made less specific but still descriptive.
 2010-09-06 16:29:29 +00:00
Tim Golden
595c8d34a3 #2304: fix incorporating Eric Smith's .format suggestion and tested on Ubuntu as well as Windows 2010-08-12 09:45:25 +00:00
Tim Golden
126c2960ca #2304: fix incorporating Eric Smith's .format suggestion and tested on Ubuntu as well as Windows 2010-08-11 14:20:40 +00:00
Benjamin Peterson
a0baf55b2b revert r83831, unix test breakage 2010-08-08 19:17:15 +00:00