mirror of
https://github.com/python/cpython.git
synced 2025-11-04 07:31:38 +00:00
4606b4089d
gh-136839: Refactor simple dict.update calls (GH-136811)
Refactor simple dict.update calls
This commit refactors simple `dict.update({key: value})` calls which can
be done via `dict[key] = value` instead.
I found those cases with the [semgrep](https://semgrep.dev/) tool:
```
$ semgrep --lang python --pattern '$DICT.update({$A: ...})'
┌─────────────────┐
│ 5 Code Findings │
└─────────────────┘
Lib/dataclasses.py
1268┆ slots.update({slot: doc})
Lib/multiprocessing/resource_tracker.py
50┆ _CLEANUP_FUNCS.update({
51┆ 'semaphore': _multiprocessing.sem_unlink,
52┆ })
⋮┆----------------------------------------
53┆ _CLEANUP_FUNCS.update({
54┆ 'shared_memory': _posixshmem.shm_unlink,
55┆ })
Lib/tkinter/scrolledtext.py
26┆ kw.update({'yscrollcommand': self.vbar.set})
Lib/xmlrpc/server.py
242┆ self.funcs.update({'system.multicall' : self.system_multicall})
```
(cherry picked from commit 69ea1b3a8f)
Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
56 lines
1.8 KiB
Python
56 lines
1.8 KiB
Python
"""A ScrolledText widget feels like a text widget but also has a
|
|
vertical scroll bar on its right. (Later, options may be added to
|
|
add a horizontal bar as well, to make the bars disappear
|
|
automatically when not needed, to move them to the other side of the
|
|
window, etc.)
|
|
|
|
Configuration options are passed to the Text widget.
|
|
A Frame widget is inserted between the master and the text, to hold
|
|
the Scrollbar widget.
|
|
Most methods calls are inherited from the Text widget; Pack, Grid and
|
|
Place methods are redirected to the Frame widget however.
|
|
"""
|
|
|
|
from tkinter import Frame, Text, Scrollbar, Pack, Grid, Place
|
|
from tkinter.constants import RIGHT, LEFT, Y, BOTH
|
|
|
|
__all__ = ['ScrolledText']
|
|
|
|
|
|
class ScrolledText(Text):
|
|
def __init__(self, master=None, **kw):
|
|
self.frame = Frame(master)
|
|
self.vbar = Scrollbar(self.frame)
|
|
self.vbar.pack(side=RIGHT, fill=Y)
|
|
|
|
kw['yscrollcommand'] = self.vbar.set
|
|
Text.__init__(self, self.frame, **kw)
|
|
self.pack(side=LEFT, fill=BOTH, expand=True)
|
|
self.vbar['command'] = self.yview
|
|
|
|
# Copy geometry methods of self.frame without overriding Text
|
|
# methods -- hack!
|
|
text_meths = vars(Text).keys()
|
|
methods = vars(Pack).keys() | vars(Grid).keys() | vars(Place).keys()
|
|
methods = methods.difference(text_meths)
|
|
|
|
for m in methods:
|
|
if m[0] != '_' and m != 'config' and m != 'configure':
|
|
setattr(self, m, getattr(self.frame, m))
|
|
|
|
def __str__(self):
|
|
return str(self.frame)
|
|
|
|
|
|
def example():
|
|
from tkinter.constants import END
|
|
|
|
stext = ScrolledText(bg='white', height=10)
|
|
stext.insert(END, __doc__)
|
|
stext.pack(fill=BOTH, side=LEFT, expand=True)
|
|
stext.focus_set()
|
|
stext.mainloop()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
example()
|