ffmpeg/libavcodec/aarch64
Martin Storsjö d05786cf23 aarch64: vp9lpf: Fix GCS violations
The aarch64 VP9 loopfilters actually violate aarch64 GCS
(Guarded Control Stack), even though we marked the code as GCS
compliant in 846746be4b.

This means that builds with GCS enabled, after that commit,
will crash when decoding VP9, on future hardware (or current
QEMU) that supports GCS. This also goes for ffmpeg version 8.1.1
where the GCS enabling was backported.

This matches the fix that was done for hevcdsp in
1f7ed8a78d.

This issue wasn't observed if running checkasm in QEMU - therefore,
I thought all GCS issues had been fixed by
846746be4b. (If I would have
tested the full "make fate" with QEMU, the issue would
have appeared though.)

However with the new checkasm, some of the GCS violations
do appear even in checkasm.

The reason is that the checkasm vp9 test intentionally craft
input pixels that attempt to trigger all the individual
separate cases in each input buffer (in
randomize_loopfilter_buffers). This means that the checkasm
tests actually never test or exercise the early exit cases,
which are the ones that violate GCS.

With the new checkasm, the call to "bench_new" always test
running the code at least once, even if not benchmarking.

As the input buffers weren't reinitialized between the test
and "bench_new", the pixel differences now differ from the
initial setup, so that the code now some times (often) would
end up hitting the early exit cases.

Ideally, the vp9 checkasm test would be repeated to cover all
cases of input buffers that allow early exits, in addition to
covering the case with all different cases in one block.
2026-06-10 18:03:01 +00:00
..
h26x aarch64: Add PAC sign/validation of the link register 2026-03-20 13:16:06 +02:00
vvc aarch64/vvc: Optimisations of put_chroma_hv() functions for 10/12-bit 2026-04-27 20:10:57 +00:00
aacencdsp_init.c
aacencdsp_neon.S
aacpsdsp_init_aarch64.c
aacpsdsp_neon.S
ac3dsp_init_aarch64.c
ac3dsp_neon.S
cabac.h
dcadsp_init_aarch64.c avcodec/aarch64: add NEON DCA LFE FIR filter functions 2026-04-27 20:13:23 +00:00
dcadsp_neon.S avcodec/aarch64: add NEON DCA LFE FIR filter functions 2026-04-27 20:13:23 +00:00
fdct.h
fdctdsp_init_aarch64.c
fdctdsp_neon.S
fmtconvert_init.c
fmtconvert_neon.S
h264chroma_init_aarch64.c
h264cmc_neon.S
h264dsp_init_aarch64.c avcodec/h264dsp: Remove redundant h264 from H264DSPCtx member names 2026-01-25 22:53:25 +01:00
h264dsp_neon.S
h264idct_neon.S
h264pred_init.c aarch64/h264pred: disable inefficient functions 2026-02-04 09:06:37 +00:00
h264pred_neon.S lavc/aarch64: Fix addp overflow in ff_pred16x16_plane_neon_10 2025-10-24 15:32:35 +00:00
h264qpel_init_aarch64.c
h264qpel_neon.S
hevcdsp_deblock_neon.S aarch64: hevcdsp: Make returns match the call site 2026-03-17 20:37:53 +00:00
hevcdsp_dequant_neon.S lavc/hevc: add aarch64 neon for 12-bit dequant 2026-01-25 06:55:26 +00:00
hevcdsp_idct_neon.S
hevcdsp_init_aarch64.c lavc/hevc: reorder aarch64 NEON pel function assignments 2026-03-13 21:43:37 +00:00
hevcpred_init_aarch64.c lavc/hevc: add aarch64 NEON for angular modes 10 and 26 2026-06-07 23:29:33 +00:00
hevcpred_neon.S lavc/hevc: add aarch64 NEON for angular modes 10 and 26 2026-06-07 23:29:33 +00:00
hpeldsp_init_aarch64.c
hpeldsp_neon.S aarch64/hpeldsp_neon: fix out-of-bounds read 2026-01-04 03:22:55 +00:00
huffyuvdsp_init_aarch64.c libavcodec/huffyuvdsp: Add NEON optimization for the add_int16 function 2026-03-04 22:31:19 +00:00
huffyuvdsp_neon.S libavcodec/huffyuvdsp: Add NEON optimization for the add_int16 function 2026-03-04 22:31:19 +00:00
idct.h
idctdsp_init_aarch64.c
idctdsp_neon.S
Makefile avcodec/aarch64: add NEON DCA LFE FIR filter functions 2026-04-27 20:13:23 +00:00
me_cmp_init_aarch64.c
me_cmp_neon.S aarch64: Add PAC sign/validation of the link register 2026-03-20 13:16:06 +02:00
mpegaudiodsp_init.c
mpegaudiodsp_neon.S
mpegvideoencdsp_init.c
mpegvideoencdsp_neon.S
neon.S
neontest.c
opusdsp_init.c
opusdsp_neon.S
pixblockdsp_init_aarch64.c avcodec/pixblockdsp: be consistent about restrict use in ff_{get,diff}_pixels 2025-10-25 01:01:15 +02:00
pixblockdsp_neon.S
pngdsp_init.c avcodec/aarch64: add pngdsp 2026-02-04 12:05:35 +08:00
pngdsp_neon.S avcodec/aarch64: add pngdsp 2026-02-04 12:05:35 +08:00
rv40dsp_init_aarch64.c
sbrdsp_init_aarch64.c
sbrdsp_neon.S aarch64/sbrdsp: unroll sum64x5 to 16 floats/iter 2026-06-03 10:40:20 +00:00
simple_idct_neon.S
synth_filter_init.c
synth_filter_neon.S
vc1dsp_init_aarch64.c
vc1dsp_neon.S
videodsp.S
videodsp_init.c
vorbisdsp_init.c
vorbisdsp_neon.S
vp8dsp.h
vp8dsp_init_aarch64.c
vp8dsp_neon.S
vp9dsp_init.h
vp9dsp_init_10bpp_aarch64.c
vp9dsp_init_12bpp_aarch64.c
vp9dsp_init_16bpp_aarch64_template.c
vp9dsp_init_aarch64.c
vp9itxfm_16bpp_neon.S
vp9itxfm_neon.S
vp9lpf_16bpp_neon.S aarch64: vp9lpf: Fix GCS violations 2026-06-10 18:03:01 +00:00
vp9lpf_neon.S aarch64: vp9lpf: Fix GCS violations 2026-06-10 18:03:01 +00:00
vp9mc_16bpp_neon.S
vp9mc_aarch64.S
vp9mc_neon.S