mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-12-08 06:29:47 +00:00
0ecc6ef632
Three fixes are presented together in this PR:
- When a `strategy.matrix` entry in an Action job contains `${{ needs.some-job.outputs.some-output }}`, if that output *never* becomes available, different error messages will be presented if `some-job` isn't found or if `some-output` isn't found. This clarifies an error message that was previously "it could be this, or it could be this".
- In the error case described in the previous point, other jobs in the workflow could continue running or could be left "blocked" forever. A centralized `FailRunPreExecutionError` function ensures that all incomplete jobs in the run are failed in this case.
- In a rare error case when a job referenced another job in `strategy.matrix` but no other jobs were defined in the workflow, the job would be marked as blocked forever because the `job_emitter` code would never be invoked to detect this case. A new `consistencyCheckRun` function for a newly created `ActionRun` adds a location to perform a pre-execution check for this case so that the run can be failed.
These fixes are all interconnected around the refactor for the `FailRunPreExecutionError`, causing them to be bundled rather than individual PRs.
## Checklist
The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org).
### Tests
- I added test coverage for Go changes...
- [x] in their respective `*_test.go` for unit tests.
- [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server.
- I added test coverage for JavaScript changes...
- [ ] in `web_src/js/*.test.js` if it can be unit tested.
- [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)).
### Documentation
- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [x] I did not document these changes and I do not expect someone else to do it.
### Release notes
- [x] I do not want this change to show in the release notes.
- These are fixes to an unreleased feature and don't require release notes.
- [ ] I want the title to show in the release notes with a link to this pull request.
- [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10298
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net>
Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
113 lines
2.3 KiB
YAML
113 lines
2.3 KiB
YAML
-
|
|
id: 600
|
|
run_id: 900
|
|
repo_id: 63
|
|
owner_id: 2
|
|
commit_sha: 97f29ee599c373c729132a5c46a046978311e0ee
|
|
is_fork_pull_request: 0
|
|
name: job_1
|
|
attempt: 0
|
|
job_id: job_1
|
|
task_id: 0
|
|
status: 7 # blocked
|
|
runs_on: '["fedora"]'
|
|
started: 1683636528
|
|
needs: '[]'
|
|
workflow_payload: |
|
|
"on":
|
|
push:
|
|
jobs:
|
|
produce-artifacts:
|
|
name: produce-artifacts
|
|
runs-on: docker
|
|
steps:
|
|
- run: echo "OK!"
|
|
strategy:
|
|
matrix:
|
|
color: red
|
|
|
|
-
|
|
id: 601
|
|
run_id: 901
|
|
repo_id: 63
|
|
owner_id: 2
|
|
commit_sha: 97f29ee599c373c729132a5c46a046978311e0ee
|
|
is_fork_pull_request: 0
|
|
name: job_1
|
|
attempt: 0
|
|
job_id: job_1
|
|
task_id: 0
|
|
status: 7 # blocked
|
|
runs_on: '["fedora"]'
|
|
needs: '["define-matrix"]'
|
|
workflow_payload: |
|
|
"on":
|
|
push:
|
|
jobs:
|
|
produce-artifacts:
|
|
name: produce-artifacts (incomplete matrix)
|
|
runs-on: docker
|
|
steps:
|
|
- run: echo "OK!"
|
|
strategy:
|
|
matrix:
|
|
color: ${{ fromJSON(needs.define-matrix.outputs.colors) }}
|
|
incomplete_matrix: true
|
|
incomplete_matrix_needs:
|
|
job: define-matrix
|
|
-
|
|
id: 602
|
|
run_id: 901
|
|
repo_id: 63
|
|
owner_id: 2
|
|
commit_sha: 97f29ee599c373c729132a5c46a046978311e0ee
|
|
is_fork_pull_request: 0
|
|
name: define-matrix
|
|
attempt: 0
|
|
job_id: define-matrix
|
|
task_id: 100
|
|
status: 1 # success
|
|
runs_on: '["fedora"]'
|
|
|
|
-
|
|
id: 603
|
|
run_id: 902
|
|
repo_id: 63
|
|
owner_id: 2
|
|
commit_sha: 97f29ee599c373c729132a5c46a046978311e0ee
|
|
is_fork_pull_request: 0
|
|
name: job_1
|
|
attempt: 0
|
|
job_id: job_1
|
|
task_id: 0
|
|
status: 7 # blocked
|
|
runs_on: '["fedora"]'
|
|
needs: '["define-matrix"]'
|
|
workflow_payload: |
|
|
"on":
|
|
push:
|
|
jobs:
|
|
produce-artifacts:
|
|
name: produce-artifacts (incomplete matrix)
|
|
runs-on: docker
|
|
steps:
|
|
- run: echo "OK!"
|
|
strategy:
|
|
matrix:
|
|
color: ${{ fromJSON(needs.oops-something-wrong-here.outputs.colors) }}
|
|
incomplete_matrix: true
|
|
incomplete_matrix_needs:
|
|
job: oops-something-wrong-here
|
|
-
|
|
id: 604
|
|
run_id: 902
|
|
repo_id: 63
|
|
owner_id: 2
|
|
commit_sha: 97f29ee599c373c729132a5c46a046978311e0ee
|
|
is_fork_pull_request: 0
|
|
name: define-matrix
|
|
attempt: 0
|
|
job_id: define-matrix
|
|
task_id: 100
|
|
status: 1 # success
|
|
runs_on: '["fedora"]'
|