mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-06-05 04:30:28 +00:00
385c0db94f
Weirdly, git doesn't verify the consistency of objects when receiving new objects. Enable that git verifies this, so we don't allow a repository to get in a weird or even corrupt state. We've already dealt with a few cases of inconsistent objects, the most notable one being mode of objects (forgejo/forgejo!9161). This can be risky, as such ignore 3 consistency checks that are not harmful to ignore and is battle tested by Gitlab. bad timezone:692a0d3476missing space:2da0b39399non-zero padded filemode:db8f2e8da5Typically we set these settings in `modules/git/git.go`, but that means a instance administrator wouldn't be able to override it. Given we don't strictly require these settings to be set. A instance admin could choose to disable the consistency checks or override our set of ignores this would allow them to do so via the `[git.config]` section. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12695 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> Reviewed-by: elle <0xllx0@noreply.codeberg.org>
74 lines
2.2 KiB
Go
74 lines
2.2 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package setting
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"forgejo.org/modules/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestGitConfig(t *testing.T) {
|
|
defer test.MockProtect(&Git)()
|
|
defer test.MockProtect(&GitConfig)()
|
|
|
|
cfg, err := NewConfigProviderFromData(`
|
|
[git.config]
|
|
a.b = 1
|
|
`)
|
|
require.NoError(t, err)
|
|
loadGitFrom(cfg)
|
|
assert.Equal(t, "1", GitConfig.Options["a.b"])
|
|
assert.Equal(t, "histogram", GitConfig.Options["diff.algorithm"])
|
|
|
|
cfg, err = NewConfigProviderFromData(`
|
|
[git.config]
|
|
diff.algorithm = other
|
|
`)
|
|
require.NoError(t, err)
|
|
loadGitFrom(cfg)
|
|
assert.Equal(t, "other", GitConfig.Options["diff.algorithm"])
|
|
|
|
t.Run("Fsck options", func(t *testing.T) {
|
|
cfg, err := NewConfigProviderFromData(`
|
|
[git.config]
|
|
receive.fsckObjects = false
|
|
fetch.fsck.zeroPaddedFilemode = warn
|
|
fsck.missingSpaceBeforeDate = error
|
|
`)
|
|
require.NoError(t, err)
|
|
loadGitFrom(cfg)
|
|
assert.Equal(t, "false", GitConfig.Options["receive.fsckobjects"])
|
|
assert.Equal(t, "true", GitConfig.Options["transfer.fsckobjects"])
|
|
assert.NotContains(t, GitConfig.Options, "fetch.fsckobjects")
|
|
|
|
assert.Equal(t, "ignore", GitConfig.Options["fsck.badtimezone"])
|
|
assert.Equal(t, "error", GitConfig.Options["fsck.missingspacebeforedate"])
|
|
assert.Equal(t, "ignore", GitConfig.Options["fsck.zeropaddedfilemode"])
|
|
|
|
assert.Equal(t, "ignore", GitConfig.Options["receive.fsck.badtimezone"])
|
|
assert.Equal(t, "ignore", GitConfig.Options["receive.fsck.missingspacebeforedate"])
|
|
assert.Equal(t, "ignore", GitConfig.Options["receive.fsck.zeropaddedfilemode"])
|
|
|
|
assert.Equal(t, "ignore", GitConfig.Options["fetch.fsck.badtimezone"])
|
|
assert.Equal(t, "ignore", GitConfig.Options["fetch.fsck.missingspacebeforedate"])
|
|
assert.Equal(t, "warn", GitConfig.Options["fetch.fsck.zeropaddedfilemode"])
|
|
})
|
|
}
|
|
|
|
func TestGitReflog(t *testing.T) {
|
|
defer test.MockProtect(&Git)()
|
|
defer test.MockProtect(&GitConfig)()
|
|
|
|
// default reflog config.
|
|
cfg, err := NewConfigProviderFromData(``)
|
|
require.NoError(t, err)
|
|
loadGitFrom(cfg)
|
|
|
|
assert.Equal(t, "true", GitConfig.GetOption("core.logAllRefUpdates"))
|
|
assert.Equal(t, "90", GitConfig.GetOption("gc.reflogExpire"))
|
|
}
|