mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-04-18 20:40:23 +00:00
607d031069
**Backport: !11936** - Go has a suite of small linters that helps with modernizing Go code by using newer functions and catching small mistakes, https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/modernize. - Enable this linter in golangci-lint. - There's also [`go fix`](https://go.dev/blog/gofix), which is not yet released as a linter in golangci-lint: https://github.com/golangci/golangci-lint/pull/6385 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11949 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-committed-by: Gusted <postmaster@gusted.xyz>
141 lines
3.5 KiB
Go
141 lines
3.5 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package queue
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func testQueueBasic(t *testing.T, newFn func(cfg *BaseConfig) (baseQueue, error), cfg *BaseConfig, isUnique bool) {
|
|
t.Run(fmt.Sprintf("testQueueBasic-%s-unique:%v", cfg.ManagedName, isUnique), func(t *testing.T) {
|
|
q, err := newFn(cfg)
|
|
require.NoError(t, err)
|
|
|
|
ctx := t.Context()
|
|
_ = q.RemoveAll(ctx)
|
|
cnt, err := q.Len(ctx)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, 0, cnt)
|
|
|
|
// push the first item
|
|
err = q.PushItem(ctx, []byte("foo"))
|
|
require.NoError(t, err)
|
|
|
|
cnt, err = q.Len(ctx)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, 1, cnt)
|
|
|
|
// push a duplicate item
|
|
err = q.PushItem(ctx, []byte("foo"))
|
|
if !isUnique {
|
|
require.NoError(t, err)
|
|
} else {
|
|
require.ErrorIs(t, err, ErrAlreadyInQueue)
|
|
}
|
|
|
|
// check the duplicate item
|
|
cnt, err = q.Len(ctx)
|
|
require.NoError(t, err)
|
|
has, err := q.HasItem(ctx, []byte("foo"))
|
|
require.NoError(t, err)
|
|
if !isUnique {
|
|
assert.Equal(t, 2, cnt)
|
|
assert.False(t, has) // non-unique queues don't check for duplicates
|
|
} else {
|
|
assert.Equal(t, 1, cnt)
|
|
assert.True(t, has)
|
|
}
|
|
|
|
// push another item
|
|
err = q.PushItem(ctx, []byte("bar"))
|
|
require.NoError(t, err)
|
|
|
|
// pop the first item (and the duplicate if non-unique)
|
|
it, err := q.PopItem(ctx)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "foo", string(it))
|
|
|
|
if !isUnique {
|
|
it, err = q.PopItem(ctx)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "foo", string(it))
|
|
}
|
|
|
|
// pop another item
|
|
it, err = q.PopItem(ctx)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "bar", string(it))
|
|
|
|
// pop an empty queue (timeout, cancel)
|
|
ctxTimed, cancel := context.WithTimeout(ctx, 10*time.Millisecond)
|
|
it, err = q.PopItem(ctxTimed)
|
|
require.ErrorIs(t, err, context.DeadlineExceeded)
|
|
assert.Nil(t, it)
|
|
cancel()
|
|
|
|
ctxTimed, cancel = context.WithTimeout(ctx, 10*time.Millisecond)
|
|
cancel()
|
|
it, err = q.PopItem(ctxTimed)
|
|
require.ErrorIs(t, err, context.Canceled)
|
|
assert.Nil(t, it)
|
|
|
|
// test blocking push if queue is full
|
|
for i := 0; i < cfg.Length; i++ {
|
|
err = q.PushItem(ctx, fmt.Appendf(nil, "item-%d", i))
|
|
require.NoError(t, err)
|
|
}
|
|
ctxTimed, cancel = context.WithTimeout(ctx, 10*time.Millisecond)
|
|
err = q.PushItem(ctxTimed, []byte("item-full"))
|
|
require.ErrorIs(t, err, context.DeadlineExceeded)
|
|
cancel()
|
|
|
|
// test blocking push if queue is full (with custom pushBlockTime)
|
|
oldPushBlockTime := pushBlockTime
|
|
timeStart := time.Now()
|
|
pushBlockTime = 30 * time.Millisecond
|
|
err = q.PushItem(ctx, []byte("item-full"))
|
|
require.ErrorIs(t, err, context.DeadlineExceeded)
|
|
assert.GreaterOrEqual(t, time.Since(timeStart), pushBlockTime*2/3)
|
|
pushBlockTime = oldPushBlockTime
|
|
|
|
// remove all
|
|
cnt, err = q.Len(ctx)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, cfg.Length, cnt)
|
|
|
|
_ = q.RemoveAll(ctx)
|
|
|
|
cnt, err = q.Len(ctx)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, 0, cnt)
|
|
})
|
|
}
|
|
|
|
func TestBaseDummy(t *testing.T) {
|
|
q, err := newBaseDummy(&BaseConfig{}, true)
|
|
require.NoError(t, err)
|
|
|
|
ctx := t.Context()
|
|
require.NoError(t, q.PushItem(ctx, []byte("foo")))
|
|
|
|
cnt, err := q.Len(ctx)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, 0, cnt)
|
|
|
|
has, err := q.HasItem(ctx, []byte("foo"))
|
|
require.NoError(t, err)
|
|
assert.False(t, has)
|
|
|
|
it, err := q.PopItem(ctx)
|
|
require.NoError(t, err)
|
|
assert.Nil(t, it)
|
|
|
|
require.NoError(t, q.RemoveAll(ctx))
|
|
}
|