mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-04-19 13:00:20 +00:00
607d031069
**Backport: !11936** - Go has a suite of small linters that helps with modernizing Go code by using newer functions and catching small mistakes, https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/modernize. - Enable this linter in golangci-lint. - There's also [`go fix`](https://go.dev/blog/gofix), which is not yet released as a linter in golangci-lint: https://github.com/golangci/golangci-lint/pull/6385 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11949 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-committed-by: Gusted <postmaster@gusted.xyz>
95 lines
2 KiB
Go
95 lines
2 KiB
Go
// Copyright 2023, 2024, 2025 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package validation
|
|
|
|
import (
|
|
"fmt"
|
|
"reflect"
|
|
"slices"
|
|
"strings"
|
|
"unicode/utf8"
|
|
|
|
"forgejo.org/modules/timeutil"
|
|
|
|
ap "github.com/go-ap/activitypub"
|
|
)
|
|
|
|
// ErrNotValid represents an validation error
|
|
type ErrNotValid struct {
|
|
Message string
|
|
}
|
|
|
|
func (err ErrNotValid) Error() string {
|
|
return fmt.Sprintf("Validation Error: %v", err.Message)
|
|
}
|
|
|
|
// IsErrNotValid checks if an error is a ErrNotValid.
|
|
func IsErrNotValid(err error) bool {
|
|
_, ok := err.(ErrNotValid)
|
|
return ok
|
|
}
|
|
|
|
type Validateable interface {
|
|
Validate() []string
|
|
}
|
|
|
|
func IsValid(v Validateable) (bool, error) {
|
|
if validationErrors := v.Validate(); len(validationErrors) > 0 {
|
|
typeof := reflect.TypeOf(v)
|
|
errString := strings.Join(validationErrors, "\n")
|
|
return false, ErrNotValid{fmt.Sprint(typeof, ": ", errString)}
|
|
}
|
|
|
|
return true, nil
|
|
}
|
|
|
|
func ValidateIDExists(value ap.Item, name string) []string {
|
|
if value == nil {
|
|
return []string{fmt.Sprintf("Field %v must not be nil", name)}
|
|
}
|
|
return ValidateNotEmpty(value.GetID().String(), name)
|
|
}
|
|
|
|
func ValidateNotEmpty(value any, name string) []string {
|
|
isValid := true
|
|
switch v := value.(type) {
|
|
case string:
|
|
if v == "" {
|
|
isValid = false
|
|
}
|
|
case timeutil.TimeStamp:
|
|
if v.IsZero() {
|
|
isValid = false
|
|
}
|
|
case uint16:
|
|
if v == 0 {
|
|
isValid = false
|
|
}
|
|
case int64:
|
|
if v == 0 {
|
|
isValid = false
|
|
}
|
|
default:
|
|
isValid = false
|
|
}
|
|
|
|
if isValid {
|
|
return []string{}
|
|
}
|
|
return []string{fmt.Sprintf("Value %v should not be empty", name)}
|
|
}
|
|
|
|
func ValidateMaxLen(value string, maxLen int, name string) []string {
|
|
if utf8.RuneCountInString(value) > maxLen {
|
|
return []string{fmt.Sprintf("Value %v is longer than expected length %v", name, maxLen)}
|
|
}
|
|
return []string{}
|
|
}
|
|
|
|
func ValidateOneOf(value any, allowed []any, name string) []string {
|
|
if slices.Contains(allowed, value) {
|
|
return []string{}
|
|
}
|
|
return []string{fmt.Sprintf("Field %s contains the value %v, which is not in allowed subset %v", name, value, allowed)}
|
|
}
|