mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-12-07 14:09:47 +00:00
ac487e93d9
The package cleanup routine checks every container version for whether it is referenced by a multi-platform manifest, which appears to be a performance problem indicated by CPU profiling collected in #9358 on SQLite systems. This PR removes that check completely, which isn't necessary since #4698 added a much more performant mass-cleanup of these dangling platform versions. May fix #9358 completely, but it leaves fundamental scalability concerns with SQLite due to long-running transactions. The transactions will be shorter with this change. Requires end-user testing to confirm if sufficiently fixed. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Bug fixes - [PR](https://codeberg.org/forgejo/forgejo/pulls/10297): <!--number 10297 --><!--line 0 --><!--description cmVkdWNlIHJ1bnRpbWUgb2YgY29udGFpbmVyIGNsZWFudXAgYnkgcmVseWluZyBvbiBtYXNzIGRpZ2VzdCBjbGVhbnVw-->reduce runtime of container cleanup by relying on mass digest cleanup<!--description--> <!--end release-notes-assistant--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10297 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
128 lines
3.8 KiB
YAML
128 lines
3.8 KiB
YAML
- id: 4090
|
|
version_id: 736
|
|
blob_id: 1214
|
|
name: sha256_efc44d65797de15fdc9787e194f9e24ea42adc2fa2821203bb65ead939908375
|
|
lower_name: sha256_efc44d65797de15fdc9787e194f9e24ea42adc2fa2821203bb65ead939908375
|
|
composite_key: ''
|
|
is_lead: false
|
|
created_unix: 1764694509
|
|
- id: 4091
|
|
version_id: 736
|
|
blob_id: 222
|
|
name: sha256_63d36825ec9a6be406f73910fa6f0d6542a7b993a750aac151f30a8e1fd58cf7
|
|
lower_name: sha256_63d36825ec9a6be406f73910fa6f0d6542a7b993a750aac151f30a8e1fd58cf7
|
|
composite_key: ''
|
|
is_lead: false
|
|
created_unix: 1764694509
|
|
- id: 4092
|
|
version_id: 736
|
|
blob_id: 1212
|
|
name: sha256_9a0d1f70c6da347f1fa0c3856bbe2642a317361a54ca8b0e44b64c362b45e01d
|
|
lower_name: sha256_9a0d1f70c6da347f1fa0c3856bbe2642a317361a54ca8b0e44b64c362b45e01d
|
|
composite_key: ''
|
|
is_lead: false
|
|
created_unix: 1764694509
|
|
- id: 4093
|
|
version_id: 736
|
|
blob_id: 1213
|
|
name: sha256_5a0f445468c4d9b40c4efb4bb292967672f5e9a2dd23e605a34fe10898e4cc4e
|
|
lower_name: sha256_5a0f445468c4d9b40c4efb4bb292967672f5e9a2dd23e605a34fe10898e4cc4e
|
|
composite_key: ''
|
|
is_lead: false
|
|
created_unix: 1764694509
|
|
- id: 4094
|
|
version_id: 736
|
|
blob_id: 1215
|
|
name: manifest.json
|
|
lower_name: manifest.json
|
|
composite_key: ''
|
|
is_lead: true
|
|
created_unix: 1764694509
|
|
- id: 4099
|
|
version_id: 737
|
|
blob_id: 1219
|
|
name: sha256_495a889816ababcd9e1af0ed66ccc55c7225c6fcf171a7eac3f24ee62fa30f74
|
|
lower_name: sha256_495a889816ababcd9e1af0ed66ccc55c7225c6fcf171a7eac3f24ee62fa30f74
|
|
composite_key: ''
|
|
is_lead: false
|
|
created_unix: 1764694509
|
|
- id: 4100
|
|
version_id: 737
|
|
blob_id: 1216
|
|
name: sha256_5096682701dd58e54ccbeb5d1fa285e9980a86568cfb0ca522fd4871892ab318
|
|
lower_name: sha256_5096682701dd58e54ccbeb5d1fa285e9980a86568cfb0ca522fd4871892ab318
|
|
composite_key: ''
|
|
is_lead: false
|
|
created_unix: 1764694509
|
|
- id: 4101
|
|
version_id: 737
|
|
blob_id: 1218
|
|
name: sha256_714573ef664bd4969f0cb9b445efbb337f0d2f52d906f3f1323063ca9bdcb6a6
|
|
lower_name: sha256_714573ef664bd4969f0cb9b445efbb337f0d2f52d906f3f1323063ca9bdcb6a6
|
|
composite_key: ''
|
|
is_lead: false
|
|
created_unix: 1764694509
|
|
- id: 4102
|
|
version_id: 737
|
|
blob_id: 1217
|
|
name: sha256_3dbb52544aa310f7819092b6c556aa1fb446e2c77711eda8e4680851445f8f18
|
|
lower_name: sha256_3dbb52544aa310f7819092b6c556aa1fb446e2c77711eda8e4680851445f8f18
|
|
composite_key: ''
|
|
is_lead: false
|
|
created_unix: 1764694509
|
|
- id: 4103
|
|
version_id: 737
|
|
blob_id: 1220
|
|
name: manifest.json
|
|
lower_name: manifest.json
|
|
composite_key: ''
|
|
is_lead: true
|
|
created_unix: 1764694509
|
|
- id: 4104
|
|
version_id: 738
|
|
blob_id: 1221
|
|
name: manifest.json
|
|
lower_name: manifest.json
|
|
composite_key: ''
|
|
is_lead: true
|
|
created_unix: 1764694509
|
|
- id: 4115
|
|
version_id: 740
|
|
blob_id: 2114
|
|
name: sha256_dd4d2c29faafea81b0b44cf8df13b8d0e01bc42059cdb69bf8f5d147b29904bf
|
|
lower_name: sha256_dd4d2c29faafea81b0b44cf8df13b8d0e01bc42059cdb69bf8f5d147b29904bf
|
|
composite_key: ''
|
|
is_lead: false
|
|
created_unix: 1764695172
|
|
- id: 4116
|
|
version_id: 740
|
|
blob_id: 222
|
|
name: sha256_63d36825ec9a6be406f73910fa6f0d6542a7b993a750aac151f30a8e1fd58cf7
|
|
lower_name: sha256_63d36825ec9a6be406f73910fa6f0d6542a7b993a750aac151f30a8e1fd58cf7
|
|
composite_key: ''
|
|
is_lead: false
|
|
created_unix: 1764695172
|
|
- id: 4117
|
|
version_id: 740
|
|
blob_id: 1222
|
|
name: sha256_9c3b61a2981c0986b91339acca08bff16acc239d1909037652d6f439d3e84578
|
|
lower_name: sha256_9c3b61a2981c0986b91339acca08bff16acc239d1909037652d6f439d3e84578
|
|
composite_key: ''
|
|
is_lead: false
|
|
created_unix: 1764695172
|
|
- id: 4118
|
|
version_id: 740
|
|
blob_id: 2113
|
|
name: sha256_bbd073df829f756775f9e7143f99bd5a0637a4be4ba95280a496c732e9ed45ea
|
|
lower_name: sha256_bbd073df829f756775f9e7143f99bd5a0637a4be4ba95280a496c732e9ed45ea
|
|
composite_key: ''
|
|
is_lead: false
|
|
created_unix: 1764695172
|
|
- id: 4119
|
|
version_id: 740
|
|
blob_id: 2115
|
|
name: manifest.json
|
|
lower_name: manifest.json
|
|
composite_key: ''
|
|
is_lead: true
|
|
created_unix: 1764695172
|