Mathieu Fenniak 6ac0ab3549 test(e2e): improve resiliency of accessibilityCheck (#9051) ... In the helper method `accessibilityCheck`, accessibility checks are performed on the page including measurements of contrast between elements, and the theme is transitioned from the `light` to `dark` theme and back between two checks (with a hard-coded 100ms wait). Experimentally this is proven to result in false-positive failures of the accessibilityCheck. I believe the cause of these failures are CSS transitions that are occurring either between the theme transition, or from operations that have occurred before the `accessibilityCheck` method is called. For example, one test `Markdown insert link` pops open the `Add a link` dialog box which has a CSS transition applied as the background is greyed out. To fix this, I've wrapped both accessibility scans within `accessibilityCheck` in a `expect(...).toPass({ timeout: 1000 })` to allow Playwright to retry the assertions over the next second. 1 second exceeds the time that I've observed of any CSS transition in the project (max found was 0.3 seconds). Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9051 Reviewed-by: Antonin Delpeuch <wetneb@noreply.codeberg.org> Reviewed-by: Beowulf <beowulf@beocode.eu> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>		2025-08-29 07:33:59 +02:00
..
accessibility.ts	test(e2e): improve resiliency of accessibilityCheck (#9051)	2025-08-29 07:33:59 +02:00
forms.ts	tests(e2e): Silence heading level warning (#8659)	2025-07-25 02:39:16 +02:00