2016-03-01 22:57:46 +00:00
|
|
|
// Copyright 2013 The Go Authors. All rights reserved.
|
2015-01-19 14:34:58 -05:00
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
|
|
package obj
|
|
|
|
|
|
|
|
|
|
import (
|
2016-07-28 13:04:41 -04:00
|
|
|
"cmd/internal/dwarf"
|
2017-04-18 12:53:25 -07:00
|
|
|
"cmd/internal/objabi"
|
2016-04-06 12:01:40 -07:00
|
|
|
"cmd/internal/sys"
|
2015-01-19 14:34:58 -05:00
|
|
|
"fmt"
|
2020-01-26 09:59:25 -08:00
|
|
|
"io"
|
2016-03-13 10:13:03 -07:00
|
|
|
"sort"
|
2017-10-06 11:32:28 -04:00
|
|
|
"sync"
|
2015-01-19 14:34:58 -05:00
|
|
|
)
|
|
|
|
|
|
2019-10-08 21:43:20 -04:00
|
|
|
func (ctxt *Link) writeSymDebug(s *LSym) {
|
2020-03-11 11:18:00 -04:00
|
|
|
ctxt.writeSymDebugNamed(s, s.Name)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (ctxt *Link) writeSymDebugNamed(s *LSym, name string) {
|
|
|
|
|
fmt.Fprintf(ctxt.Bso, "%s ", name)
|
2016-03-31 12:59:05 +03:00
|
|
|
if s.Type != 0 {
|
2017-04-16 14:48:16 -07:00
|
|
|
fmt.Fprintf(ctxt.Bso, "%v ", s.Type)
|
2016-03-31 12:59:05 +03:00
|
|
|
}
|
2017-04-20 07:13:02 -07:00
|
|
|
if s.Static() {
|
|
|
|
|
fmt.Fprint(ctxt.Bso, "static ")
|
|
|
|
|
}
|
2016-10-24 23:15:41 +03:00
|
|
|
if s.DuplicateOK() {
|
2016-03-31 12:59:05 +03:00
|
|
|
fmt.Fprintf(ctxt.Bso, "dupok ")
|
|
|
|
|
}
|
2016-10-24 23:15:41 +03:00
|
|
|
if s.CFunc() {
|
2016-03-31 12:59:05 +03:00
|
|
|
fmt.Fprintf(ctxt.Bso, "cfunc ")
|
|
|
|
|
}
|
2016-10-24 23:15:41 +03:00
|
|
|
if s.NoSplit() {
|
2016-03-31 12:59:05 +03:00
|
|
|
fmt.Fprintf(ctxt.Bso, "nosplit ")
|
|
|
|
|
}
|
2019-03-28 12:51:30 -04:00
|
|
|
if s.TopFrame() {
|
|
|
|
|
fmt.Fprintf(ctxt.Bso, "topframe ")
|
|
|
|
|
}
|
2016-03-31 12:59:05 +03:00
|
|
|
fmt.Fprintf(ctxt.Bso, "size=%d", s.Size)
|
2017-04-18 12:53:25 -07:00
|
|
|
if s.Type == objabi.STEXT {
|
2017-04-18 10:18:34 -07:00
|
|
|
fmt.Fprintf(ctxt.Bso, " args=%#x locals=%#x", uint64(s.Func.Args), uint64(s.Func.Locals))
|
2016-10-24 23:15:41 +03:00
|
|
|
if s.Leaf() {
|
2016-03-31 12:59:05 +03:00
|
|
|
fmt.Fprintf(ctxt.Bso, " leaf")
|
2015-01-19 14:34:58 -05:00
|
|
|
}
|
2016-03-31 12:59:05 +03:00
|
|
|
}
|
|
|
|
|
fmt.Fprintf(ctxt.Bso, "\n")
|
2017-04-18 12:53:25 -07:00
|
|
|
if s.Type == objabi.STEXT {
|
2017-04-18 10:18:34 -07:00
|
|
|
for p := s.Func.Text; p != nil; p = p.Link {
|
2020-01-26 09:59:25 -08:00
|
|
|
fmt.Fprintf(ctxt.Bso, "\t%#04x ", uint(int(p.Pc)))
|
2018-12-07 10:00:36 -08:00
|
|
|
if ctxt.Debugasm > 1 {
|
2020-01-26 09:59:25 -08:00
|
|
|
io.WriteString(ctxt.Bso, p.String())
|
2018-12-07 10:00:36 -08:00
|
|
|
} else {
|
2020-01-26 09:59:25 -08:00
|
|
|
p.InnermostString(ctxt.Bso)
|
2018-12-07 10:00:36 -08:00
|
|
|
}
|
2020-01-26 09:59:25 -08:00
|
|
|
fmt.Fprintln(ctxt.Bso)
|
2017-03-03 16:45:21 -08:00
|
|
|
}
|
2016-03-31 12:59:05 +03:00
|
|
|
}
|
2017-03-03 16:45:21 -08:00
|
|
|
for i := 0; i < len(s.P); i += 16 {
|
2016-03-31 12:59:05 +03:00
|
|
|
fmt.Fprintf(ctxt.Bso, "\t%#04x", uint(i))
|
2017-03-03 16:45:21 -08:00
|
|
|
j := i
|
2019-01-30 17:35:18 +00:00
|
|
|
for ; j < i+16 && j < len(s.P); j++ {
|
2016-03-31 12:59:05 +03:00
|
|
|
fmt.Fprintf(ctxt.Bso, " %02x", s.P[j])
|
2015-01-19 14:34:58 -05:00
|
|
|
}
|
2016-03-31 12:59:05 +03:00
|
|
|
for ; j < i+16; j++ {
|
|
|
|
|
fmt.Fprintf(ctxt.Bso, " ")
|
2015-01-19 14:34:58 -05:00
|
|
|
}
|
2016-03-31 12:59:05 +03:00
|
|
|
fmt.Fprintf(ctxt.Bso, " ")
|
|
|
|
|
for j = i; j < i+16 && j < len(s.P); j++ {
|
2017-03-03 16:45:21 -08:00
|
|
|
c := int(s.P[j])
|
2020-01-26 09:59:25 -08:00
|
|
|
b := byte('.')
|
2016-03-31 12:59:05 +03:00
|
|
|
if ' ' <= c && c <= 0x7e {
|
2020-01-26 09:59:25 -08:00
|
|
|
b = byte(c)
|
2015-01-19 14:34:58 -05:00
|
|
|
}
|
2020-01-26 09:59:25 -08:00
|
|
|
ctxt.Bso.WriteByte(b)
|
2015-01-19 14:34:58 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fmt.Fprintf(ctxt.Bso, "\n")
|
2016-03-31 12:59:05 +03:00
|
|
|
}
|
2015-01-19 14:34:58 -05:00
|
|
|
|
2016-03-31 12:59:05 +03:00
|
|
|
sort.Sort(relocByOff(s.R)) // generate stable output
|
|
|
|
|
for _, r := range s.R {
|
|
|
|
|
name := ""
|
|
|
|
|
if r.Sym != nil {
|
|
|
|
|
name = r.Sym.Name
|
2017-04-18 12:53:25 -07:00
|
|
|
} else if r.Type == objabi.R_TLS_LE {
|
2016-04-04 10:49:55 -07:00
|
|
|
name = "TLS"
|
2015-01-19 14:34:58 -05:00
|
|
|
}
|
2016-04-06 12:01:40 -07:00
|
|
|
if ctxt.Arch.InFamily(sys.ARM, sys.PPC64) {
|
2016-04-14 19:04:45 -07:00
|
|
|
fmt.Fprintf(ctxt.Bso, "\trel %d+%d t=%d %s+%x\n", int(r.Off), r.Siz, r.Type, name, uint64(r.Add))
|
2016-03-31 12:59:05 +03:00
|
|
|
} else {
|
2016-04-14 19:04:45 -07:00
|
|
|
fmt.Fprintf(ctxt.Bso, "\trel %d+%d t=%d %s+%d\n", int(r.Off), r.Siz, r.Type, name, r.Add)
|
2015-01-19 14:34:58 -05:00
|
|
|
}
|
|
|
|
|
}
|
2016-03-31 12:59:05 +03:00
|
|
|
}
|
2015-01-19 14:34:58 -05:00
|
|
|
|
2016-03-13 10:13:03 -07:00
|
|
|
// relocByOff sorts relocations by their offsets.
|
|
|
|
|
type relocByOff []Reloc
|
|
|
|
|
|
|
|
|
|
func (x relocByOff) Len() int { return len(x) }
|
|
|
|
|
func (x relocByOff) Less(i, j int) bool { return x[i].Off < x[j].Off }
|
|
|
|
|
func (x relocByOff) Swap(i, j int) { x[i], x[j] = x[j], x[i] }
|
2016-07-28 13:04:41 -04:00
|
|
|
|
|
|
|
|
// implement dwarf.Context
|
|
|
|
|
type dwCtxt struct{ *Link }
|
|
|
|
|
|
|
|
|
|
func (c dwCtxt) PtrSize() int {
|
|
|
|
|
return c.Arch.PtrSize
|
|
|
|
|
}
|
|
|
|
|
func (c dwCtxt) AddInt(s dwarf.Sym, size int, i int64) {
|
|
|
|
|
ls := s.(*LSym)
|
|
|
|
|
ls.WriteInt(c.Link, ls.Size, size, i)
|
|
|
|
|
}
|
2019-07-31 10:33:11 -04:00
|
|
|
func (c dwCtxt) AddUint16(s dwarf.Sym, i uint16) {
|
|
|
|
|
c.AddInt(s, 2, int64(i))
|
|
|
|
|
}
|
|
|
|
|
func (c dwCtxt) AddUint8(s dwarf.Sym, i uint8) {
|
|
|
|
|
b := []byte{byte(i)}
|
|
|
|
|
c.AddBytes(s, b)
|
|
|
|
|
}
|
2016-07-28 13:04:41 -04:00
|
|
|
func (c dwCtxt) AddBytes(s dwarf.Sym, b []byte) {
|
|
|
|
|
ls := s.(*LSym)
|
|
|
|
|
ls.WriteBytes(c.Link, ls.Size, b)
|
|
|
|
|
}
|
|
|
|
|
func (c dwCtxt) AddString(s dwarf.Sym, v string) {
|
|
|
|
|
ls := s.(*LSym)
|
|
|
|
|
ls.WriteString(c.Link, ls.Size, len(v), v)
|
|
|
|
|
ls.WriteInt(c.Link, ls.Size, 1, 0)
|
|
|
|
|
}
|
|
|
|
|
func (c dwCtxt) AddAddress(s dwarf.Sym, data interface{}, value int64) {
|
|
|
|
|
ls := s.(*LSym)
|
|
|
|
|
size := c.PtrSize()
|
2017-05-02 16:46:01 +02:00
|
|
|
if data != nil {
|
|
|
|
|
rsym := data.(*LSym)
|
|
|
|
|
ls.WriteAddr(c.Link, ls.Size, size, rsym, value)
|
|
|
|
|
} else {
|
|
|
|
|
ls.WriteInt(c.Link, ls.Size, size, value)
|
|
|
|
|
}
|
2016-07-28 13:04:41 -04:00
|
|
|
}
|
2019-04-02 17:26:49 -04:00
|
|
|
func (c dwCtxt) AddCURelativeAddress(s dwarf.Sym, data interface{}, value int64) {
|
|
|
|
|
ls := s.(*LSym)
|
|
|
|
|
rsym := data.(*LSym)
|
|
|
|
|
ls.WriteCURelativeAddr(c.Link, ls.Size, rsym, value)
|
|
|
|
|
}
|
2016-07-28 13:04:41 -04:00
|
|
|
func (c dwCtxt) AddSectionOffset(s dwarf.Sym, size int, t interface{}, ofs int64) {
|
2018-04-12 17:07:14 -04:00
|
|
|
panic("should be used only in the linker")
|
|
|
|
|
}
|
2018-09-28 16:44:30 +02:00
|
|
|
func (c dwCtxt) AddDWARFAddrSectionOffset(s dwarf.Sym, t interface{}, ofs int64) {
|
|
|
|
|
size := 4
|
|
|
|
|
if isDwarf64(c.Link) {
|
|
|
|
|
size = 8
|
|
|
|
|
}
|
|
|
|
|
|
2016-07-28 13:04:41 -04:00
|
|
|
ls := s.(*LSym)
|
|
|
|
|
rsym := t.(*LSym)
|
|
|
|
|
ls.WriteAddr(c.Link, ls.Size, size, rsym, ofs)
|
|
|
|
|
r := &ls.R[len(ls.R)-1]
|
2017-10-24 16:08:46 -04:00
|
|
|
r.Type = objabi.R_DWARFSECREF
|
|
|
|
|
}
|
2020-03-12 14:10:09 -04:00
|
|
|
|
2017-10-24 16:08:46 -04:00
|
|
|
func (c dwCtxt) AddFileRef(s dwarf.Sym, f interface{}) {
|
|
|
|
|
ls := s.(*LSym)
|
|
|
|
|
rsym := f.(*LSym)
|
2020-05-01 19:13:30 -04:00
|
|
|
fidx := c.Link.PosTable.FileIndex(rsym.Name)
|
|
|
|
|
// Note the +1 here -- the value we're writing is going to be an
|
|
|
|
|
// index into the DWARF line table file section, whose entries
|
|
|
|
|
// are numbered starting at 1, not 0.
|
|
|
|
|
ls.WriteInt(c.Link, ls.Size, 4, int64(fidx+1))
|
2016-07-28 13:04:41 -04:00
|
|
|
}
|
|
|
|
|
|
2017-10-06 11:32:28 -04:00
|
|
|
func (c dwCtxt) CurrentOffset(s dwarf.Sym) int64 {
|
|
|
|
|
ls := s.(*LSym)
|
|
|
|
|
return ls.Size
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Here "from" is a symbol corresponding to an inlined or concrete
|
|
|
|
|
// function, "to" is the symbol for the corresponding abstract
|
|
|
|
|
// function, and "dclIdx" is the index of the symbol of interest with
|
|
|
|
|
// respect to the Dcl slice of the original pre-optimization version
|
|
|
|
|
// of the inlined function.
|
|
|
|
|
func (c dwCtxt) RecordDclReference(from dwarf.Sym, to dwarf.Sym, dclIdx int, inlIndex int) {
|
|
|
|
|
ls := from.(*LSym)
|
|
|
|
|
tls := to.(*LSym)
|
|
|
|
|
ridx := len(ls.R) - 1
|
|
|
|
|
c.Link.DwFixups.ReferenceChildDIE(ls, ridx, tls, dclIdx, inlIndex)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (c dwCtxt) RecordChildDieOffsets(s dwarf.Sym, vars []*dwarf.Var, offsets []int32) {
|
|
|
|
|
ls := s.(*LSym)
|
|
|
|
|
c.Link.DwFixups.RegisterChildDIEOffsets(ls, vars, offsets)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (c dwCtxt) Logf(format string, args ...interface{}) {
|
|
|
|
|
c.Link.Logf(format, args...)
|
|
|
|
|
}
|
|
|
|
|
|
2018-09-28 16:44:30 +02:00
|
|
|
func isDwarf64(ctxt *Link) bool {
|
|
|
|
|
return ctxt.Headtype == objabi.Haix
|
|
|
|
|
}
|
|
|
|
|
|
2019-08-29 16:35:50 -04:00
|
|
|
func (ctxt *Link) dwarfSym(s *LSym) (dwarfInfoSym, dwarfLocSym, dwarfRangesSym, dwarfAbsFnSym, dwarfDebugLines *LSym) {
|
2017-04-18 12:53:25 -07:00
|
|
|
if s.Type != objabi.STEXT {
|
2017-04-13 05:57:59 -07:00
|
|
|
ctxt.Diag("dwarfSym of non-TEXT %v", s)
|
|
|
|
|
}
|
[dev.debug] cmd/compile: better DWARF with optimizations on
Debuggers use DWARF information to find local variables on the
stack and in registers. Prior to this CL, the DWARF information for
functions claimed that all variables were on the stack at all times.
That's incorrect when optimizations are enabled, and results in
debuggers showing data that is out of date or complete gibberish.
After this CL, the compiler is capable of representing variable
locations more accurately, and attempts to do so. Due to limitations of
the SSA backend, it's not possible to be completely correct.
There are a number of problems in the current design. One of the easier
to understand is that variable names currently must be attached to an
SSA value, but not all assignments in the source code actually result
in machine code. For example:
type myint int
var a int
b := myint(int)
and
b := (*uint64)(unsafe.Pointer(a))
don't generate machine code because the underlying representation is the
same, so the correct value of b will not be set when the user would
expect.
Generating the more precise debug information is behind a flag,
dwarflocationlists. Because of the issues described above, setting the
flag may not make the debugging experience much better, and may actually
make it worse in cases where the variable actually is on the stack and
the more complicated analysis doesn't realize it.
A number of changes are included:
- Add a new pseudo-instruction, RegKill, which indicates that the value
in the register has been clobbered.
- Adjust regalloc to emit RegKills in the right places. Significantly,
this means that phis are mixed with StoreReg and RegKills after
regalloc.
- Track variable decomposition in ssa.LocalSlots.
- After the SSA backend is done, analyze the result and build location
lists for each LocalSlot.
- After assembly is done, update the location lists with the assembled
PC offsets, recompose variables, and build DWARF location lists. Emit the
list as a new linker symbol, one per function.
- In the linker, aggregate the location lists into a .debug_loc section.
TODO:
- currently disabled for non-X86/AMD64 because there are no data tables.
go build -toolexec 'toolstash -cmp' -a std succeeds.
With -dwarflocationlists false:
before: f02812195637909ff675782c0b46836a8ff01976
after: 06f61e8112a42ac34fb80e0c818b3cdb84a5e7ec
benchstat -geomean /tmp/220352263 /tmp/621364410
completed 15 of 15, estimated time remaining 0s (eta 3:52PM)
name old time/op new time/op delta
Template 199ms ± 3% 198ms ± 2% ~ (p=0.400 n=15+14)
Unicode 96.6ms ± 5% 96.4ms ± 5% ~ (p=0.838 n=15+15)
GoTypes 653ms ± 2% 647ms ± 2% ~ (p=0.102 n=15+14)
Flate 133ms ± 6% 129ms ± 3% -2.62% (p=0.041 n=15+15)
GoParser 164ms ± 5% 159ms ± 3% -3.05% (p=0.000 n=15+15)
Reflect 428ms ± 4% 422ms ± 3% ~ (p=0.156 n=15+13)
Tar 123ms ±10% 124ms ± 8% ~ (p=0.461 n=15+15)
XML 228ms ± 3% 224ms ± 3% -1.57% (p=0.045 n=15+15)
[Geo mean] 206ms 377ms +82.86%
name old user-time/op new user-time/op delta
Template 292ms ±10% 301ms ±12% ~ (p=0.189 n=15+15)
Unicode 166ms ±37% 158ms ±14% ~ (p=0.418 n=15+14)
GoTypes 962ms ± 6% 963ms ± 7% ~ (p=0.976 n=15+15)
Flate 207ms ±19% 200ms ±14% ~ (p=0.345 n=14+15)
GoParser 246ms ±22% 240ms ±15% ~ (p=0.587 n=15+15)
Reflect 611ms ±13% 587ms ±14% ~ (p=0.085 n=15+13)
Tar 211ms ±12% 217ms ±14% ~ (p=0.355 n=14+15)
XML 335ms ±15% 320ms ±18% ~ (p=0.169 n=15+15)
[Geo mean] 317ms 583ms +83.72%
name old alloc/op new alloc/op delta
Template 40.2MB ± 0% 40.2MB ± 0% -0.15% (p=0.000 n=14+15)
Unicode 29.2MB ± 0% 29.3MB ± 0% ~ (p=0.624 n=15+15)
GoTypes 114MB ± 0% 114MB ± 0% -0.15% (p=0.000 n=15+14)
Flate 25.7MB ± 0% 25.6MB ± 0% -0.18% (p=0.000 n=13+15)
GoParser 32.2MB ± 0% 32.2MB ± 0% -0.14% (p=0.003 n=15+15)
Reflect 77.8MB ± 0% 77.9MB ± 0% ~ (p=0.061 n=15+15)
Tar 27.1MB ± 0% 27.0MB ± 0% -0.11% (p=0.029 n=15+15)
XML 42.7MB ± 0% 42.5MB ± 0% -0.29% (p=0.000 n=15+15)
[Geo mean] 42.1MB 75.0MB +78.05%
name old allocs/op new allocs/op delta
Template 402k ± 1% 398k ± 0% -0.91% (p=0.000 n=15+15)
Unicode 344k ± 1% 344k ± 0% ~ (p=0.715 n=15+14)
GoTypes 1.18M ± 0% 1.17M ± 0% -0.91% (p=0.000 n=15+14)
Flate 243k ± 0% 240k ± 1% -1.05% (p=0.000 n=13+15)
GoParser 327k ± 1% 324k ± 1% -0.96% (p=0.000 n=15+15)
Reflect 984k ± 1% 982k ± 0% ~ (p=0.050 n=15+15)
Tar 261k ± 1% 259k ± 1% -0.77% (p=0.000 n=15+15)
XML 411k ± 0% 404k ± 1% -1.55% (p=0.000 n=15+15)
[Geo mean] 439k 755k +72.01%
name old text-bytes new text-bytes delta
HelloSize 694kB ± 0% 694kB ± 0% -0.00% (p=0.000 n=15+15)
name old data-bytes new data-bytes delta
HelloSize 5.55kB ± 0% 5.55kB ± 0% ~ (all equal)
name old bss-bytes new bss-bytes delta
HelloSize 133kB ± 0% 133kB ± 0% ~ (all equal)
name old exe-bytes new exe-bytes delta
HelloSize 1.04MB ± 0% 1.04MB ± 0% ~ (all equal)
Change-Id: I991fc553ef175db46bb23b2128317bbd48de70d8
Reviewed-on: https://go-review.googlesource.com/41770
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
2017-07-21 18:30:19 -04:00
|
|
|
if s.Func.dwarfInfoSym == nil {
|
2020-05-01 19:13:30 -04:00
|
|
|
s.Func.dwarfInfoSym = &LSym{
|
|
|
|
|
Type: objabi.SDWARFINFO,
|
|
|
|
|
}
|
|
|
|
|
if ctxt.Flag_locationlists {
|
|
|
|
|
s.Func.dwarfLocSym = &LSym{
|
|
|
|
|
Type: objabi.SDWARFLOC,
|
2020-03-20 16:05:24 -04:00
|
|
|
}
|
2020-05-01 19:13:30 -04:00
|
|
|
}
|
|
|
|
|
s.Func.dwarfRangesSym = &LSym{
|
|
|
|
|
Type: objabi.SDWARFRANGE,
|
|
|
|
|
}
|
|
|
|
|
s.Func.dwarfDebugLinesSym = &LSym{
|
|
|
|
|
Type: objabi.SDWARFLINES,
|
[dev.debug] cmd/compile: better DWARF with optimizations on
Debuggers use DWARF information to find local variables on the
stack and in registers. Prior to this CL, the DWARF information for
functions claimed that all variables were on the stack at all times.
That's incorrect when optimizations are enabled, and results in
debuggers showing data that is out of date or complete gibberish.
After this CL, the compiler is capable of representing variable
locations more accurately, and attempts to do so. Due to limitations of
the SSA backend, it's not possible to be completely correct.
There are a number of problems in the current design. One of the easier
to understand is that variable names currently must be attached to an
SSA value, but not all assignments in the source code actually result
in machine code. For example:
type myint int
var a int
b := myint(int)
and
b := (*uint64)(unsafe.Pointer(a))
don't generate machine code because the underlying representation is the
same, so the correct value of b will not be set when the user would
expect.
Generating the more precise debug information is behind a flag,
dwarflocationlists. Because of the issues described above, setting the
flag may not make the debugging experience much better, and may actually
make it worse in cases where the variable actually is on the stack and
the more complicated analysis doesn't realize it.
A number of changes are included:
- Add a new pseudo-instruction, RegKill, which indicates that the value
in the register has been clobbered.
- Adjust regalloc to emit RegKills in the right places. Significantly,
this means that phis are mixed with StoreReg and RegKills after
regalloc.
- Track variable decomposition in ssa.LocalSlots.
- After the SSA backend is done, analyze the result and build location
lists for each LocalSlot.
- After assembly is done, update the location lists with the assembled
PC offsets, recompose variables, and build DWARF location lists. Emit the
list as a new linker symbol, one per function.
- In the linker, aggregate the location lists into a .debug_loc section.
TODO:
- currently disabled for non-X86/AMD64 because there are no data tables.
go build -toolexec 'toolstash -cmp' -a std succeeds.
With -dwarflocationlists false:
before: f02812195637909ff675782c0b46836a8ff01976
after: 06f61e8112a42ac34fb80e0c818b3cdb84a5e7ec
benchstat -geomean /tmp/220352263 /tmp/621364410
completed 15 of 15, estimated time remaining 0s (eta 3:52PM)
name old time/op new time/op delta
Template 199ms ± 3% 198ms ± 2% ~ (p=0.400 n=15+14)
Unicode 96.6ms ± 5% 96.4ms ± 5% ~ (p=0.838 n=15+15)
GoTypes 653ms ± 2% 647ms ± 2% ~ (p=0.102 n=15+14)
Flate 133ms ± 6% 129ms ± 3% -2.62% (p=0.041 n=15+15)
GoParser 164ms ± 5% 159ms ± 3% -3.05% (p=0.000 n=15+15)
Reflect 428ms ± 4% 422ms ± 3% ~ (p=0.156 n=15+13)
Tar 123ms ±10% 124ms ± 8% ~ (p=0.461 n=15+15)
XML 228ms ± 3% 224ms ± 3% -1.57% (p=0.045 n=15+15)
[Geo mean] 206ms 377ms +82.86%
name old user-time/op new user-time/op delta
Template 292ms ±10% 301ms ±12% ~ (p=0.189 n=15+15)
Unicode 166ms ±37% 158ms ±14% ~ (p=0.418 n=15+14)
GoTypes 962ms ± 6% 963ms ± 7% ~ (p=0.976 n=15+15)
Flate 207ms ±19% 200ms ±14% ~ (p=0.345 n=14+15)
GoParser 246ms ±22% 240ms ±15% ~ (p=0.587 n=15+15)
Reflect 611ms ±13% 587ms ±14% ~ (p=0.085 n=15+13)
Tar 211ms ±12% 217ms ±14% ~ (p=0.355 n=14+15)
XML 335ms ±15% 320ms ±18% ~ (p=0.169 n=15+15)
[Geo mean] 317ms 583ms +83.72%
name old alloc/op new alloc/op delta
Template 40.2MB ± 0% 40.2MB ± 0% -0.15% (p=0.000 n=14+15)
Unicode 29.2MB ± 0% 29.3MB ± 0% ~ (p=0.624 n=15+15)
GoTypes 114MB ± 0% 114MB ± 0% -0.15% (p=0.000 n=15+14)
Flate 25.7MB ± 0% 25.6MB ± 0% -0.18% (p=0.000 n=13+15)
GoParser 32.2MB ± 0% 32.2MB ± 0% -0.14% (p=0.003 n=15+15)
Reflect 77.8MB ± 0% 77.9MB ± 0% ~ (p=0.061 n=15+15)
Tar 27.1MB ± 0% 27.0MB ± 0% -0.11% (p=0.029 n=15+15)
XML 42.7MB ± 0% 42.5MB ± 0% -0.29% (p=0.000 n=15+15)
[Geo mean] 42.1MB 75.0MB +78.05%
name old allocs/op new allocs/op delta
Template 402k ± 1% 398k ± 0% -0.91% (p=0.000 n=15+15)
Unicode 344k ± 1% 344k ± 0% ~ (p=0.715 n=15+14)
GoTypes 1.18M ± 0% 1.17M ± 0% -0.91% (p=0.000 n=15+14)
Flate 243k ± 0% 240k ± 1% -1.05% (p=0.000 n=13+15)
GoParser 327k ± 1% 324k ± 1% -0.96% (p=0.000 n=15+15)
Reflect 984k ± 1% 982k ± 0% ~ (p=0.050 n=15+15)
Tar 261k ± 1% 259k ± 1% -0.77% (p=0.000 n=15+15)
XML 411k ± 0% 404k ± 1% -1.55% (p=0.000 n=15+15)
[Geo mean] 439k 755k +72.01%
name old text-bytes new text-bytes delta
HelloSize 694kB ± 0% 694kB ± 0% -0.00% (p=0.000 n=15+15)
name old data-bytes new data-bytes delta
HelloSize 5.55kB ± 0% 5.55kB ± 0% ~ (all equal)
name old bss-bytes new bss-bytes delta
HelloSize 133kB ± 0% 133kB ± 0% ~ (all equal)
name old exe-bytes new exe-bytes delta
HelloSize 1.04MB ± 0% 1.04MB ± 0% ~ (all equal)
Change-Id: I991fc553ef175db46bb23b2128317bbd48de70d8
Reviewed-on: https://go-review.googlesource.com/41770
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
2017-07-21 18:30:19 -04:00
|
|
|
}
|
2017-10-06 11:32:28 -04:00
|
|
|
if s.WasInlined() {
|
|
|
|
|
s.Func.dwarfAbsFnSym = ctxt.DwFixups.AbsFuncDwarfSym(s)
|
|
|
|
|
}
|
2017-04-13 08:00:09 -07:00
|
|
|
}
|
2019-08-29 16:35:50 -04:00
|
|
|
return s.Func.dwarfInfoSym, s.Func.dwarfLocSym, s.Func.dwarfRangesSym, s.Func.dwarfAbsFnSym, s.Func.dwarfDebugLinesSym
|
2017-04-13 05:57:59 -07:00
|
|
|
}
|
|
|
|
|
|
2020-02-19 16:16:17 -05:00
|
|
|
func (s *LSym) Length(dwarfContext interface{}) int64 {
|
2017-05-02 16:46:01 +02:00
|
|
|
return s.Size
|
|
|
|
|
}
|
|
|
|
|
|
2017-10-24 16:08:46 -04:00
|
|
|
// fileSymbol returns a symbol corresponding to the source file of the
|
|
|
|
|
// first instruction (prog) of the specified function. This will
|
|
|
|
|
// presumably be the file in which the function is defined.
|
|
|
|
|
func (ctxt *Link) fileSymbol(fn *LSym) *LSym {
|
|
|
|
|
p := fn.Func.Text
|
|
|
|
|
if p != nil {
|
|
|
|
|
f, _ := linkgetlineFromPos(ctxt, p.Pos)
|
|
|
|
|
fsym := ctxt.Lookup(f)
|
|
|
|
|
return fsym
|
|
|
|
|
}
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
2017-10-06 11:32:28 -04:00
|
|
|
// populateDWARF fills in the DWARF Debugging Information Entries for
|
|
|
|
|
// TEXT symbol 's'. The various DWARF symbols must already have been
|
|
|
|
|
// initialized in InitTextSym.
|
|
|
|
|
func (ctxt *Link) populateDWARF(curfn interface{}, s *LSym, myimportpath string) {
|
2019-08-29 16:35:50 -04:00
|
|
|
info, loc, ranges, absfunc, lines := ctxt.dwarfSym(s)
|
[dev.debug] cmd/compile: better DWARF with optimizations on
Debuggers use DWARF information to find local variables on the
stack and in registers. Prior to this CL, the DWARF information for
functions claimed that all variables were on the stack at all times.
That's incorrect when optimizations are enabled, and results in
debuggers showing data that is out of date or complete gibberish.
After this CL, the compiler is capable of representing variable
locations more accurately, and attempts to do so. Due to limitations of
the SSA backend, it's not possible to be completely correct.
There are a number of problems in the current design. One of the easier
to understand is that variable names currently must be attached to an
SSA value, but not all assignments in the source code actually result
in machine code. For example:
type myint int
var a int
b := myint(int)
and
b := (*uint64)(unsafe.Pointer(a))
don't generate machine code because the underlying representation is the
same, so the correct value of b will not be set when the user would
expect.
Generating the more precise debug information is behind a flag,
dwarflocationlists. Because of the issues described above, setting the
flag may not make the debugging experience much better, and may actually
make it worse in cases where the variable actually is on the stack and
the more complicated analysis doesn't realize it.
A number of changes are included:
- Add a new pseudo-instruction, RegKill, which indicates that the value
in the register has been clobbered.
- Adjust regalloc to emit RegKills in the right places. Significantly,
this means that phis are mixed with StoreReg and RegKills after
regalloc.
- Track variable decomposition in ssa.LocalSlots.
- After the SSA backend is done, analyze the result and build location
lists for each LocalSlot.
- After assembly is done, update the location lists with the assembled
PC offsets, recompose variables, and build DWARF location lists. Emit the
list as a new linker symbol, one per function.
- In the linker, aggregate the location lists into a .debug_loc section.
TODO:
- currently disabled for non-X86/AMD64 because there are no data tables.
go build -toolexec 'toolstash -cmp' -a std succeeds.
With -dwarflocationlists false:
before: f02812195637909ff675782c0b46836a8ff01976
after: 06f61e8112a42ac34fb80e0c818b3cdb84a5e7ec
benchstat -geomean /tmp/220352263 /tmp/621364410
completed 15 of 15, estimated time remaining 0s (eta 3:52PM)
name old time/op new time/op delta
Template 199ms ± 3% 198ms ± 2% ~ (p=0.400 n=15+14)
Unicode 96.6ms ± 5% 96.4ms ± 5% ~ (p=0.838 n=15+15)
GoTypes 653ms ± 2% 647ms ± 2% ~ (p=0.102 n=15+14)
Flate 133ms ± 6% 129ms ± 3% -2.62% (p=0.041 n=15+15)
GoParser 164ms ± 5% 159ms ± 3% -3.05% (p=0.000 n=15+15)
Reflect 428ms ± 4% 422ms ± 3% ~ (p=0.156 n=15+13)
Tar 123ms ±10% 124ms ± 8% ~ (p=0.461 n=15+15)
XML 228ms ± 3% 224ms ± 3% -1.57% (p=0.045 n=15+15)
[Geo mean] 206ms 377ms +82.86%
name old user-time/op new user-time/op delta
Template 292ms ±10% 301ms ±12% ~ (p=0.189 n=15+15)
Unicode 166ms ±37% 158ms ±14% ~ (p=0.418 n=15+14)
GoTypes 962ms ± 6% 963ms ± 7% ~ (p=0.976 n=15+15)
Flate 207ms ±19% 200ms ±14% ~ (p=0.345 n=14+15)
GoParser 246ms ±22% 240ms ±15% ~ (p=0.587 n=15+15)
Reflect 611ms ±13% 587ms ±14% ~ (p=0.085 n=15+13)
Tar 211ms ±12% 217ms ±14% ~ (p=0.355 n=14+15)
XML 335ms ±15% 320ms ±18% ~ (p=0.169 n=15+15)
[Geo mean] 317ms 583ms +83.72%
name old alloc/op new alloc/op delta
Template 40.2MB ± 0% 40.2MB ± 0% -0.15% (p=0.000 n=14+15)
Unicode 29.2MB ± 0% 29.3MB ± 0% ~ (p=0.624 n=15+15)
GoTypes 114MB ± 0% 114MB ± 0% -0.15% (p=0.000 n=15+14)
Flate 25.7MB ± 0% 25.6MB ± 0% -0.18% (p=0.000 n=13+15)
GoParser 32.2MB ± 0% 32.2MB ± 0% -0.14% (p=0.003 n=15+15)
Reflect 77.8MB ± 0% 77.9MB ± 0% ~ (p=0.061 n=15+15)
Tar 27.1MB ± 0% 27.0MB ± 0% -0.11% (p=0.029 n=15+15)
XML 42.7MB ± 0% 42.5MB ± 0% -0.29% (p=0.000 n=15+15)
[Geo mean] 42.1MB 75.0MB +78.05%
name old allocs/op new allocs/op delta
Template 402k ± 1% 398k ± 0% -0.91% (p=0.000 n=15+15)
Unicode 344k ± 1% 344k ± 0% ~ (p=0.715 n=15+14)
GoTypes 1.18M ± 0% 1.17M ± 0% -0.91% (p=0.000 n=15+14)
Flate 243k ± 0% 240k ± 1% -1.05% (p=0.000 n=13+15)
GoParser 327k ± 1% 324k ± 1% -0.96% (p=0.000 n=15+15)
Reflect 984k ± 1% 982k ± 0% ~ (p=0.050 n=15+15)
Tar 261k ± 1% 259k ± 1% -0.77% (p=0.000 n=15+15)
XML 411k ± 0% 404k ± 1% -1.55% (p=0.000 n=15+15)
[Geo mean] 439k 755k +72.01%
name old text-bytes new text-bytes delta
HelloSize 694kB ± 0% 694kB ± 0% -0.00% (p=0.000 n=15+15)
name old data-bytes new data-bytes delta
HelloSize 5.55kB ± 0% 5.55kB ± 0% ~ (all equal)
name old bss-bytes new bss-bytes delta
HelloSize 133kB ± 0% 133kB ± 0% ~ (all equal)
name old exe-bytes new exe-bytes delta
HelloSize 1.04MB ± 0% 1.04MB ± 0% ~ (all equal)
Change-Id: I991fc553ef175db46bb23b2128317bbd48de70d8
Reviewed-on: https://go-review.googlesource.com/41770
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
2017-07-21 18:30:19 -04:00
|
|
|
if info.Size != 0 {
|
2017-04-13 05:57:59 -07:00
|
|
|
ctxt.Diag("makeFuncDebugEntry double process %v", s)
|
2017-03-06 07:32:37 -08:00
|
|
|
}
|
2017-05-02 16:46:01 +02:00
|
|
|
var scopes []dwarf.Scope
|
2017-10-06 11:32:28 -04:00
|
|
|
var inlcalls dwarf.InlCalls
|
2017-03-06 07:32:37 -08:00
|
|
|
if ctxt.DebugInfo != nil {
|
2019-09-26 08:38:33 -04:00
|
|
|
scopes, inlcalls = ctxt.DebugInfo(s, info, curfn)
|
2017-10-06 11:32:28 -04:00
|
|
|
}
|
|
|
|
|
var err error
|
|
|
|
|
dwctxt := dwCtxt{ctxt}
|
|
|
|
|
filesym := ctxt.fileSymbol(s)
|
|
|
|
|
fnstate := &dwarf.FnState{
|
2019-04-02 17:26:49 -04:00
|
|
|
Name: s.Name,
|
|
|
|
|
Importpath: myimportpath,
|
|
|
|
|
Info: info,
|
|
|
|
|
Filesym: filesym,
|
|
|
|
|
Loc: loc,
|
|
|
|
|
Ranges: ranges,
|
|
|
|
|
Absfn: absfunc,
|
|
|
|
|
StartPC: s,
|
|
|
|
|
Size: s.Size,
|
|
|
|
|
External: !s.Static(),
|
|
|
|
|
Scopes: scopes,
|
|
|
|
|
InlCalls: inlcalls,
|
|
|
|
|
UseBASEntries: ctxt.UseBASEntries,
|
2017-10-06 11:32:28 -04:00
|
|
|
}
|
|
|
|
|
if absfunc != nil {
|
|
|
|
|
err = dwarf.PutAbstractFunc(dwctxt, fnstate)
|
|
|
|
|
if err != nil {
|
|
|
|
|
ctxt.Diag("emitting DWARF for %s failed: %v", s.Name, err)
|
|
|
|
|
}
|
|
|
|
|
err = dwarf.PutConcreteFunc(dwctxt, fnstate)
|
|
|
|
|
} else {
|
|
|
|
|
err = dwarf.PutDefaultFunc(dwctxt, fnstate)
|
2017-05-02 16:46:01 +02:00
|
|
|
}
|
|
|
|
|
if err != nil {
|
|
|
|
|
ctxt.Diag("emitting DWARF for %s failed: %v", s.Name, err)
|
2016-07-28 13:04:41 -04:00
|
|
|
}
|
2019-07-31 10:33:11 -04:00
|
|
|
// Fill in the debug lines symbol.
|
|
|
|
|
ctxt.generateDebugLinesSymbol(s, lines)
|
2016-07-28 13:04:41 -04:00
|
|
|
}
|
2017-09-03 11:59:18 +02:00
|
|
|
|
|
|
|
|
// DwarfIntConst creates a link symbol for an integer constant with the
|
|
|
|
|
// given name, type and value.
|
|
|
|
|
func (ctxt *Link) DwarfIntConst(myimportpath, name, typename string, val int64) {
|
|
|
|
|
if myimportpath == "" {
|
|
|
|
|
return
|
|
|
|
|
}
|
|
|
|
|
s := ctxt.LookupInit(dwarf.ConstInfoPrefix+myimportpath, func(s *LSym) {
|
|
|
|
|
s.Type = objabi.SDWARFINFO
|
|
|
|
|
ctxt.Data = append(ctxt.Data, s)
|
|
|
|
|
})
|
|
|
|
|
dwarf.PutIntConst(dwCtxt{ctxt}, s, ctxt.Lookup(dwarf.InfoPrefix+typename), myimportpath+"."+name, val)
|
|
|
|
|
}
|
2017-10-06 11:32:28 -04:00
|
|
|
|
|
|
|
|
func (ctxt *Link) DwarfAbstractFunc(curfn interface{}, s *LSym, myimportpath string) {
|
|
|
|
|
absfn := ctxt.DwFixups.AbsFuncDwarfSym(s)
|
|
|
|
|
if absfn.Size != 0 {
|
|
|
|
|
ctxt.Diag("internal error: DwarfAbstractFunc double process %v", s)
|
|
|
|
|
}
|
|
|
|
|
if s.Func == nil {
|
|
|
|
|
s.Func = new(FuncInfo)
|
|
|
|
|
}
|
2019-09-26 08:38:33 -04:00
|
|
|
scopes, _ := ctxt.DebugInfo(s, absfn, curfn)
|
2017-10-06 11:32:28 -04:00
|
|
|
dwctxt := dwCtxt{ctxt}
|
|
|
|
|
filesym := ctxt.fileSymbol(s)
|
|
|
|
|
fnstate := dwarf.FnState{
|
2019-04-02 17:26:49 -04:00
|
|
|
Name: s.Name,
|
|
|
|
|
Importpath: myimportpath,
|
|
|
|
|
Info: absfn,
|
|
|
|
|
Filesym: filesym,
|
|
|
|
|
Absfn: absfn,
|
|
|
|
|
External: !s.Static(),
|
|
|
|
|
Scopes: scopes,
|
|
|
|
|
UseBASEntries: ctxt.UseBASEntries,
|
2017-10-06 11:32:28 -04:00
|
|
|
}
|
|
|
|
|
if err := dwarf.PutAbstractFunc(dwctxt, &fnstate); err != nil {
|
|
|
|
|
ctxt.Diag("emitting DWARF for %s failed: %v", s.Name, err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-09-08 19:36:13 +03:00
|
|
|
// This table is designed to aid in the creation of references between
|
2017-10-06 11:32:28 -04:00
|
|
|
// DWARF subprogram DIEs.
|
|
|
|
|
//
|
|
|
|
|
// In most cases when one DWARF DIE has to refer to another DWARF DIE,
|
|
|
|
|
// the target of the reference has an LSym, which makes it easy to use
|
|
|
|
|
// the existing relocation mechanism. For DWARF inlined routine DIEs,
|
|
|
|
|
// however, the subprogram DIE has to refer to a child
|
|
|
|
|
// parameter/variable DIE of the abstract subprogram. This child DIE
|
|
|
|
|
// doesn't have an LSym, and also of interest is the fact that when
|
|
|
|
|
// DWARF generation is happening for inlined function F within caller
|
|
|
|
|
// G, it's possible that DWARF generation hasn't happened yet for F,
|
|
|
|
|
// so there is no way to know the offset of a child DIE within F's
|
|
|
|
|
// abstract function. Making matters more complex, each inlined
|
|
|
|
|
// instance of F may refer to a subset of the original F's variables
|
|
|
|
|
// (depending on what happens with optimization, some vars may be
|
|
|
|
|
// eliminated).
|
|
|
|
|
//
|
|
|
|
|
// The fixup table below helps overcome this hurdle. At the point
|
|
|
|
|
// where a parameter/variable reference is made (via a call to
|
|
|
|
|
// "ReferenceChildDIE"), a fixup record is generate that records
|
|
|
|
|
// the relocation that is targeting that child variable. At a later
|
|
|
|
|
// point when the abstract function DIE is emitted, there will be
|
|
|
|
|
// a call to "RegisterChildDIEOffsets", at which point the offsets
|
|
|
|
|
// needed to apply fixups are captured. Finally, once the parallel
|
|
|
|
|
// portion of the compilation is done, fixups can actually be applied
|
|
|
|
|
// during the "Finalize" method (this can't be done during the
|
|
|
|
|
// parallel portion of the compile due to the possibility of data
|
|
|
|
|
// races).
|
|
|
|
|
//
|
|
|
|
|
// This table is also used to record the "precursor" function node for
|
|
|
|
|
// each function that is the target of an inline -- child DIE references
|
|
|
|
|
// have to be made with respect to the original pre-optimization
|
|
|
|
|
// version of the function (to allow for the fact that each inlined
|
|
|
|
|
// body may be optimized differently).
|
|
|
|
|
type DwarfFixupTable struct {
|
|
|
|
|
ctxt *Link
|
|
|
|
|
mu sync.Mutex
|
|
|
|
|
symtab map[*LSym]int // maps abstract fn LSYM to index in svec
|
|
|
|
|
svec []symFixups
|
|
|
|
|
precursor map[*LSym]fnState // maps fn Lsym to precursor Node, absfn sym
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
type symFixups struct {
|
|
|
|
|
fixups []relFixup
|
|
|
|
|
doffsets []declOffset
|
|
|
|
|
inlIndex int32
|
|
|
|
|
defseen bool
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
type declOffset struct {
|
|
|
|
|
// Index of variable within DCL list of pre-optimization function
|
|
|
|
|
dclIdx int32
|
|
|
|
|
// Offset of var's child DIE with respect to containing subprogram DIE
|
|
|
|
|
offset int32
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
type relFixup struct {
|
|
|
|
|
refsym *LSym
|
|
|
|
|
relidx int32
|
|
|
|
|
dclidx int32
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
type fnState struct {
|
|
|
|
|
// precursor function (really *gc.Node)
|
|
|
|
|
precursor interface{}
|
|
|
|
|
// abstract function symbol
|
|
|
|
|
absfn *LSym
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func NewDwarfFixupTable(ctxt *Link) *DwarfFixupTable {
|
|
|
|
|
return &DwarfFixupTable{
|
|
|
|
|
ctxt: ctxt,
|
|
|
|
|
symtab: make(map[*LSym]int),
|
|
|
|
|
precursor: make(map[*LSym]fnState),
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (ft *DwarfFixupTable) GetPrecursorFunc(s *LSym) interface{} {
|
|
|
|
|
if fnstate, found := ft.precursor[s]; found {
|
|
|
|
|
return fnstate.precursor
|
|
|
|
|
}
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (ft *DwarfFixupTable) SetPrecursorFunc(s *LSym, fn interface{}) {
|
|
|
|
|
if _, found := ft.precursor[s]; found {
|
|
|
|
|
ft.ctxt.Diag("internal error: DwarfFixupTable.SetPrecursorFunc double call on %v", s)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// initialize abstract function symbol now. This is done here so
|
|
|
|
|
// as to avoid data races later on during the parallel portion of
|
|
|
|
|
// the back end.
|
|
|
|
|
absfn := ft.ctxt.LookupDerived(s, dwarf.InfoPrefix+s.Name+dwarf.AbstractFuncSuffix)
|
|
|
|
|
absfn.Set(AttrDuplicateOK, true)
|
|
|
|
|
absfn.Type = objabi.SDWARFINFO
|
|
|
|
|
ft.ctxt.Data = append(ft.ctxt.Data, absfn)
|
|
|
|
|
|
cmd/compile: delay inlinable method compilation for -c=1
When the concurrent back end is not enabled, it is possible to have a
scenario where: we compile a specific inlinable non-pointer-receiver
method T.M, then at some point later on in the compilation we visit a
type that triggers generation of a pointer-receiver wrapper (*T).M,
which then results in an inline of T.M into (*T).M. This introduces
subtle differences in the DWARF as compared with when the concurrent
back end is enabled (in the concurrent case, by the time we run the
SSA back end on T.M is is marked as being inlined, whereas in the
non-current case it is not marked inlined).
As a fix, at the point where we would normally compile a given
function in the xtop list right away, if the function is a method AND
is inlinable AND hasn't been inlined, then delay its compilation until
compileFunctions (so as to make sure that when we do compile it, all
possible inlining has been complete). In addition, make sure that
the abstract function symbol for the inlined function gets recorded
correctly.
Fixes #38068.
Change-Id: I57410ab5658bd4ee5b4b80750518e9b20fd6ba52
Reviewed-on: https://go-review.googlesource.com/c/go/+/234178
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
2020-05-15 12:19:07 -04:00
|
|
|
// In the case of "late" inlining (inlines that happen during
|
|
|
|
|
// wrapper generation as opposed to the main inlining phase) it's
|
|
|
|
|
// possible that we didn't cache the abstract function sym for the
|
|
|
|
|
// text symbol -- do so now if needed. See issue 38068.
|
|
|
|
|
if s.Func != nil && s.Func.dwarfAbsFnSym == nil {
|
|
|
|
|
s.Func.dwarfAbsFnSym = absfn
|
|
|
|
|
}
|
|
|
|
|
|
2017-10-06 11:32:28 -04:00
|
|
|
ft.precursor[s] = fnState{precursor: fn, absfn: absfn}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Make a note of a child DIE reference: relocation 'ridx' within symbol 's'
|
|
|
|
|
// is targeting child 'c' of DIE with symbol 'tgt'.
|
|
|
|
|
func (ft *DwarfFixupTable) ReferenceChildDIE(s *LSym, ridx int, tgt *LSym, dclidx int, inlIndex int) {
|
|
|
|
|
// Protect against concurrent access if multiple backend workers
|
|
|
|
|
ft.mu.Lock()
|
|
|
|
|
defer ft.mu.Unlock()
|
|
|
|
|
|
|
|
|
|
// Create entry for symbol if not already present.
|
|
|
|
|
idx, found := ft.symtab[tgt]
|
|
|
|
|
if !found {
|
|
|
|
|
ft.svec = append(ft.svec, symFixups{inlIndex: int32(inlIndex)})
|
|
|
|
|
idx = len(ft.svec) - 1
|
|
|
|
|
ft.symtab[tgt] = idx
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Do we have child DIE offsets available? If so, then apply them,
|
|
|
|
|
// otherwise create a fixup record.
|
|
|
|
|
sf := &ft.svec[idx]
|
|
|
|
|
if len(sf.doffsets) > 0 {
|
|
|
|
|
found := false
|
|
|
|
|
for _, do := range sf.doffsets {
|
|
|
|
|
if do.dclIdx == int32(dclidx) {
|
|
|
|
|
off := do.offset
|
|
|
|
|
s.R[ridx].Add += int64(off)
|
|
|
|
|
found = true
|
|
|
|
|
break
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if !found {
|
|
|
|
|
ft.ctxt.Diag("internal error: DwarfFixupTable.ReferenceChildDIE unable to locate child DIE offset for dclIdx=%d src=%v tgt=%v", dclidx, s, tgt)
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
sf.fixups = append(sf.fixups, relFixup{s, int32(ridx), int32(dclidx)})
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Called once DWARF generation is complete for a given abstract function,
|
|
|
|
|
// whose children might have been referenced via a call above. Stores
|
|
|
|
|
// the offsets for any child DIEs (vars, params) so that they can be
|
|
|
|
|
// consumed later in on DwarfFixupTable.Finalize, which applies any
|
|
|
|
|
// outstanding fixups.
|
|
|
|
|
func (ft *DwarfFixupTable) RegisterChildDIEOffsets(s *LSym, vars []*dwarf.Var, coffsets []int32) {
|
|
|
|
|
// Length of these two slices should agree
|
|
|
|
|
if len(vars) != len(coffsets) {
|
|
|
|
|
ft.ctxt.Diag("internal error: RegisterChildDIEOffsets vars/offsets length mismatch")
|
|
|
|
|
return
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Generate the slice of declOffset's based in vars/coffsets
|
|
|
|
|
doffsets := make([]declOffset, len(coffsets))
|
2018-04-05 12:11:32 +01:00
|
|
|
for i := range coffsets {
|
2017-10-06 11:32:28 -04:00
|
|
|
doffsets[i].dclIdx = vars[i].ChildIndex
|
|
|
|
|
doffsets[i].offset = coffsets[i]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ft.mu.Lock()
|
|
|
|
|
defer ft.mu.Unlock()
|
|
|
|
|
|
|
|
|
|
// Store offsets for this symbol.
|
|
|
|
|
idx, found := ft.symtab[s]
|
|
|
|
|
if !found {
|
|
|
|
|
sf := symFixups{inlIndex: -1, defseen: true, doffsets: doffsets}
|
|
|
|
|
ft.svec = append(ft.svec, sf)
|
|
|
|
|
ft.symtab[s] = len(ft.svec) - 1
|
|
|
|
|
} else {
|
|
|
|
|
sf := &ft.svec[idx]
|
|
|
|
|
sf.doffsets = doffsets
|
|
|
|
|
sf.defseen = true
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (ft *DwarfFixupTable) processFixups(slot int, s *LSym) {
|
|
|
|
|
sf := &ft.svec[slot]
|
|
|
|
|
for _, f := range sf.fixups {
|
|
|
|
|
dfound := false
|
2018-04-05 12:11:32 +01:00
|
|
|
for _, doffset := range sf.doffsets {
|
|
|
|
|
if doffset.dclIdx == f.dclidx {
|
|
|
|
|
f.refsym.R[f.relidx].Add += int64(doffset.offset)
|
2017-10-06 11:32:28 -04:00
|
|
|
dfound = true
|
|
|
|
|
break
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if !dfound {
|
|
|
|
|
ft.ctxt.Diag("internal error: DwarfFixupTable has orphaned fixup on %v targeting %v relidx=%d dclidx=%d", f.refsym, s, f.relidx, f.dclidx)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// return the LSym corresponding to the 'abstract subprogram' DWARF
|
|
|
|
|
// info entry for a function.
|
|
|
|
|
func (ft *DwarfFixupTable) AbsFuncDwarfSym(fnsym *LSym) *LSym {
|
|
|
|
|
// Protect against concurrent access if multiple backend workers
|
|
|
|
|
ft.mu.Lock()
|
|
|
|
|
defer ft.mu.Unlock()
|
|
|
|
|
|
|
|
|
|
if fnstate, found := ft.precursor[fnsym]; found {
|
|
|
|
|
return fnstate.absfn
|
|
|
|
|
}
|
|
|
|
|
ft.ctxt.Diag("internal error: AbsFuncDwarfSym requested for %v, not seen during inlining", fnsym)
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Called after all functions have been compiled; the main job of this
|
|
|
|
|
// function is to identify cases where there are outstanding fixups.
|
|
|
|
|
// This scenario crops up when we have references to variables of an
|
|
|
|
|
// inlined routine, but that routine is defined in some other package.
|
|
|
|
|
// This helper walks through and locate these fixups, then invokes a
|
|
|
|
|
// helper to create an abstract subprogram DIE for each one.
|
|
|
|
|
func (ft *DwarfFixupTable) Finalize(myimportpath string, trace bool) {
|
|
|
|
|
if trace {
|
|
|
|
|
ft.ctxt.Logf("DwarfFixupTable.Finalize invoked for %s\n", myimportpath)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Collect up the keys from the precursor map, then sort the
|
|
|
|
|
// resulting list (don't want to rely on map ordering here).
|
|
|
|
|
fns := make([]*LSym, len(ft.precursor))
|
|
|
|
|
idx := 0
|
2018-04-05 12:11:32 +01:00
|
|
|
for fn := range ft.precursor {
|
2017-10-06 11:32:28 -04:00
|
|
|
fns[idx] = fn
|
|
|
|
|
idx++
|
|
|
|
|
}
|
2019-09-26 08:38:33 -04:00
|
|
|
sort.Sort(BySymName(fns))
|
2017-10-06 11:32:28 -04:00
|
|
|
|
|
|
|
|
// Should not be called during parallel portion of compilation.
|
|
|
|
|
if ft.ctxt.InParallel {
|
|
|
|
|
ft.ctxt.Diag("internal error: DwarfFixupTable.Finalize call during parallel backend")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Generate any missing abstract functions.
|
2018-04-05 12:11:32 +01:00
|
|
|
for _, s := range fns {
|
2017-10-06 11:32:28 -04:00
|
|
|
absfn := ft.AbsFuncDwarfSym(s)
|
|
|
|
|
slot, found := ft.symtab[absfn]
|
|
|
|
|
if !found || !ft.svec[slot].defseen {
|
|
|
|
|
ft.ctxt.GenAbstractFunc(s)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Apply fixups.
|
2018-04-05 12:11:32 +01:00
|
|
|
for _, s := range fns {
|
2017-10-06 11:32:28 -04:00
|
|
|
absfn := ft.AbsFuncDwarfSym(s)
|
|
|
|
|
slot, found := ft.symtab[absfn]
|
|
|
|
|
if !found {
|
|
|
|
|
ft.ctxt.Diag("internal error: DwarfFixupTable.Finalize orphan abstract function for %v", s)
|
|
|
|
|
} else {
|
|
|
|
|
ft.processFixups(slot, s)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-09-26 08:38:33 -04:00
|
|
|
type BySymName []*LSym
|
2017-10-06 11:32:28 -04:00
|
|
|
|
2019-09-26 08:38:33 -04:00
|
|
|
func (s BySymName) Len() int { return len(s) }
|
|
|
|
|
func (s BySymName) Less(i, j int) bool { return s[i].Name < s[j].Name }
|
|
|
|
|
func (s BySymName) Swap(i, j int) { s[i], s[j] = s[j], s[i] }
|