testing: introduce testing/internal/testdeps for holding testmain dependencies
Currently, we don't have package testing to import package regexp directly,
because then regexp can't have internal tests (or at least they become more
difficult to write), for fear of an import cycle. The solution we've been using
is for the generated test main package (pseudo-import path "testmain", package main)
to import regexp and pass in a matchString function for use by testing when
implementing the -run flags. This lets testing use regexp but without depending
on regexp and creating unnecessary cycles.
We want to add a few dependencies to runtime/pprof, notably regexp
but also compress/gzip, without causing those packages to have to work
hard to write internal tests.
Restructure the (dare I say it) dependency injection of regexp.MatchString
to be more general, and use it for the runtime/pprof functionality in addition
to the regexp functionality. The new package testing/internal/testdeps is
the root for the testing dependencies handled this way.
Code using testing.MainStart will have to change from passing in a matchString
implementation to passing in testdeps.TestDeps{}. Users of 'go test' don't do this,
but other build systems that have recreated 'go test' (for example, Blaze/Bazel)
may need to be updated. The new testdeps setup should make future updates
unnecessary, but even so we keep the comment about MainStart not being
subject to Go 1 compatibility.
Change-Id: Iec821d2afde10c79f95f3b23de5e71b219f47b92
Reviewed-on: https://go-review.googlesource.com/32455
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-10-31 19:27:26 -04:00
|
|
|
// Copyright 2016 The Go Authors. All rights reserved.
|
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
|
|
// Package testdeps provides access to dependencies needed by test execution.
|
|
|
|
|
//
|
|
|
|
|
// This package is imported by the generated main package, which passes
|
|
|
|
|
// TestDeps into testing.Main. This allows tests to use packages at run time
|
|
|
|
|
// without making those packages direct dependencies of package testing.
|
|
|
|
|
// Direct dependencies of package testing are harder to write tests for.
|
|
|
|
|
package testdeps
|
|
|
|
|
|
|
|
|
|
import (
|
2017-12-04 13:57:48 -05:00
|
|
|
"bufio"
|
|
|
|
|
"internal/testlog"
|
testing: introduce testing/internal/testdeps for holding testmain dependencies
Currently, we don't have package testing to import package regexp directly,
because then regexp can't have internal tests (or at least they become more
difficult to write), for fear of an import cycle. The solution we've been using
is for the generated test main package (pseudo-import path "testmain", package main)
to import regexp and pass in a matchString function for use by testing when
implementing the -run flags. This lets testing use regexp but without depending
on regexp and creating unnecessary cycles.
We want to add a few dependencies to runtime/pprof, notably regexp
but also compress/gzip, without causing those packages to have to work
hard to write internal tests.
Restructure the (dare I say it) dependency injection of regexp.MatchString
to be more general, and use it for the runtime/pprof functionality in addition
to the regexp functionality. The new package testing/internal/testdeps is
the root for the testing dependencies handled this way.
Code using testing.MainStart will have to change from passing in a matchString
implementation to passing in testdeps.TestDeps{}. Users of 'go test' don't do this,
but other build systems that have recreated 'go test' (for example, Blaze/Bazel)
may need to be updated. The new testdeps setup should make future updates
unnecessary, but even so we keep the comment about MainStart not being
subject to Go 1 compatibility.
Change-Id: Iec821d2afde10c79f95f3b23de5e71b219f47b92
Reviewed-on: https://go-review.googlesource.com/32455
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-10-31 19:27:26 -04:00
|
|
|
"io"
|
|
|
|
|
"regexp"
|
|
|
|
|
"runtime/pprof"
|
2017-12-04 13:57:48 -05:00
|
|
|
"strings"
|
|
|
|
|
"sync"
|
testing: introduce testing/internal/testdeps for holding testmain dependencies
Currently, we don't have package testing to import package regexp directly,
because then regexp can't have internal tests (or at least they become more
difficult to write), for fear of an import cycle. The solution we've been using
is for the generated test main package (pseudo-import path "testmain", package main)
to import regexp and pass in a matchString function for use by testing when
implementing the -run flags. This lets testing use regexp but without depending
on regexp and creating unnecessary cycles.
We want to add a few dependencies to runtime/pprof, notably regexp
but also compress/gzip, without causing those packages to have to work
hard to write internal tests.
Restructure the (dare I say it) dependency injection of regexp.MatchString
to be more general, and use it for the runtime/pprof functionality in addition
to the regexp functionality. The new package testing/internal/testdeps is
the root for the testing dependencies handled this way.
Code using testing.MainStart will have to change from passing in a matchString
implementation to passing in testdeps.TestDeps{}. Users of 'go test' don't do this,
but other build systems that have recreated 'go test' (for example, Blaze/Bazel)
may need to be updated. The new testdeps setup should make future updates
unnecessary, but even so we keep the comment about MainStart not being
subject to Go 1 compatibility.
Change-Id: Iec821d2afde10c79f95f3b23de5e71b219f47b92
Reviewed-on: https://go-review.googlesource.com/32455
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2016-10-31 19:27:26 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
// TestDeps is an implementation of the testing.testDeps interface,
|
|
|
|
|
// suitable for passing to testing.MainStart.
|
|
|
|
|
type TestDeps struct{}
|
|
|
|
|
|
|
|
|
|
var matchPat string
|
|
|
|
|
var matchRe *regexp.Regexp
|
|
|
|
|
|
|
|
|
|
func (TestDeps) MatchString(pat, str string) (result bool, err error) {
|
|
|
|
|
if matchRe == nil || matchPat != pat {
|
|
|
|
|
matchPat = pat
|
|
|
|
|
matchRe, err = regexp.Compile(matchPat)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return matchRe.MatchString(str), nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (TestDeps) StartCPUProfile(w io.Writer) error {
|
|
|
|
|
return pprof.StartCPUProfile(w)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (TestDeps) StopCPUProfile() {
|
|
|
|
|
pprof.StopCPUProfile()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (TestDeps) WriteHeapProfile(w io.Writer) error {
|
|
|
|
|
return pprof.WriteHeapProfile(w)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (TestDeps) WriteProfileTo(name string, w io.Writer, debug int) error {
|
|
|
|
|
return pprof.Lookup(name).WriteTo(w, debug)
|
|
|
|
|
}
|
2017-02-06 11:59:01 -05:00
|
|
|
|
|
|
|
|
// ImportPath is the import path of the testing binary, set by the generated main function.
|
|
|
|
|
var ImportPath string
|
|
|
|
|
|
|
|
|
|
func (TestDeps) ImportPath() string {
|
|
|
|
|
return ImportPath
|
|
|
|
|
}
|
2017-12-04 13:57:48 -05:00
|
|
|
|
|
|
|
|
// testLog implements testlog.Interface, logging actions by package os.
|
|
|
|
|
type testLog struct {
|
2017-12-13 21:46:03 -05:00
|
|
|
mu sync.Mutex
|
|
|
|
|
w *bufio.Writer
|
|
|
|
|
set bool
|
2017-12-04 13:57:48 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (l *testLog) Getenv(key string) {
|
|
|
|
|
l.add("getenv", key)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (l *testLog) Open(name string) {
|
|
|
|
|
l.add("open", name)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (l *testLog) Stat(name string) {
|
|
|
|
|
l.add("stat", name)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (l *testLog) Chdir(name string) {
|
|
|
|
|
l.add("chdir", name)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// add adds the (op, name) pair to the test log.
|
|
|
|
|
func (l *testLog) add(op, name string) {
|
|
|
|
|
if strings.Contains(name, "\n") || name == "" {
|
|
|
|
|
return
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
l.mu.Lock()
|
|
|
|
|
defer l.mu.Unlock()
|
|
|
|
|
if l.w == nil {
|
|
|
|
|
return
|
|
|
|
|
}
|
|
|
|
|
l.w.WriteString(op)
|
|
|
|
|
l.w.WriteByte(' ')
|
|
|
|
|
l.w.WriteString(name)
|
|
|
|
|
l.w.WriteByte('\n')
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
var log testLog
|
2017-12-13 21:46:03 -05:00
|
|
|
var didSetLogger bool
|
2017-12-04 13:57:48 -05:00
|
|
|
|
|
|
|
|
func (TestDeps) StartTestLog(w io.Writer) {
|
|
|
|
|
log.mu.Lock()
|
|
|
|
|
log.w = bufio.NewWriter(w)
|
2017-12-13 21:46:03 -05:00
|
|
|
if !log.set {
|
|
|
|
|
// Tests that define TestMain and then run m.Run multiple times
|
|
|
|
|
// will call StartTestLog/StopTestLog multiple times.
|
|
|
|
|
// Checking log.set avoids calling testlog.SetLogger multiple times
|
|
|
|
|
// (which will panic) and also avoids writing the header multiple times.
|
|
|
|
|
log.set = true
|
|
|
|
|
testlog.SetLogger(&log)
|
|
|
|
|
log.w.WriteString("# test log\n") // known to cmd/go/internal/test/test.go
|
|
|
|
|
}
|
2017-12-04 13:57:48 -05:00
|
|
|
log.mu.Unlock()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (TestDeps) StopTestLog() error {
|
|
|
|
|
log.mu.Lock()
|
|
|
|
|
defer log.mu.Unlock()
|
|
|
|
|
err := log.w.Flush()
|
|
|
|
|
log.w = nil
|
|
|
|
|
return err
|
|
|
|
|
}
|