2020-04-20 12:13:42 -04:00
|
|
|
// Copyright 2019 The Go Authors. All rights reserved.
|
cmd/link: prune unused methods
Today the linker keeps all methods of reachable types. This is
necessary if a program uses reflect.Value.Call. But while use of
reflection is widespread in Go for encoders and decoders, using
it to call a method is rare.
This CL looks for the use of reflect.Value.Call in a program, and
if it is absent, adopts a (reasonably conservative) method pruning
strategy as part of dead code elimination. Any method that is
directly called is kept, and any method that matches a used
interface's method signature is kept.
Whether or not a method body is kept is determined by the relocation
from its receiver's *rtype to its *rtype. A small change in the
compiler marks these relocations as R_METHOD so they can be easily
collected and manipulated by the linker.
As a bonus, this technique removes the text segment of methods that
have been inlined. Looking at the output of building cmd/objdump with
-ldflags=-v=2 shows that inlined methods like
runtime.(*traceAllocBlockPtr).ptr are removed from the program.
Relatively little work is necessary to do this. Linking two
examples, jujud and cmd/objdump show no more than +2% link time.
Binaries that do not use reflect.Call.Value drop 4 - 20% in size:
addr2line: -793KB (18%)
asm: -346KB (8%)
cgo: -490KB (10%)
compile: -564KB (4%)
dist: -736KB (17%)
fix: -404KB (12%)
link: -328KB (7%)
nm: -827KB (19%)
objdump: -712KB (16%)
pack: -327KB (14%)
yacc: -350KB (10%)
Binaries that do use reflect.Call.Value see a modest size decrease
of 2 - 6% thanks to pruning of unexported methods:
api: -151KB (3%)
cover: -222KB (4%)
doc: -106KB (2.5%)
pprof: -314KB (3%)
trace: -357KB (4%)
vet: -187KB (2.7%)
jujud: -4.4MB (5.8%)
cmd/go: -384KB (3.4%)
The trivial Hello example program goes from 2MB to 1.68MB:
package main
import "fmt"
func main() {
fmt.Println("Hello, 世界")
}
Method pruning also helps when building small binaries with
"-ldflags=-s -w". The above program goes from 1.43MB to 1.2MB.
Unfortunately the linker can only tell if reflect.Value.Call has been
statically linked, not if it is dynamically used. And while use is
rare, it is linked into a very common standard library package,
text/template. The result is programs like cmd/go, which don't use
reflect.Value.Call, see limited benefit from this CL. If binary size
is important enough it may be possible to address this in future work.
For #6853.
Change-Id: Iabe90e210e813b08c3f8fd605f841f0458973396
Reviewed-on: https://go-review.googlesource.com/20483
Reviewed-by: Russ Cox <rsc@golang.org>
2016-03-07 23:45:04 -05:00
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
|
|
package ld
|
|
|
|
|
|
|
|
|
|
import (
|
2020-08-02 19:36:28 -04:00
|
|
|
"cmd/internal/goobj"
|
2020-04-20 12:13:42 -04:00
|
|
|
"cmd/internal/objabi"
|
|
|
|
|
"cmd/internal/sys"
|
|
|
|
|
"cmd/link/internal/loader"
|
2017-10-04 17:54:04 -04:00
|
|
|
"cmd/link/internal/sym"
|
2020-04-20 12:13:42 -04:00
|
|
|
"fmt"
|
|
|
|
|
"unicode"
|
cmd/link: prune unused methods
Today the linker keeps all methods of reachable types. This is
necessary if a program uses reflect.Value.Call. But while use of
reflection is widespread in Go for encoders and decoders, using
it to call a method is rare.
This CL looks for the use of reflect.Value.Call in a program, and
if it is absent, adopts a (reasonably conservative) method pruning
strategy as part of dead code elimination. Any method that is
directly called is kept, and any method that matches a used
interface's method signature is kept.
Whether or not a method body is kept is determined by the relocation
from its receiver's *rtype to its *rtype. A small change in the
compiler marks these relocations as R_METHOD so they can be easily
collected and manipulated by the linker.
As a bonus, this technique removes the text segment of methods that
have been inlined. Looking at the output of building cmd/objdump with
-ldflags=-v=2 shows that inlined methods like
runtime.(*traceAllocBlockPtr).ptr are removed from the program.
Relatively little work is necessary to do this. Linking two
examples, jujud and cmd/objdump show no more than +2% link time.
Binaries that do not use reflect.Call.Value drop 4 - 20% in size:
addr2line: -793KB (18%)
asm: -346KB (8%)
cgo: -490KB (10%)
compile: -564KB (4%)
dist: -736KB (17%)
fix: -404KB (12%)
link: -328KB (7%)
nm: -827KB (19%)
objdump: -712KB (16%)
pack: -327KB (14%)
yacc: -350KB (10%)
Binaries that do use reflect.Call.Value see a modest size decrease
of 2 - 6% thanks to pruning of unexported methods:
api: -151KB (3%)
cover: -222KB (4%)
doc: -106KB (2.5%)
pprof: -314KB (3%)
trace: -357KB (4%)
vet: -187KB (2.7%)
jujud: -4.4MB (5.8%)
cmd/go: -384KB (3.4%)
The trivial Hello example program goes from 2MB to 1.68MB:
package main
import "fmt"
func main() {
fmt.Println("Hello, 世界")
}
Method pruning also helps when building small binaries with
"-ldflags=-s -w". The above program goes from 1.43MB to 1.2MB.
Unfortunately the linker can only tell if reflect.Value.Call has been
statically linked, not if it is dynamically used. And while use is
rare, it is linked into a very common standard library package,
text/template. The result is programs like cmd/go, which don't use
reflect.Value.Call, see limited benefit from this CL. If binary size
is important enough it may be possible to address this in future work.
For #6853.
Change-Id: Iabe90e210e813b08c3f8fd605f841f0458973396
Reviewed-on: https://go-review.googlesource.com/20483
Reviewed-by: Russ Cox <rsc@golang.org>
2016-03-07 23:45:04 -05:00
|
|
|
)
|
|
|
|
|
|
2020-04-20 12:13:42 -04:00
|
|
|
var _ = fmt.Print
|
|
|
|
|
|
|
|
|
|
type deadcodePass struct {
|
|
|
|
|
ctxt *Link
|
|
|
|
|
ldr *loader.Loader
|
2020-06-03 19:34:29 -04:00
|
|
|
wq heap // work queue, using min-heap for beter locality
|
2020-04-20 12:13:42 -04:00
|
|
|
|
|
|
|
|
ifaceMethod map[methodsig]bool // methods declared in reached interfaces
|
2020-04-29 17:34:46 -04:00
|
|
|
markableMethods []methodref // methods of reached types
|
2020-04-20 12:13:42 -04:00
|
|
|
reflectSeen bool // whether we have seen a reflect method call
|
2021-02-25 20:01:53 -05:00
|
|
|
dynlink bool
|
2020-06-04 12:01:53 -04:00
|
|
|
|
|
|
|
|
methodsigstmp []methodsig // scratch buffer for decoding method signatures
|
2020-04-20 12:13:42 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (d *deadcodePass) init() {
|
|
|
|
|
d.ldr.InitReachable()
|
|
|
|
|
d.ifaceMethod = make(map[methodsig]bool)
|
2020-04-21 19:54:37 -04:00
|
|
|
if objabi.Fieldtrack_enabled != 0 {
|
2020-04-20 12:13:42 -04:00
|
|
|
d.ldr.Reachparent = make([]loader.Sym, d.ldr.NSym())
|
|
|
|
|
}
|
2021-02-25 20:01:53 -05:00
|
|
|
d.dynlink = d.ctxt.DynlinkingGo()
|
2020-04-20 12:13:42 -04:00
|
|
|
|
|
|
|
|
if d.ctxt.BuildMode == BuildModeShared {
|
|
|
|
|
// Mark all symbols defined in this library as reachable when
|
|
|
|
|
// building a shared library.
|
|
|
|
|
n := d.ldr.NDef()
|
|
|
|
|
for i := 1; i < n; i++ {
|
|
|
|
|
s := loader.Sym(i)
|
|
|
|
|
d.mark(s, 0)
|
|
|
|
|
}
|
|
|
|
|
return
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
var names []string
|
|
|
|
|
|
|
|
|
|
// In a normal binary, start at main.main and the init
|
|
|
|
|
// functions and mark what is reachable from there.
|
|
|
|
|
if d.ctxt.linkShared && (d.ctxt.BuildMode == BuildModeExe || d.ctxt.BuildMode == BuildModePIE) {
|
|
|
|
|
names = append(names, "main.main", "main..inittask")
|
|
|
|
|
} else {
|
|
|
|
|
// The external linker refers main symbol directly.
|
|
|
|
|
if d.ctxt.LinkMode == LinkExternal && (d.ctxt.BuildMode == BuildModeExe || d.ctxt.BuildMode == BuildModePIE) {
|
|
|
|
|
if d.ctxt.HeadType == objabi.Hwindows && d.ctxt.Arch.Family == sys.I386 {
|
|
|
|
|
*flagEntrySymbol = "_main"
|
|
|
|
|
} else {
|
|
|
|
|
*flagEntrySymbol = "main"
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
names = append(names, *flagEntrySymbol)
|
2020-10-12 15:37:21 -04:00
|
|
|
if !d.ctxt.linkShared && d.ctxt.BuildMode != BuildModePlugin {
|
|
|
|
|
// runtime.buildVersion and runtime.modinfo are referenced in .go.buildinfo section
|
|
|
|
|
// (see function buildinfo in data.go). They should normally be reachable from the
|
|
|
|
|
// runtime. Just make it explicit, in case.
|
|
|
|
|
names = append(names, "runtime.buildVersion", "runtime.modinfo")
|
|
|
|
|
}
|
2020-04-20 12:13:42 -04:00
|
|
|
if d.ctxt.BuildMode == BuildModePlugin {
|
|
|
|
|
names = append(names, objabi.PathToPrefix(*flagPluginPath)+"..inittask", objabi.PathToPrefix(*flagPluginPath)+".main", "go.plugin.tabs")
|
|
|
|
|
|
|
|
|
|
// We don't keep the go.plugin.exports symbol,
|
|
|
|
|
// but we do keep the symbols it refers to.
|
|
|
|
|
exportsIdx := d.ldr.Lookup("go.plugin.exports", 0)
|
|
|
|
|
if exportsIdx != 0 {
|
|
|
|
|
relocs := d.ldr.Relocs(exportsIdx)
|
|
|
|
|
for i := 0; i < relocs.Count(); i++ {
|
2020-07-29 13:26:50 -04:00
|
|
|
d.mark(relocs.At(i).Sym(), 0)
|
2020-04-20 12:13:42 -04:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
dynexpMap := d.ctxt.cgo_export_dynamic
|
|
|
|
|
if d.ctxt.LinkMode == LinkExternal {
|
|
|
|
|
dynexpMap = d.ctxt.cgo_export_static
|
|
|
|
|
}
|
|
|
|
|
for exp := range dynexpMap {
|
|
|
|
|
names = append(names, exp)
|
|
|
|
|
}
|
|
|
|
|
|
2021-01-22 11:13:32 -05:00
|
|
|
if d.ctxt.Debugvlog > 1 {
|
|
|
|
|
d.ctxt.Logf("deadcode start names: %v\n", names)
|
|
|
|
|
}
|
|
|
|
|
|
2020-04-20 12:13:42 -04:00
|
|
|
for _, name := range names {
|
|
|
|
|
// Mark symbol as a data/ABI0 symbol.
|
|
|
|
|
d.mark(d.ldr.Lookup(name, 0), 0)
|
|
|
|
|
// Also mark any Go functions (internal ABI).
|
|
|
|
|
d.mark(d.ldr.Lookup(name, sym.SymVerABIInternal), 0)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (d *deadcodePass) flood() {
|
2020-06-04 12:01:53 -04:00
|
|
|
var methods []methodref
|
2020-04-20 12:13:42 -04:00
|
|
|
for !d.wq.empty() {
|
|
|
|
|
symIdx := d.wq.pop()
|
|
|
|
|
|
|
|
|
|
d.reflectSeen = d.reflectSeen || d.ldr.IsReflectMethod(symIdx)
|
|
|
|
|
|
|
|
|
|
isgotype := d.ldr.IsGoType(symIdx)
|
|
|
|
|
relocs := d.ldr.Relocs(symIdx)
|
[dev.link] cmd/compile, cmd/link: remove dead methods if type is not used in interface
Currently, a method of a reachable type is live if it matches a
method of a reachable interface. In fact, we only need to retain
the method if the type is actually converted to an interface. If
the type is never converted to an interface, there is no way to
call the method through an interface method call (but the type
descriptor could still be used, e.g. in calling
runtime.newobject).
A type can be used in an interface in two ways:
- directly converted to interface. (Any interface counts, as it
is possible to convert one interface to another.)
- obtained by reflection from a related type (e.g. obtaining an
interface of T from []T).
For the former, we let the compiler emit a marker on the type
descriptor symbol when it is converted to an interface. In the
linker, we only need to check methods of marked types.
For the latter, when the linker visits a marked type, it needs to
visit all its "child" types as marked (i.e. potentially could be
converted to interface).
This reduces binary size:
cmd/compile 18792016 18706096 (-0.5%)
cmd/go 14120572 13398948 (-5.1%)
Change-Id: I4465c7eeabf575f4dc84017214c610fa05ae31fd
Reviewed-on: https://go-review.googlesource.com/c/go/+/237298
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
2020-06-08 18:38:59 -04:00
|
|
|
var usedInIface bool
|
2020-04-20 12:13:42 -04:00
|
|
|
|
|
|
|
|
if isgotype {
|
2021-02-25 20:01:53 -05:00
|
|
|
if d.dynlink {
|
|
|
|
|
// When dynaamic linking, a type may be passed across DSO
|
|
|
|
|
// boundary and get converted to interface at the other side.
|
|
|
|
|
d.ldr.SetAttrUsedInIface(symIdx, true)
|
|
|
|
|
}
|
[dev.link] cmd/compile, cmd/link: remove dead methods if type is not used in interface
Currently, a method of a reachable type is live if it matches a
method of a reachable interface. In fact, we only need to retain
the method if the type is actually converted to an interface. If
the type is never converted to an interface, there is no way to
call the method through an interface method call (but the type
descriptor could still be used, e.g. in calling
runtime.newobject).
A type can be used in an interface in two ways:
- directly converted to interface. (Any interface counts, as it
is possible to convert one interface to another.)
- obtained by reflection from a related type (e.g. obtaining an
interface of T from []T).
For the former, we let the compiler emit a marker on the type
descriptor symbol when it is converted to an interface. In the
linker, we only need to check methods of marked types.
For the latter, when the linker visits a marked type, it needs to
visit all its "child" types as marked (i.e. potentially could be
converted to interface).
This reduces binary size:
cmd/compile 18792016 18706096 (-0.5%)
cmd/go 14120572 13398948 (-5.1%)
Change-Id: I4465c7eeabf575f4dc84017214c610fa05ae31fd
Reviewed-on: https://go-review.googlesource.com/c/go/+/237298
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
2020-06-08 18:38:59 -04:00
|
|
|
usedInIface = d.ldr.AttrUsedInIface(symIdx)
|
2020-04-20 12:13:42 -04:00
|
|
|
}
|
|
|
|
|
|
2020-06-04 12:01:53 -04:00
|
|
|
methods = methods[:0]
|
2020-04-20 12:13:42 -04:00
|
|
|
for i := 0; i < relocs.Count(); i++ {
|
2020-07-29 13:26:50 -04:00
|
|
|
r := relocs.At(i)
|
2020-04-20 12:13:42 -04:00
|
|
|
t := r.Type()
|
2020-09-21 20:44:53 -04:00
|
|
|
switch t {
|
|
|
|
|
case objabi.R_WEAKADDROFF:
|
2020-04-20 12:13:42 -04:00
|
|
|
continue
|
2020-09-21 20:44:53 -04:00
|
|
|
case objabi.R_METHODOFF:
|
2020-04-20 12:13:42 -04:00
|
|
|
if i+2 >= relocs.Count() {
|
|
|
|
|
panic("expect three consecutive R_METHODOFF relocs")
|
|
|
|
|
}
|
[dev.link] cmd/compile, cmd/link: remove dead methods if type is not used in interface
Currently, a method of a reachable type is live if it matches a
method of a reachable interface. In fact, we only need to retain
the method if the type is actually converted to an interface. If
the type is never converted to an interface, there is no way to
call the method through an interface method call (but the type
descriptor could still be used, e.g. in calling
runtime.newobject).
A type can be used in an interface in two ways:
- directly converted to interface. (Any interface counts, as it
is possible to convert one interface to another.)
- obtained by reflection from a related type (e.g. obtaining an
interface of T from []T).
For the former, we let the compiler emit a marker on the type
descriptor symbol when it is converted to an interface. In the
linker, we only need to check methods of marked types.
For the latter, when the linker visits a marked type, it needs to
visit all its "child" types as marked (i.e. potentially could be
converted to interface).
This reduces binary size:
cmd/compile 18792016 18706096 (-0.5%)
cmd/go 14120572 13398948 (-5.1%)
Change-Id: I4465c7eeabf575f4dc84017214c610fa05ae31fd
Reviewed-on: https://go-review.googlesource.com/c/go/+/237298
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
2020-06-08 18:38:59 -04:00
|
|
|
if usedInIface {
|
|
|
|
|
methods = append(methods, methodref{src: symIdx, r: i})
|
2020-09-17 21:34:52 -04:00
|
|
|
// The method descriptor is itself a type descriptor, and
|
|
|
|
|
// it can be used to reach other types, e.g. by using
|
|
|
|
|
// reflect.Type.Method(i).Type.In(j). We need to traverse
|
|
|
|
|
// its child types with UsedInIface set. (See also the
|
|
|
|
|
// comment below.)
|
|
|
|
|
rs := r.Sym()
|
|
|
|
|
if !d.ldr.AttrUsedInIface(rs) {
|
|
|
|
|
d.ldr.SetAttrUsedInIface(rs, true)
|
|
|
|
|
if d.ldr.AttrReachable(rs) {
|
|
|
|
|
d.ldr.SetAttrReachable(rs, false)
|
|
|
|
|
d.mark(rs, symIdx)
|
|
|
|
|
}
|
|
|
|
|
}
|
[dev.link] cmd/compile, cmd/link: remove dead methods if type is not used in interface
Currently, a method of a reachable type is live if it matches a
method of a reachable interface. In fact, we only need to retain
the method if the type is actually converted to an interface. If
the type is never converted to an interface, there is no way to
call the method through an interface method call (but the type
descriptor could still be used, e.g. in calling
runtime.newobject).
A type can be used in an interface in two ways:
- directly converted to interface. (Any interface counts, as it
is possible to convert one interface to another.)
- obtained by reflection from a related type (e.g. obtaining an
interface of T from []T).
For the former, we let the compiler emit a marker on the type
descriptor symbol when it is converted to an interface. In the
linker, we only need to check methods of marked types.
For the latter, when the linker visits a marked type, it needs to
visit all its "child" types as marked (i.e. potentially could be
converted to interface).
This reduces binary size:
cmd/compile 18792016 18706096 (-0.5%)
cmd/go 14120572 13398948 (-5.1%)
Change-Id: I4465c7eeabf575f4dc84017214c610fa05ae31fd
Reviewed-on: https://go-review.googlesource.com/c/go/+/237298
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
2020-06-08 18:38:59 -04:00
|
|
|
}
|
2020-04-20 12:13:42 -04:00
|
|
|
i += 2
|
|
|
|
|
continue
|
2020-09-21 20:44:53 -04:00
|
|
|
case objabi.R_USETYPE:
|
2020-04-20 12:13:42 -04:00
|
|
|
// type symbol used for DWARF. we need to load the symbol but it may not
|
|
|
|
|
// be otherwise reachable in the program.
|
|
|
|
|
// do nothing for now as we still load all type symbols.
|
|
|
|
|
continue
|
2020-09-21 20:44:53 -04:00
|
|
|
case objabi.R_USEIFACE:
|
2020-09-20 23:29:20 -04:00
|
|
|
// R_USEIFACE is a marker relocation that tells the linker the type is
|
|
|
|
|
// converted to an interface, i.e. should have UsedInIface set. See the
|
|
|
|
|
// comment below for why we need to unset the Reachable bit and re-mark it.
|
|
|
|
|
rs := r.Sym()
|
|
|
|
|
if !d.ldr.AttrUsedInIface(rs) {
|
|
|
|
|
d.ldr.SetAttrUsedInIface(rs, true)
|
|
|
|
|
if d.ldr.AttrReachable(rs) {
|
|
|
|
|
d.ldr.SetAttrReachable(rs, false)
|
|
|
|
|
d.mark(rs, symIdx)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
continue
|
2020-09-21 20:44:53 -04:00
|
|
|
case objabi.R_USEIFACEMETHOD:
|
|
|
|
|
// R_USEIFACEMETHOD is a marker relocation that marks an interface
|
|
|
|
|
// method as used.
|
|
|
|
|
rs := r.Sym()
|
2021-02-01 13:36:50 -05:00
|
|
|
if d.ctxt.linkShared && (d.ldr.SymType(rs) == sym.SDYNIMPORT || d.ldr.SymType(rs) == sym.Sxxx) {
|
|
|
|
|
// Don't decode symbol from shared library (we'll mark all exported methods anyway).
|
|
|
|
|
// We check for both SDYNIMPORT and Sxxx because name-mangled symbols haven't
|
|
|
|
|
// been resolved at this point.
|
|
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
m := d.decodeIfaceMethod(d.ldr, d.ctxt.Arch, rs, r.Add())
|
|
|
|
|
if d.ctxt.Debugvlog > 1 {
|
|
|
|
|
d.ctxt.Logf("reached iface method: %v\n", m)
|
2020-09-21 20:44:53 -04:00
|
|
|
}
|
2021-02-01 13:36:50 -05:00
|
|
|
d.ifaceMethod[m] = true
|
2020-09-21 20:44:53 -04:00
|
|
|
continue
|
2020-09-20 23:29:20 -04:00
|
|
|
}
|
[dev.link] cmd/compile, cmd/link: remove dead methods if type is not used in interface
Currently, a method of a reachable type is live if it matches a
method of a reachable interface. In fact, we only need to retain
the method if the type is actually converted to an interface. If
the type is never converted to an interface, there is no way to
call the method through an interface method call (but the type
descriptor could still be used, e.g. in calling
runtime.newobject).
A type can be used in an interface in two ways:
- directly converted to interface. (Any interface counts, as it
is possible to convert one interface to another.)
- obtained by reflection from a related type (e.g. obtaining an
interface of T from []T).
For the former, we let the compiler emit a marker on the type
descriptor symbol when it is converted to an interface. In the
linker, we only need to check methods of marked types.
For the latter, when the linker visits a marked type, it needs to
visit all its "child" types as marked (i.e. potentially could be
converted to interface).
This reduces binary size:
cmd/compile 18792016 18706096 (-0.5%)
cmd/go 14120572 13398948 (-5.1%)
Change-Id: I4465c7eeabf575f4dc84017214c610fa05ae31fd
Reviewed-on: https://go-review.googlesource.com/c/go/+/237298
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
2020-06-08 18:38:59 -04:00
|
|
|
rs := r.Sym()
|
|
|
|
|
if isgotype && usedInIface && d.ldr.IsGoType(rs) && !d.ldr.AttrUsedInIface(rs) {
|
|
|
|
|
// If a type is converted to an interface, it is possible to obtain an
|
|
|
|
|
// interface with a "child" type of it using reflection (e.g. obtain an
|
|
|
|
|
// interface of T from []chan T). We need to traverse its "child" types
|
|
|
|
|
// with UsedInIface attribute set.
|
|
|
|
|
// When visiting the child type (chan T in the example above), it will
|
|
|
|
|
// have UsedInIface set, so it in turn will mark and (re)visit its children
|
|
|
|
|
// (e.g. T above).
|
|
|
|
|
// We unset the reachable bit here, so if the child type is already visited,
|
|
|
|
|
// it will be visited again.
|
|
|
|
|
// Note that a type symbol can be visited at most twice, one without
|
|
|
|
|
// UsedInIface and one with. So termination is still guaranteed.
|
|
|
|
|
d.ldr.SetAttrUsedInIface(rs, true)
|
|
|
|
|
d.ldr.SetAttrReachable(rs, false)
|
|
|
|
|
}
|
|
|
|
|
d.mark(rs, symIdx)
|
2020-04-20 12:13:42 -04:00
|
|
|
}
|
|
|
|
|
naux := d.ldr.NAux(symIdx)
|
|
|
|
|
for i := 0; i < naux; i++ {
|
2020-07-29 13:26:50 -04:00
|
|
|
a := d.ldr.Aux(symIdx, i)
|
2020-09-18 11:56:43 -04:00
|
|
|
if a.Type() == goobj.AuxGotype {
|
2020-04-30 23:10:35 -04:00
|
|
|
// A symbol being reachable doesn't imply we need its
|
|
|
|
|
// type descriptor. Don't mark it.
|
|
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
d.mark(a.Sym(), symIdx)
|
2020-04-20 12:13:42 -04:00
|
|
|
}
|
|
|
|
|
// Some host object symbols have an outer object, which acts like a
|
|
|
|
|
// "carrier" symbol, or it holds all the symbols for a particular
|
|
|
|
|
// section. We need to mark all "referenced" symbols from that carrier,
|
|
|
|
|
// so we make sure we're pulling in all outer symbols, and their sub
|
|
|
|
|
// symbols. This is not ideal, and these carrier/section symbols could
|
|
|
|
|
// be removed.
|
|
|
|
|
if d.ldr.IsExternal(symIdx) {
|
|
|
|
|
d.mark(d.ldr.OuterSym(symIdx), symIdx)
|
|
|
|
|
d.mark(d.ldr.SubSym(symIdx), symIdx)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if len(methods) != 0 {
|
|
|
|
|
if !isgotype {
|
|
|
|
|
panic("method found on non-type symbol")
|
|
|
|
|
}
|
|
|
|
|
// Decode runtime type information for type methods
|
|
|
|
|
// to help work out which methods can be called
|
|
|
|
|
// dynamically via interfaces.
|
2020-04-29 17:34:46 -04:00
|
|
|
methodsigs := d.decodetypeMethods(d.ldr, d.ctxt.Arch, symIdx, &relocs)
|
2020-04-20 12:13:42 -04:00
|
|
|
if len(methods) != len(methodsigs) {
|
|
|
|
|
panic(fmt.Sprintf("%q has %d method relocations for %d methods", d.ldr.SymName(symIdx), len(methods), len(methodsigs)))
|
|
|
|
|
}
|
|
|
|
|
for i, m := range methodsigs {
|
|
|
|
|
methods[i].m = m
|
2020-06-03 13:28:18 -04:00
|
|
|
if d.ctxt.Debugvlog > 1 {
|
|
|
|
|
d.ctxt.Logf("markable method: %v of sym %v %s\n", m, symIdx, d.ldr.SymName(symIdx))
|
|
|
|
|
}
|
2020-04-20 12:13:42 -04:00
|
|
|
}
|
|
|
|
|
d.markableMethods = append(d.markableMethods, methods...)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (d *deadcodePass) mark(symIdx, parent loader.Sym) {
|
|
|
|
|
if symIdx != 0 && !d.ldr.AttrReachable(symIdx) {
|
|
|
|
|
d.wq.push(symIdx)
|
|
|
|
|
d.ldr.SetAttrReachable(symIdx, true)
|
2020-09-10 22:41:29 -04:00
|
|
|
if objabi.Fieldtrack_enabled != 0 && d.ldr.Reachparent[symIdx] == 0 {
|
2020-04-20 12:13:42 -04:00
|
|
|
d.ldr.Reachparent[symIdx] = parent
|
|
|
|
|
}
|
|
|
|
|
if *flagDumpDep {
|
|
|
|
|
to := d.ldr.SymName(symIdx)
|
|
|
|
|
if to != "" {
|
2020-09-17 21:34:52 -04:00
|
|
|
if d.ldr.AttrUsedInIface(symIdx) {
|
|
|
|
|
to += " <UsedInIface>"
|
|
|
|
|
}
|
2020-04-20 12:13:42 -04:00
|
|
|
from := "_"
|
|
|
|
|
if parent != 0 {
|
|
|
|
|
from = d.ldr.SymName(parent)
|
2020-09-17 21:34:52 -04:00
|
|
|
if d.ldr.AttrUsedInIface(parent) {
|
|
|
|
|
from += " <UsedInIface>"
|
|
|
|
|
}
|
2020-04-20 12:13:42 -04:00
|
|
|
}
|
|
|
|
|
fmt.Printf("%s -> %s\n", from, to)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2020-04-29 17:34:46 -04:00
|
|
|
func (d *deadcodePass) markMethod(m methodref) {
|
2020-04-20 12:13:42 -04:00
|
|
|
relocs := d.ldr.Relocs(m.src)
|
2020-07-29 13:26:50 -04:00
|
|
|
d.mark(relocs.At(m.r).Sym(), m.src)
|
|
|
|
|
d.mark(relocs.At(m.r+1).Sym(), m.src)
|
|
|
|
|
d.mark(relocs.At(m.r+2).Sym(), m.src)
|
2020-04-20 12:13:42 -04:00
|
|
|
}
|
|
|
|
|
|
cmd/link: prune unused methods
Today the linker keeps all methods of reachable types. This is
necessary if a program uses reflect.Value.Call. But while use of
reflection is widespread in Go for encoders and decoders, using
it to call a method is rare.
This CL looks for the use of reflect.Value.Call in a program, and
if it is absent, adopts a (reasonably conservative) method pruning
strategy as part of dead code elimination. Any method that is
directly called is kept, and any method that matches a used
interface's method signature is kept.
Whether or not a method body is kept is determined by the relocation
from its receiver's *rtype to its *rtype. A small change in the
compiler marks these relocations as R_METHOD so they can be easily
collected and manipulated by the linker.
As a bonus, this technique removes the text segment of methods that
have been inlined. Looking at the output of building cmd/objdump with
-ldflags=-v=2 shows that inlined methods like
runtime.(*traceAllocBlockPtr).ptr are removed from the program.
Relatively little work is necessary to do this. Linking two
examples, jujud and cmd/objdump show no more than +2% link time.
Binaries that do not use reflect.Call.Value drop 4 - 20% in size:
addr2line: -793KB (18%)
asm: -346KB (8%)
cgo: -490KB (10%)
compile: -564KB (4%)
dist: -736KB (17%)
fix: -404KB (12%)
link: -328KB (7%)
nm: -827KB (19%)
objdump: -712KB (16%)
pack: -327KB (14%)
yacc: -350KB (10%)
Binaries that do use reflect.Call.Value see a modest size decrease
of 2 - 6% thanks to pruning of unexported methods:
api: -151KB (3%)
cover: -222KB (4%)
doc: -106KB (2.5%)
pprof: -314KB (3%)
trace: -357KB (4%)
vet: -187KB (2.7%)
jujud: -4.4MB (5.8%)
cmd/go: -384KB (3.4%)
The trivial Hello example program goes from 2MB to 1.68MB:
package main
import "fmt"
func main() {
fmt.Println("Hello, 世界")
}
Method pruning also helps when building small binaries with
"-ldflags=-s -w". The above program goes from 1.43MB to 1.2MB.
Unfortunately the linker can only tell if reflect.Value.Call has been
statically linked, not if it is dynamically used. And while use is
rare, it is linked into a very common standard library package,
text/template. The result is programs like cmd/go, which don't use
reflect.Value.Call, see limited benefit from this CL. If binary size
is important enough it may be possible to address this in future work.
For #6853.
Change-Id: Iabe90e210e813b08c3f8fd605f841f0458973396
Reviewed-on: https://go-review.googlesource.com/20483
Reviewed-by: Russ Cox <rsc@golang.org>
2016-03-07 23:45:04 -05:00
|
|
|
// deadcode marks all reachable symbols.
|
|
|
|
|
//
|
|
|
|
|
// The basis of the dead code elimination is a flood fill of symbols,
|
2016-08-21 18:34:24 -04:00
|
|
|
// following their relocations, beginning at *flagEntrySymbol.
|
cmd/link: prune unused methods
Today the linker keeps all methods of reachable types. This is
necessary if a program uses reflect.Value.Call. But while use of
reflection is widespread in Go for encoders and decoders, using
it to call a method is rare.
This CL looks for the use of reflect.Value.Call in a program, and
if it is absent, adopts a (reasonably conservative) method pruning
strategy as part of dead code elimination. Any method that is
directly called is kept, and any method that matches a used
interface's method signature is kept.
Whether or not a method body is kept is determined by the relocation
from its receiver's *rtype to its *rtype. A small change in the
compiler marks these relocations as R_METHOD so they can be easily
collected and manipulated by the linker.
As a bonus, this technique removes the text segment of methods that
have been inlined. Looking at the output of building cmd/objdump with
-ldflags=-v=2 shows that inlined methods like
runtime.(*traceAllocBlockPtr).ptr are removed from the program.
Relatively little work is necessary to do this. Linking two
examples, jujud and cmd/objdump show no more than +2% link time.
Binaries that do not use reflect.Call.Value drop 4 - 20% in size:
addr2line: -793KB (18%)
asm: -346KB (8%)
cgo: -490KB (10%)
compile: -564KB (4%)
dist: -736KB (17%)
fix: -404KB (12%)
link: -328KB (7%)
nm: -827KB (19%)
objdump: -712KB (16%)
pack: -327KB (14%)
yacc: -350KB (10%)
Binaries that do use reflect.Call.Value see a modest size decrease
of 2 - 6% thanks to pruning of unexported methods:
api: -151KB (3%)
cover: -222KB (4%)
doc: -106KB (2.5%)
pprof: -314KB (3%)
trace: -357KB (4%)
vet: -187KB (2.7%)
jujud: -4.4MB (5.8%)
cmd/go: -384KB (3.4%)
The trivial Hello example program goes from 2MB to 1.68MB:
package main
import "fmt"
func main() {
fmt.Println("Hello, 世界")
}
Method pruning also helps when building small binaries with
"-ldflags=-s -w". The above program goes from 1.43MB to 1.2MB.
Unfortunately the linker can only tell if reflect.Value.Call has been
statically linked, not if it is dynamically used. And while use is
rare, it is linked into a very common standard library package,
text/template. The result is programs like cmd/go, which don't use
reflect.Value.Call, see limited benefit from this CL. If binary size
is important enough it may be possible to address this in future work.
For #6853.
Change-Id: Iabe90e210e813b08c3f8fd605f841f0458973396
Reviewed-on: https://go-review.googlesource.com/20483
Reviewed-by: Russ Cox <rsc@golang.org>
2016-03-07 23:45:04 -05:00
|
|
|
//
|
|
|
|
|
// This flood fill is wrapped in logic for pruning unused methods.
|
|
|
|
|
// All methods are mentioned by relocations on their receiver's *rtype.
|
cmd/compile, etc: store method tables as offsets
This CL introduces the typeOff type and a lookup method of the same
name that can turn a typeOff offset into an *rtype.
In a typical Go binary (built with buildmode=exe, pie, c-archive, or
c-shared), there is one moduledata and all typeOff values are offsets
relative to firstmoduledata.types. This makes computing the pointer
cheap in typical programs.
With buildmode=shared (and one day, buildmode=plugin) there are
multiple modules whose relative offset is determined at runtime.
We identify a type in the general case by the pair of the original
*rtype that references it and its typeOff value. We determine
the module from the original pointer, and then use the typeOff from
there to compute the final *rtype.
To ensure there is only one *rtype representing each type, the
runtime initializes a typemap for each module, using any identical
type from an earlier module when resolving that offset. This means
that types computed from an offset match the type mapped by the
pointer dynamic relocations.
A series of followup CLs will replace other *rtype values with typeOff
(and name/*string with nameOff).
For types created at runtime by reflect, type offsets are treated as
global IDs and reference into a reflect offset map kept by the runtime.
darwin/amd64:
cmd/go: -57KB (0.6%)
jujud: -557KB (0.8%)
linux/amd64 PIE:
cmd/go: -361KB (3.0%)
jujud: -3.5MB (4.2%)
For #6853.
Change-Id: Icf096fd884a0a0cb9f280f46f7a26c70a9006c96
Reviewed-on: https://go-review.googlesource.com/21285
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-03-28 10:32:27 -04:00
|
|
|
// These relocations are specially defined as R_METHODOFF by the compiler
|
cmd/link: prune unused methods
Today the linker keeps all methods of reachable types. This is
necessary if a program uses reflect.Value.Call. But while use of
reflection is widespread in Go for encoders and decoders, using
it to call a method is rare.
This CL looks for the use of reflect.Value.Call in a program, and
if it is absent, adopts a (reasonably conservative) method pruning
strategy as part of dead code elimination. Any method that is
directly called is kept, and any method that matches a used
interface's method signature is kept.
Whether or not a method body is kept is determined by the relocation
from its receiver's *rtype to its *rtype. A small change in the
compiler marks these relocations as R_METHOD so they can be easily
collected and manipulated by the linker.
As a bonus, this technique removes the text segment of methods that
have been inlined. Looking at the output of building cmd/objdump with
-ldflags=-v=2 shows that inlined methods like
runtime.(*traceAllocBlockPtr).ptr are removed from the program.
Relatively little work is necessary to do this. Linking two
examples, jujud and cmd/objdump show no more than +2% link time.
Binaries that do not use reflect.Call.Value drop 4 - 20% in size:
addr2line: -793KB (18%)
asm: -346KB (8%)
cgo: -490KB (10%)
compile: -564KB (4%)
dist: -736KB (17%)
fix: -404KB (12%)
link: -328KB (7%)
nm: -827KB (19%)
objdump: -712KB (16%)
pack: -327KB (14%)
yacc: -350KB (10%)
Binaries that do use reflect.Call.Value see a modest size decrease
of 2 - 6% thanks to pruning of unexported methods:
api: -151KB (3%)
cover: -222KB (4%)
doc: -106KB (2.5%)
pprof: -314KB (3%)
trace: -357KB (4%)
vet: -187KB (2.7%)
jujud: -4.4MB (5.8%)
cmd/go: -384KB (3.4%)
The trivial Hello example program goes from 2MB to 1.68MB:
package main
import "fmt"
func main() {
fmt.Println("Hello, 世界")
}
Method pruning also helps when building small binaries with
"-ldflags=-s -w". The above program goes from 1.43MB to 1.2MB.
Unfortunately the linker can only tell if reflect.Value.Call has been
statically linked, not if it is dynamically used. And while use is
rare, it is linked into a very common standard library package,
text/template. The result is programs like cmd/go, which don't use
reflect.Value.Call, see limited benefit from this CL. If binary size
is important enough it may be possible to address this in future work.
For #6853.
Change-Id: Iabe90e210e813b08c3f8fd605f841f0458973396
Reviewed-on: https://go-review.googlesource.com/20483
Reviewed-by: Russ Cox <rsc@golang.org>
2016-03-07 23:45:04 -05:00
|
|
|
// so we can detect and manipulated them here.
|
|
|
|
|
//
|
|
|
|
|
// There are three ways a method of a reachable type can be invoked:
|
|
|
|
|
//
|
|
|
|
|
// 1. direct call
|
|
|
|
|
// 2. through a reachable interface type
|
2020-04-18 23:08:36 -04:00
|
|
|
// 3. reflect.Value.Method (or MethodByName), or reflect.Type.Method
|
|
|
|
|
// (or MethodByName)
|
cmd/link: prune unused methods
Today the linker keeps all methods of reachable types. This is
necessary if a program uses reflect.Value.Call. But while use of
reflection is widespread in Go for encoders and decoders, using
it to call a method is rare.
This CL looks for the use of reflect.Value.Call in a program, and
if it is absent, adopts a (reasonably conservative) method pruning
strategy as part of dead code elimination. Any method that is
directly called is kept, and any method that matches a used
interface's method signature is kept.
Whether or not a method body is kept is determined by the relocation
from its receiver's *rtype to its *rtype. A small change in the
compiler marks these relocations as R_METHOD so they can be easily
collected and manipulated by the linker.
As a bonus, this technique removes the text segment of methods that
have been inlined. Looking at the output of building cmd/objdump with
-ldflags=-v=2 shows that inlined methods like
runtime.(*traceAllocBlockPtr).ptr are removed from the program.
Relatively little work is necessary to do this. Linking two
examples, jujud and cmd/objdump show no more than +2% link time.
Binaries that do not use reflect.Call.Value drop 4 - 20% in size:
addr2line: -793KB (18%)
asm: -346KB (8%)
cgo: -490KB (10%)
compile: -564KB (4%)
dist: -736KB (17%)
fix: -404KB (12%)
link: -328KB (7%)
nm: -827KB (19%)
objdump: -712KB (16%)
pack: -327KB (14%)
yacc: -350KB (10%)
Binaries that do use reflect.Call.Value see a modest size decrease
of 2 - 6% thanks to pruning of unexported methods:
api: -151KB (3%)
cover: -222KB (4%)
doc: -106KB (2.5%)
pprof: -314KB (3%)
trace: -357KB (4%)
vet: -187KB (2.7%)
jujud: -4.4MB (5.8%)
cmd/go: -384KB (3.4%)
The trivial Hello example program goes from 2MB to 1.68MB:
package main
import "fmt"
func main() {
fmt.Println("Hello, 世界")
}
Method pruning also helps when building small binaries with
"-ldflags=-s -w". The above program goes from 1.43MB to 1.2MB.
Unfortunately the linker can only tell if reflect.Value.Call has been
statically linked, not if it is dynamically used. And while use is
rare, it is linked into a very common standard library package,
text/template. The result is programs like cmd/go, which don't use
reflect.Value.Call, see limited benefit from this CL. If binary size
is important enough it may be possible to address this in future work.
For #6853.
Change-Id: Iabe90e210e813b08c3f8fd605f841f0458973396
Reviewed-on: https://go-review.googlesource.com/20483
Reviewed-by: Russ Cox <rsc@golang.org>
2016-03-07 23:45:04 -05:00
|
|
|
//
|
|
|
|
|
// The first case is handled by the flood fill, a directly called method
|
|
|
|
|
// is marked as reachable.
|
|
|
|
|
//
|
|
|
|
|
// The second case is handled by decomposing all reachable interface
|
|
|
|
|
// types into method signatures. Each encountered method is compared
|
|
|
|
|
// against the interface method signatures, if it matches it is marked
|
|
|
|
|
// as reachable. This is extremely conservative, but easy and correct.
|
|
|
|
|
//
|
2016-03-10 19:32:04 -05:00
|
|
|
// The third case is handled by looking to see if any of:
|
2020-04-18 23:08:36 -04:00
|
|
|
// - reflect.Value.Method or MethodByName is reachable
|
2020-04-18 01:13:39 -04:00
|
|
|
// - reflect.Type.Method or MethodByName is called (through the
|
|
|
|
|
// REFLECTMETHOD attribute marked by the compiler).
|
2016-03-10 19:32:04 -05:00
|
|
|
// If any of these happen, all bets are off and all exported methods
|
|
|
|
|
// of reachable types are marked reachable.
|
cmd/link: prune unused methods
Today the linker keeps all methods of reachable types. This is
necessary if a program uses reflect.Value.Call. But while use of
reflection is widespread in Go for encoders and decoders, using
it to call a method is rare.
This CL looks for the use of reflect.Value.Call in a program, and
if it is absent, adopts a (reasonably conservative) method pruning
strategy as part of dead code elimination. Any method that is
directly called is kept, and any method that matches a used
interface's method signature is kept.
Whether or not a method body is kept is determined by the relocation
from its receiver's *rtype to its *rtype. A small change in the
compiler marks these relocations as R_METHOD so they can be easily
collected and manipulated by the linker.
As a bonus, this technique removes the text segment of methods that
have been inlined. Looking at the output of building cmd/objdump with
-ldflags=-v=2 shows that inlined methods like
runtime.(*traceAllocBlockPtr).ptr are removed from the program.
Relatively little work is necessary to do this. Linking two
examples, jujud and cmd/objdump show no more than +2% link time.
Binaries that do not use reflect.Call.Value drop 4 - 20% in size:
addr2line: -793KB (18%)
asm: -346KB (8%)
cgo: -490KB (10%)
compile: -564KB (4%)
dist: -736KB (17%)
fix: -404KB (12%)
link: -328KB (7%)
nm: -827KB (19%)
objdump: -712KB (16%)
pack: -327KB (14%)
yacc: -350KB (10%)
Binaries that do use reflect.Call.Value see a modest size decrease
of 2 - 6% thanks to pruning of unexported methods:
api: -151KB (3%)
cover: -222KB (4%)
doc: -106KB (2.5%)
pprof: -314KB (3%)
trace: -357KB (4%)
vet: -187KB (2.7%)
jujud: -4.4MB (5.8%)
cmd/go: -384KB (3.4%)
The trivial Hello example program goes from 2MB to 1.68MB:
package main
import "fmt"
func main() {
fmt.Println("Hello, 世界")
}
Method pruning also helps when building small binaries with
"-ldflags=-s -w". The above program goes from 1.43MB to 1.2MB.
Unfortunately the linker can only tell if reflect.Value.Call has been
statically linked, not if it is dynamically used. And while use is
rare, it is linked into a very common standard library package,
text/template. The result is programs like cmd/go, which don't use
reflect.Value.Call, see limited benefit from this CL. If binary size
is important enough it may be possible to address this in future work.
For #6853.
Change-Id: Iabe90e210e813b08c3f8fd605f841f0458973396
Reviewed-on: https://go-review.googlesource.com/20483
Reviewed-by: Russ Cox <rsc@golang.org>
2016-03-07 23:45:04 -05:00
|
|
|
//
|
|
|
|
|
// Any unreached text symbols are removed from ctxt.Textp.
|
|
|
|
|
func deadcode(ctxt *Link) {
|
2020-04-20 12:13:42 -04:00
|
|
|
ldr := ctxt.loader
|
|
|
|
|
d := deadcodePass{ctxt: ctxt, ldr: ldr}
|
|
|
|
|
d.init()
|
|
|
|
|
d.flood()
|
|
|
|
|
|
|
|
|
|
methSym := ldr.Lookup("reflect.Value.Method", sym.SymVerABIInternal)
|
|
|
|
|
methByNameSym := ldr.Lookup("reflect.Value.MethodByName", sym.SymVerABIInternal)
|
|
|
|
|
|
|
|
|
|
if ctxt.DynlinkingGo() {
|
|
|
|
|
// Exported methods may satisfy interfaces we don't know
|
|
|
|
|
// about yet when dynamically linking.
|
|
|
|
|
d.reflectSeen = true
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for {
|
|
|
|
|
// Methods might be called via reflection. Give up on
|
|
|
|
|
// static analysis, mark all exported methods of
|
|
|
|
|
// all reachable types as reachable.
|
|
|
|
|
d.reflectSeen = d.reflectSeen || (methSym != 0 && ldr.AttrReachable(methSym)) || (methByNameSym != 0 && ldr.AttrReachable(methByNameSym))
|
|
|
|
|
|
|
|
|
|
// Mark all methods that could satisfy a discovered
|
|
|
|
|
// interface as reachable. We recheck old marked interfaces
|
|
|
|
|
// as new types (with new methods) may have been discovered
|
|
|
|
|
// in the last pass.
|
|
|
|
|
rem := d.markableMethods[:0]
|
|
|
|
|
for _, m := range d.markableMethods {
|
|
|
|
|
if (d.reflectSeen && m.isExported()) || d.ifaceMethod[m.m] {
|
|
|
|
|
d.markMethod(m)
|
|
|
|
|
} else {
|
|
|
|
|
rem = append(rem, m)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
d.markableMethods = rem
|
|
|
|
|
|
|
|
|
|
if d.wq.empty() {
|
|
|
|
|
// No new work was discovered. Done.
|
|
|
|
|
break
|
|
|
|
|
}
|
|
|
|
|
d.flood()
|
|
|
|
|
}
|
2019-09-28 22:42:35 -04:00
|
|
|
}
|
|
|
|
|
|
2020-06-03 13:28:18 -04:00
|
|
|
// methodsig is a typed method signature (name + type).
|
|
|
|
|
type methodsig struct {
|
|
|
|
|
name string
|
|
|
|
|
typ loader.Sym // type descriptor symbol of the function
|
|
|
|
|
}
|
|
|
|
|
|
2020-04-29 17:34:46 -04:00
|
|
|
// methodref holds the relocations from a receiver type symbol to its
|
2020-04-20 12:13:42 -04:00
|
|
|
// method. There are three relocations, one for each of the fields in
|
|
|
|
|
// the reflect.method struct: mtyp, ifn, and tfn.
|
2020-04-29 17:34:46 -04:00
|
|
|
type methodref struct {
|
2020-04-20 12:13:42 -04:00
|
|
|
m methodsig
|
|
|
|
|
src loader.Sym // receiver type symbol
|
|
|
|
|
r int // the index of R_METHODOFF relocations
|
|
|
|
|
}
|
|
|
|
|
|
2020-04-29 17:34:46 -04:00
|
|
|
func (m methodref) isExported() bool {
|
2020-06-03 13:28:18 -04:00
|
|
|
for _, r := range m.m.name {
|
2020-04-20 12:13:42 -04:00
|
|
|
return unicode.IsUpper(r)
|
|
|
|
|
}
|
|
|
|
|
panic("methodref has no signature")
|
|
|
|
|
}
|
|
|
|
|
|
2020-06-03 13:28:18 -04:00
|
|
|
// decodeMethodSig decodes an array of method signature information.
|
2020-04-20 12:13:42 -04:00
|
|
|
// Each element of the array is size bytes. The first 4 bytes is a
|
|
|
|
|
// nameOff for the method name, and the next 4 bytes is a typeOff for
|
|
|
|
|
// the function type.
|
|
|
|
|
//
|
|
|
|
|
// Conveniently this is the layout of both runtime.method and runtime.imethod.
|
2020-04-29 17:34:46 -04:00
|
|
|
func (d *deadcodePass) decodeMethodSig(ldr *loader.Loader, arch *sys.Arch, symIdx loader.Sym, relocs *loader.Relocs, off, size, count int) []methodsig {
|
2020-06-04 12:01:53 -04:00
|
|
|
if cap(d.methodsigstmp) < count {
|
|
|
|
|
d.methodsigstmp = append(d.methodsigstmp[:0], make([]methodsig, count)...)
|
|
|
|
|
}
|
|
|
|
|
var methods = d.methodsigstmp[:count]
|
2020-04-20 12:13:42 -04:00
|
|
|
for i := 0; i < count; i++ {
|
2020-06-03 13:28:18 -04:00
|
|
|
methods[i].name = decodetypeName(ldr, symIdx, relocs, off)
|
|
|
|
|
methods[i].typ = decodeRelocSym(ldr, symIdx, relocs, int32(off+4))
|
2020-04-20 12:13:42 -04:00
|
|
|
off += size
|
|
|
|
|
}
|
|
|
|
|
return methods
|
|
|
|
|
}
|
|
|
|
|
|
2020-09-21 20:44:53 -04:00
|
|
|
// Decode the method of interface type symbol symIdx at offset off.
|
|
|
|
|
func (d *deadcodePass) decodeIfaceMethod(ldr *loader.Loader, arch *sys.Arch, symIdx loader.Sym, off int64) methodsig {
|
2020-04-20 12:13:42 -04:00
|
|
|
p := ldr.Data(symIdx)
|
|
|
|
|
if decodetypeKind(arch, p)&kindMask != kindInterface {
|
|
|
|
|
panic(fmt.Sprintf("symbol %q is not an interface", ldr.SymName(symIdx)))
|
|
|
|
|
}
|
2020-09-21 20:44:53 -04:00
|
|
|
relocs := ldr.Relocs(symIdx)
|
|
|
|
|
var m methodsig
|
|
|
|
|
m.name = decodetypeName(ldr, symIdx, &relocs, int(off))
|
|
|
|
|
m.typ = decodeRelocSym(ldr, symIdx, &relocs, int32(off+4))
|
|
|
|
|
return m
|
2020-04-20 12:13:42 -04:00
|
|
|
}
|
|
|
|
|
|
2020-04-29 17:34:46 -04:00
|
|
|
func (d *deadcodePass) decodetypeMethods(ldr *loader.Loader, arch *sys.Arch, symIdx loader.Sym, relocs *loader.Relocs) []methodsig {
|
2020-04-20 12:13:42 -04:00
|
|
|
p := ldr.Data(symIdx)
|
|
|
|
|
if !decodetypeHasUncommon(arch, p) {
|
|
|
|
|
panic(fmt.Sprintf("no methods on %q", ldr.SymName(symIdx)))
|
|
|
|
|
}
|
|
|
|
|
off := commonsize(arch) // reflect.rtype
|
|
|
|
|
switch decodetypeKind(arch, p) & kindMask {
|
|
|
|
|
case kindStruct: // reflect.structType
|
|
|
|
|
off += 4 * arch.PtrSize
|
|
|
|
|
case kindPtr: // reflect.ptrType
|
|
|
|
|
off += arch.PtrSize
|
|
|
|
|
case kindFunc: // reflect.funcType
|
|
|
|
|
off += arch.PtrSize // 4 bytes, pointer aligned
|
|
|
|
|
case kindSlice: // reflect.sliceType
|
|
|
|
|
off += arch.PtrSize
|
|
|
|
|
case kindArray: // reflect.arrayType
|
|
|
|
|
off += 3 * arch.PtrSize
|
|
|
|
|
case kindChan: // reflect.chanType
|
|
|
|
|
off += 2 * arch.PtrSize
|
|
|
|
|
case kindMap: // reflect.mapType
|
|
|
|
|
off += 4*arch.PtrSize + 8
|
|
|
|
|
case kindInterface: // reflect.interfaceType
|
|
|
|
|
off += 3 * arch.PtrSize
|
|
|
|
|
default:
|
|
|
|
|
// just Sizeof(rtype)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
mcount := int(decodeInuxi(arch, p[off+4:], 2))
|
|
|
|
|
moff := int(decodeInuxi(arch, p[off+4+2+2:], 4))
|
|
|
|
|
off += moff // offset to array of reflect.method values
|
|
|
|
|
const sizeofMethod = 4 * 4 // sizeof reflect.method in program
|
2020-04-29 17:34:46 -04:00
|
|
|
return d.decodeMethodSig(ldr, arch, symIdx, relocs, off, sizeofMethod, mcount)
|
cmd/link: prune unused methods
Today the linker keeps all methods of reachable types. This is
necessary if a program uses reflect.Value.Call. But while use of
reflection is widespread in Go for encoders and decoders, using
it to call a method is rare.
This CL looks for the use of reflect.Value.Call in a program, and
if it is absent, adopts a (reasonably conservative) method pruning
strategy as part of dead code elimination. Any method that is
directly called is kept, and any method that matches a used
interface's method signature is kept.
Whether or not a method body is kept is determined by the relocation
from its receiver's *rtype to its *rtype. A small change in the
compiler marks these relocations as R_METHOD so they can be easily
collected and manipulated by the linker.
As a bonus, this technique removes the text segment of methods that
have been inlined. Looking at the output of building cmd/objdump with
-ldflags=-v=2 shows that inlined methods like
runtime.(*traceAllocBlockPtr).ptr are removed from the program.
Relatively little work is necessary to do this. Linking two
examples, jujud and cmd/objdump show no more than +2% link time.
Binaries that do not use reflect.Call.Value drop 4 - 20% in size:
addr2line: -793KB (18%)
asm: -346KB (8%)
cgo: -490KB (10%)
compile: -564KB (4%)
dist: -736KB (17%)
fix: -404KB (12%)
link: -328KB (7%)
nm: -827KB (19%)
objdump: -712KB (16%)
pack: -327KB (14%)
yacc: -350KB (10%)
Binaries that do use reflect.Call.Value see a modest size decrease
of 2 - 6% thanks to pruning of unexported methods:
api: -151KB (3%)
cover: -222KB (4%)
doc: -106KB (2.5%)
pprof: -314KB (3%)
trace: -357KB (4%)
vet: -187KB (2.7%)
jujud: -4.4MB (5.8%)
cmd/go: -384KB (3.4%)
The trivial Hello example program goes from 2MB to 1.68MB:
package main
import "fmt"
func main() {
fmt.Println("Hello, 世界")
}
Method pruning also helps when building small binaries with
"-ldflags=-s -w". The above program goes from 1.43MB to 1.2MB.
Unfortunately the linker can only tell if reflect.Value.Call has been
statically linked, not if it is dynamically used. And while use is
rare, it is linked into a very common standard library package,
text/template. The result is programs like cmd/go, which don't use
reflect.Value.Call, see limited benefit from this CL. If binary size
is important enough it may be possible to address this in future work.
For #6853.
Change-Id: Iabe90e210e813b08c3f8fd605f841f0458973396
Reviewed-on: https://go-review.googlesource.com/20483
Reviewed-by: Russ Cox <rsc@golang.org>
2016-03-07 23:45:04 -05:00
|
|
|
}
|