os: make use of pidfd on linux
Use Process.handle field to store pidfd, and make use of it. Only use
pidfd functionality if all the needed syscalls are available.
1. StartProcess: obtain the pidfd from the kernel, if available,
using the functionality added by CL 520266. Note we could not modify
syscall.StartProcess to return pidfd directly because it is a public
API and its callers do not expect it, so we have to use ensurePidfd
and getPidfd.
2. (*Process).Kill: use pidfdSendSignal, if the syscall is available
and pidfd is known. This is slightly more complicated than it should
be, since the syscall can be blocked by e.g. seccomp security policy,
therefore the need for a function to check if it's actually working,
and a soft fallback to kill. Perhaps this precaution is not really
needed.
3. (*Process).Wait: use pidfdWait, if available, otherwise fall back to
using waitid/wait4. This is also more complicated than expected due
to struct siginfo_t idiosyncrasy.
NOTE pidfdSendSignal and pidfdWait are used without a race workaround
(blockUntilWaitable and sigMu, added by CL 23967) because with pidfd,
PID recycle issue doesn't exist (IOW, pidfd, unlike PID, is guaranteed
to refer to one particular process) and thus the race doesn't exist
either.
For #62654.
Updates #13987.
Change-Id: I22ebcc7142b16a3a94c422d2f32504d1a80e8a8f
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/528438
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2023-09-13 01:07:10 -07:00
|
|
|
// Copyright 2023 The Go Authors. All rights reserved.
|
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
|
|
//go:build linux
|
|
|
|
|
|
|
|
|
|
// Support for pidfd was added during the course of a few Linux releases:
|
|
|
|
|
// v5.1: pidfd_send_signal syscall;
|
|
|
|
|
// v5.2: CLONE_PIDFD flag for clone syscall;
|
|
|
|
|
// v5.3: pidfd_open syscall, clone3 syscall;
|
|
|
|
|
// v5.4: P_PIDFD idtype support for waitid syscall;
|
|
|
|
|
// v5.6: pidfd_getfd syscall.
|
|
|
|
|
|
|
|
|
|
package os
|
|
|
|
|
|
|
|
|
|
import (
|
2023-11-16 01:42:39 -08:00
|
|
|
"internal/godebug"
|
os: make use of pidfd on linux
Use Process.handle field to store pidfd, and make use of it. Only use
pidfd functionality if all the needed syscalls are available.
1. StartProcess: obtain the pidfd from the kernel, if available,
using the functionality added by CL 520266. Note we could not modify
syscall.StartProcess to return pidfd directly because it is a public
API and its callers do not expect it, so we have to use ensurePidfd
and getPidfd.
2. (*Process).Kill: use pidfdSendSignal, if the syscall is available
and pidfd is known. This is slightly more complicated than it should
be, since the syscall can be blocked by e.g. seccomp security policy,
therefore the need for a function to check if it's actually working,
and a soft fallback to kill. Perhaps this precaution is not really
needed.
3. (*Process).Wait: use pidfdWait, if available, otherwise fall back to
using waitid/wait4. This is also more complicated than expected due
to struct siginfo_t idiosyncrasy.
NOTE pidfdSendSignal and pidfdWait are used without a race workaround
(blockUntilWaitable and sigMu, added by CL 23967) because with pidfd,
PID recycle issue doesn't exist (IOW, pidfd, unlike PID, is guaranteed
to refer to one particular process) and thus the race doesn't exist
either.
For #62654.
Updates #13987.
Change-Id: I22ebcc7142b16a3a94c422d2f32504d1a80e8a8f
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/528438
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2023-09-13 01:07:10 -07:00
|
|
|
"internal/syscall/unix"
|
|
|
|
|
"sync"
|
|
|
|
|
"syscall"
|
|
|
|
|
"unsafe"
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
func ensurePidfd(sysAttr *syscall.SysProcAttr) *syscall.SysProcAttr {
|
|
|
|
|
if !pidfdWorks() {
|
|
|
|
|
return sysAttr
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
var pidfd int
|
|
|
|
|
|
|
|
|
|
if sysAttr == nil {
|
|
|
|
|
return &syscall.SysProcAttr{
|
|
|
|
|
PidFD: &pidfd,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if sysAttr.PidFD == nil {
|
|
|
|
|
newSys := *sysAttr // copy
|
|
|
|
|
newSys.PidFD = &pidfd
|
|
|
|
|
return &newSys
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return sysAttr
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func getPidfd(sysAttr *syscall.SysProcAttr) uintptr {
|
|
|
|
|
if !pidfdWorks() {
|
|
|
|
|
return unsetHandle
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return uintptr(*sysAttr.PidFD)
|
|
|
|
|
}
|
|
|
|
|
|
2023-11-16 01:42:39 -08:00
|
|
|
var osfinderr = godebug.New("osfinderr")
|
|
|
|
|
|
|
|
|
|
func pidfdFind(pid int) (uintptr, error) {
|
|
|
|
|
if !pidfdWorks() {
|
|
|
|
|
return unsetHandle, syscall.ENOSYS
|
|
|
|
|
}
|
|
|
|
|
if osfinderr.Value() == "0" {
|
|
|
|
|
osfinderr.IncNonDefault()
|
|
|
|
|
return unsetHandle, syscall.ENOSYS
|
|
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
h, err := unix.PidFDOpen(pid, 0)
|
|
|
|
|
if err == nil {
|
|
|
|
|
return h, nil
|
|
|
|
|
}
|
|
|
|
|
return unsetHandle, convertESRCH(err)
|
|
|
|
|
}
|
|
|
|
|
|
os: make use of pidfd on linux
Use Process.handle field to store pidfd, and make use of it. Only use
pidfd functionality if all the needed syscalls are available.
1. StartProcess: obtain the pidfd from the kernel, if available,
using the functionality added by CL 520266. Note we could not modify
syscall.StartProcess to return pidfd directly because it is a public
API and its callers do not expect it, so we have to use ensurePidfd
and getPidfd.
2. (*Process).Kill: use pidfdSendSignal, if the syscall is available
and pidfd is known. This is slightly more complicated than it should
be, since the syscall can be blocked by e.g. seccomp security policy,
therefore the need for a function to check if it's actually working,
and a soft fallback to kill. Perhaps this precaution is not really
needed.
3. (*Process).Wait: use pidfdWait, if available, otherwise fall back to
using waitid/wait4. This is also more complicated than expected due
to struct siginfo_t idiosyncrasy.
NOTE pidfdSendSignal and pidfdWait are used without a race workaround
(blockUntilWaitable and sigMu, added by CL 23967) because with pidfd,
PID recycle issue doesn't exist (IOW, pidfd, unlike PID, is guaranteed
to refer to one particular process) and thus the race doesn't exist
either.
For #62654.
Updates #13987.
Change-Id: I22ebcc7142b16a3a94c422d2f32504d1a80e8a8f
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/528438
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2023-09-13 01:07:10 -07:00
|
|
|
func (p *Process) pidfdRelease() {
|
|
|
|
|
// Release pidfd unconditionally.
|
|
|
|
|
handle := p.handle.Swap(unsetHandle)
|
|
|
|
|
if handle != unsetHandle {
|
|
|
|
|
syscall.Close(int(handle))
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// _P_PIDFD is used as idtype argument to waitid syscall.
|
|
|
|
|
const _P_PIDFD = 3
|
|
|
|
|
|
|
|
|
|
func (p *Process) pidfdWait() (*ProcessState, error) {
|
|
|
|
|
handle := p.handle.Load()
|
|
|
|
|
if handle == unsetHandle || !pidfdWorks() {
|
|
|
|
|
return nil, syscall.ENOSYS
|
|
|
|
|
}
|
|
|
|
|
var (
|
|
|
|
|
info unix.SiginfoChild
|
|
|
|
|
rusage syscall.Rusage
|
|
|
|
|
e syscall.Errno
|
|
|
|
|
)
|
|
|
|
|
for {
|
|
|
|
|
_, _, e = syscall.Syscall6(syscall.SYS_WAITID, _P_PIDFD, handle, uintptr(unsafe.Pointer(&info)), syscall.WEXITED, uintptr(unsafe.Pointer(&rusage)), 0)
|
|
|
|
|
if e != syscall.EINTR {
|
|
|
|
|
break
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if e != 0 {
|
|
|
|
|
if e == syscall.EINVAL {
|
|
|
|
|
// This is either invalid option value (which should not happen
|
|
|
|
|
// as we only use WEXITED), or missing P_PIDFD support (Linux
|
|
|
|
|
// kernel < 5.4), meaning pidfd support is not implemented.
|
|
|
|
|
e = syscall.ENOSYS
|
|
|
|
|
}
|
|
|
|
|
return nil, e
|
|
|
|
|
}
|
|
|
|
|
p.setDone()
|
|
|
|
|
defer p.pidfdRelease()
|
|
|
|
|
return &ProcessState{
|
|
|
|
|
pid: int(info.Pid),
|
|
|
|
|
status: info.WaitStatus(),
|
|
|
|
|
rusage: &rusage,
|
|
|
|
|
}, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (p *Process) pidfdSendSignal(s syscall.Signal) error {
|
|
|
|
|
handle := p.handle.Load()
|
|
|
|
|
if handle == unsetHandle || !pidfdWorks() {
|
|
|
|
|
return syscall.ENOSYS
|
|
|
|
|
}
|
|
|
|
|
return convertESRCH(unix.PidFDSendSignal(handle, s))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func pidfdWorks() bool {
|
|
|
|
|
return checkPidfdOnce() == nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
var checkPidfdOnce = sync.OnceValue(checkPidfd)
|
|
|
|
|
|
|
|
|
|
// checkPidfd checks whether all required pidfd-related syscalls work.
|
|
|
|
|
// This consists of pidfd_open and pidfd_send_signal syscalls, and waitid
|
|
|
|
|
// syscall with idtype of P_PIDFD.
|
|
|
|
|
//
|
|
|
|
|
// Reasons for non-working pidfd syscalls include an older kernel and an
|
|
|
|
|
// execution environment in which the above system calls are restricted by
|
|
|
|
|
// seccomp or a similar technology.
|
|
|
|
|
func checkPidfd() error {
|
|
|
|
|
// Get a pidfd of the current process (opening of "/proc/self" won't
|
|
|
|
|
// work for waitid).
|
|
|
|
|
fd, err := unix.PidFDOpen(syscall.Getpid(), 0)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return NewSyscallError("pidfd_open", err)
|
|
|
|
|
}
|
|
|
|
|
defer syscall.Close(int(fd))
|
|
|
|
|
|
|
|
|
|
// Check waitid(P_PIDFD) works.
|
|
|
|
|
for {
|
|
|
|
|
_, _, err = syscall.Syscall6(syscall.SYS_WAITID, _P_PIDFD, fd, 0, syscall.WEXITED, 0, 0)
|
|
|
|
|
if err != syscall.EINTR {
|
|
|
|
|
break
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
// Expect ECHILD from waitid since we're not our own parent.
|
|
|
|
|
if err != syscall.ECHILD {
|
|
|
|
|
return NewSyscallError("pidfd_wait", err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Check pidfd_send_signal works (should be able to send 0 to itself).
|
|
|
|
|
if err := unix.PidFDSendSignal(fd, 0); err != nil {
|
|
|
|
|
return NewSyscallError("pidfd_send_signal", err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|