| 
									
										
										
										
											2012-02-16 23:51:04 -05:00
										 |  |  | // run | 
					
						
							| 
									
										
										
										
											2011-10-13 15:46:39 -04:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-04-10 14:32:26 -07:00
										 |  |  | // Copyright 2011 The Go Authors. All rights reserved. | 
					
						
							| 
									
										
										
										
											2011-10-13 15:46:39 -04:00
										 |  |  | // Use of this source code is governed by a BSD-style | 
					
						
							|  |  |  | // license that can be found in the LICENSE file. | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2012-02-24 10:30:39 +11:00
										 |  |  | // Test reordering of assignments. | 
					
						
							| 
									
										
										
										
											2011-10-13 15:46:39 -04:00
										 |  |  | 
 | 
					
						
							|  |  |  | package main | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | import "fmt" | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func main() { | 
					
						
							|  |  |  | 	p1() | 
					
						
							|  |  |  | 	p2() | 
					
						
							|  |  |  | 	p3() | 
					
						
							|  |  |  | 	p4() | 
					
						
							|  |  |  | 	p5() | 
					
						
							|  |  |  | 	p6() | 
					
						
							|  |  |  | 	p7() | 
					
						
							|  |  |  | 	p8() | 
					
						
							| 
									
										
										
											
												cmd/compile: Ensure left-to-right assignment
Add temporaries to reorder the assignment for OAS2XXX nodes.
This makes orderstmt(), rewrite
  a, b, c = ...
as
  tmp1, tmp2, tmp3 = ...
  a, b, c = tmp1, tmp2, tmp3
and
  a, ok = ...
as
  t1, t2 = ...
  a  = t1
  ok = t2
Fixes #13433.
Change-Id: Id0f5956e3a254d0a6f4b89b5f7b0e055b1f0e21f
Reviewed-on: https://go-review.googlesource.com/34713
Run-TryBot: Dhananjay Nakrani <dhananjayn@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
											
										 
											2016-12-23 22:28:45 -08:00
										 |  |  | 	p9() | 
					
						
							| 
									
										
										
										
											2011-10-13 15:46:39 -04:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | var gx []int | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func f(i int) int { | 
					
						
							|  |  |  | 	return gx[i] | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func check(x []int, x0, x1, x2 int) { | 
					
						
							|  |  |  | 	if x[0] != x0 || x[1] != x1 || x[2] != x2 { | 
					
						
							|  |  |  | 		fmt.Printf("%v, want %d,%d,%d\n", x, x0, x1, x2) | 
					
						
							|  |  |  | 		panic("failed") | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func check3(x, y, z, xx, yy, zz int) { | 
					
						
							|  |  |  | 	if x != xx || y != yy || z != zz { | 
					
						
							|  |  |  | 		fmt.Printf("%d,%d,%d, want %d,%d,%d\n", x, y, z, xx, yy, zz) | 
					
						
							|  |  |  | 		panic("failed") | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func p1() { | 
					
						
							| 
									
										
										
										
											2013-02-11 18:20:52 -05:00
										 |  |  | 	x := []int{1, 2, 3} | 
					
						
							| 
									
										
										
										
											2011-10-13 15:46:39 -04:00
										 |  |  | 	i := 0 | 
					
						
							|  |  |  | 	i, x[i] = 1, 100 | 
					
						
							|  |  |  | 	_ = i | 
					
						
							|  |  |  | 	check(x, 100, 2, 3) | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func p2() { | 
					
						
							| 
									
										
										
										
											2013-02-11 18:20:52 -05:00
										 |  |  | 	x := []int{1, 2, 3} | 
					
						
							| 
									
										
										
										
											2011-10-13 15:46:39 -04:00
										 |  |  | 	i := 0 | 
					
						
							|  |  |  | 	x[i], i = 100, 1 | 
					
						
							|  |  |  | 	_ = i | 
					
						
							|  |  |  | 	check(x, 100, 2, 3) | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func p3() { | 
					
						
							| 
									
										
										
										
											2013-02-11 18:20:52 -05:00
										 |  |  | 	x := []int{1, 2, 3} | 
					
						
							| 
									
										
										
										
											2011-10-13 15:46:39 -04:00
										 |  |  | 	y := x | 
					
						
							|  |  |  | 	gx = x | 
					
						
							|  |  |  | 	x[1], y[0] = f(0), f(1) | 
					
						
							|  |  |  | 	check(x, 2, 1, 3) | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func p4() { | 
					
						
							| 
									
										
										
										
											2013-02-11 18:20:52 -05:00
										 |  |  | 	x := []int{1, 2, 3} | 
					
						
							| 
									
										
										
										
											2011-10-13 15:46:39 -04:00
										 |  |  | 	y := x | 
					
						
							|  |  |  | 	gx = x | 
					
						
							|  |  |  | 	x[1], y[0] = gx[0], gx[1] | 
					
						
							|  |  |  | 	check(x, 2, 1, 3) | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func p5() { | 
					
						
							| 
									
										
										
										
											2013-02-11 18:20:52 -05:00
										 |  |  | 	x := []int{1, 2, 3} | 
					
						
							| 
									
										
										
										
											2011-10-13 15:46:39 -04:00
										 |  |  | 	y := x | 
					
						
							|  |  |  | 	p := &x[0] | 
					
						
							|  |  |  | 	q := &x[1] | 
					
						
							|  |  |  | 	*p, *q = x[1], y[0] | 
					
						
							|  |  |  | 	check(x, 2, 1, 3) | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func p6() { | 
					
						
							|  |  |  | 	x := 1 | 
					
						
							|  |  |  | 	y := 2 | 
					
						
							|  |  |  | 	z := 3 | 
					
						
							|  |  |  | 	px := &x | 
					
						
							|  |  |  | 	py := &y | 
					
						
							|  |  |  | 	*px, *py = y, x | 
					
						
							| 
									
										
										
										
											2013-02-11 18:20:52 -05:00
										 |  |  | 	check3(x, y, z, 2, 1, 3) | 
					
						
							| 
									
										
										
										
											2011-10-13 15:46:39 -04:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func f1(x, y, z int) (xx, yy, zz int) { | 
					
						
							|  |  |  | 	return x, y, z | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func f2() (x, y, z int) { | 
					
						
							|  |  |  | 	return f1(2, 1, 3) | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func p7() { | 
					
						
							|  |  |  | 	x, y, z := f2() | 
					
						
							|  |  |  | 	check3(x, y, z, 2, 1, 3) | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | func p8() { | 
					
						
							| 
									
										
										
										
											2012-04-24 10:17:26 -07:00
										 |  |  | 	m := make(map[int]int) | 
					
						
							|  |  |  | 	m[0] = len(m) | 
					
						
							|  |  |  | 	if m[0] != 0 { | 
					
						
							|  |  |  | 		panic(m[0]) | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | } | 
					
						
							| 
									
										
										
											
												cmd/compile: Ensure left-to-right assignment
Add temporaries to reorder the assignment for OAS2XXX nodes.
This makes orderstmt(), rewrite
  a, b, c = ...
as
  tmp1, tmp2, tmp3 = ...
  a, b, c = tmp1, tmp2, tmp3
and
  a, ok = ...
as
  t1, t2 = ...
  a  = t1
  ok = t2
Fixes #13433.
Change-Id: Id0f5956e3a254d0a6f4b89b5f7b0e055b1f0e21f
Reviewed-on: https://go-review.googlesource.com/34713
Run-TryBot: Dhananjay Nakrani <dhananjayn@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
											
										 
											2016-12-23 22:28:45 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  | // Issue #13433: Left-to-right assignment of OAS2XXX nodes. | 
					
						
							|  |  |  | func p9() { | 
					
						
							|  |  |  | 	var x bool | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	// OAS2FUNC | 
					
						
							|  |  |  | 	x, x = fn() | 
					
						
							|  |  |  | 	checkOAS2XXX(x, "x, x = fn()") | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	// OAS2RECV | 
					
						
							|  |  |  | 	var c = make(chan bool, 10) | 
					
						
							|  |  |  | 	c <- false | 
					
						
							|  |  |  | 	x, x = <-c | 
					
						
							|  |  |  | 	checkOAS2XXX(x, "x, x <-c") | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	// OAS2MAPR | 
					
						
							|  |  |  | 	var m = map[int]bool{0: false} | 
					
						
							|  |  |  | 	x, x = m[0] | 
					
						
							|  |  |  | 	checkOAS2XXX(x, "x, x = m[0]") | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 	// OAS2DOTTYPE | 
					
						
							|  |  |  | 	var i interface{} = false | 
					
						
							|  |  |  | 	x, x = i.(bool) | 
					
						
							|  |  |  | 	checkOAS2XXX(x, "x, x = i.(bool)") | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | //go:noinline | 
					
						
							|  |  |  | func fn() (bool, bool) { return false, true } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | // checks the order of OAS2XXX. | 
					
						
							|  |  |  | func checkOAS2XXX(x bool, s string) { | 
					
						
							|  |  |  | 	if !x { | 
					
						
							|  |  |  | 		fmt.Printf("%s; got=(false); want=(true)\n", s) | 
					
						
							|  |  |  | 		panic("failed") | 
					
						
							|  |  |  | 	} | 
					
						
							|  |  |  | } |