2018-11-01 01:01:09 -04:00
|
|
|
// Copyright 2018 The Go Authors. All rights reserved.
|
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
|
|
package tls
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"bytes"
|
|
|
|
|
"crypto"
|
|
|
|
|
"crypto/hmac"
|
crypto/tls: implement TLS 1.3 client authentication
Note that the SignatureSchemes passed to GetClientCertificate in TLS 1.2
are now filtered by the requested certificate type. This feels like an
improvement anyway, and the full list can be surfaced as well when
support for signature_algorithms_cert is added, which actually matches
the semantics of the CertificateRequest signature_algorithms in TLS 1.2.
Also, note a subtle behavior change in server side resumption: if a
certificate is requested but not required, and the resumed session did
not include one, it used not to invoke VerifyPeerCertificate. However,
if the resumed session did include a certificate, it would. (If a
certificate was required but not in the session, the session is rejected
in checkForResumption.) This inconsistency could be unexpected, even
dangerous, so now VerifyPeerCertificate is always invoked. Still not
consistent with the client behavior, which does not ever invoke
VerifyPeerCertificate on resumption, but it felt too surprising to
entirely change either.
Updates #9671
Change-Id: Ib2b0dbc30e659208dca3ac07d6c687a407d7aaaf
Reviewed-on: https://go-review.googlesource.com/c/147599
Reviewed-by: Adam Langley <agl@golang.org>
2018-11-05 19:23:25 -05:00
|
|
|
"crypto/rsa"
|
2018-11-01 01:01:09 -04:00
|
|
|
"errors"
|
|
|
|
|
"hash"
|
|
|
|
|
"sync/atomic"
|
2018-11-04 18:41:37 -05:00
|
|
|
"time"
|
2018-11-01 01:01:09 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
type clientHandshakeStateTLS13 struct {
|
2018-11-04 18:41:37 -05:00
|
|
|
c *Conn
|
|
|
|
|
serverHello *serverHelloMsg
|
|
|
|
|
hello *clientHelloMsg
|
|
|
|
|
ecdheParams ecdheParameters
|
|
|
|
|
|
|
|
|
|
session *ClientSessionState
|
|
|
|
|
earlySecret []byte
|
|
|
|
|
binderKey []byte
|
|
|
|
|
|
2018-11-01 01:01:09 -04:00
|
|
|
certReq *certificateRequestMsgTLS13
|
2018-11-04 18:41:37 -05:00
|
|
|
usingPSK bool
|
2018-11-03 20:04:44 -04:00
|
|
|
sentDummyCCS bool
|
2018-11-01 01:01:09 -04:00
|
|
|
suite *cipherSuiteTLS13
|
|
|
|
|
transcript hash.Hash
|
|
|
|
|
masterSecret []byte
|
|
|
|
|
trafficSecret []byte // client_application_traffic_secret_0
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-04 18:41:37 -05:00
|
|
|
// handshake requires hs.c, hs.hello, hs.serverHello, hs.ecdheParams, and,
|
|
|
|
|
// optionally, hs.session, hs.earlySecret and hs.binderKey to be set.
|
2018-11-01 01:01:09 -04:00
|
|
|
func (hs *clientHandshakeStateTLS13) handshake() error {
|
|
|
|
|
c := hs.c
|
|
|
|
|
|
|
|
|
|
// The server must not select TLS 1.3 in a renegotiation. See RFC 8446,
|
|
|
|
|
// sections 4.1.2 and 4.1.3.
|
|
|
|
|
if c.handshakes > 0 {
|
|
|
|
|
c.sendAlert(alertProtocolVersion)
|
|
|
|
|
return errors.New("tls: server selected TLS 1.3 in a renegotiation")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Consistency check on the presence of a keyShare and its parameters.
|
|
|
|
|
if hs.ecdheParams == nil || len(hs.hello.keyShares) != 1 {
|
|
|
|
|
return c.sendAlert(alertInternalError)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if err := hs.checkServerHelloOrHRR(); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
hs.transcript = hs.suite.hash.New()
|
|
|
|
|
hs.transcript.Write(hs.hello.marshal())
|
|
|
|
|
|
|
|
|
|
if bytes.Equal(hs.serverHello.random, helloRetryRequestRandom) {
|
2018-11-03 20:04:44 -04:00
|
|
|
if err := hs.sendDummyChangeCipherSpec(); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
2018-11-01 01:01:09 -04:00
|
|
|
if err := hs.processHelloRetryRequest(); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
hs.transcript.Write(hs.serverHello.marshal())
|
|
|
|
|
|
2018-11-03 20:04:44 -04:00
|
|
|
c.buffering = true
|
2018-11-01 01:01:09 -04:00
|
|
|
if err := hs.processServerHello(); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
2018-11-03 20:04:44 -04:00
|
|
|
if err := hs.sendDummyChangeCipherSpec(); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
2018-11-01 01:01:09 -04:00
|
|
|
if err := hs.establishHandshakeKeys(); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
if err := hs.readServerParameters(); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
2018-11-04 18:41:37 -05:00
|
|
|
if err := hs.readServerCertificate(); err != nil {
|
2018-11-01 01:01:09 -04:00
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
if err := hs.readServerFinished(); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
if err := hs.sendClientCertificate(); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
if err := hs.sendClientFinished(); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
if _, err := c.flush(); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
atomic.StoreUint32(&c.handshakeStatus, 1)
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// checkServerHelloOrHRR does validity checks that apply to both ServerHello and
|
|
|
|
|
// HelloRetryRequest messages. It sets hs.suite.
|
|
|
|
|
func (hs *clientHandshakeStateTLS13) checkServerHelloOrHRR() error {
|
|
|
|
|
c := hs.c
|
|
|
|
|
|
|
|
|
|
if hs.serverHello.supportedVersion == 0 {
|
|
|
|
|
c.sendAlert(alertMissingExtension)
|
|
|
|
|
return errors.New("tls: server selected TLS 1.3 using the legacy version field")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if hs.serverHello.supportedVersion != VersionTLS13 {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: server selected an invalid version after a HelloRetryRequest")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if hs.serverHello.vers != VersionTLS12 {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: server sent an incorrect legacy version")
|
|
|
|
|
}
|
|
|
|
|
|
2019-04-29 22:04:09 +00:00
|
|
|
if hs.serverHello.ocspStapling ||
|
2018-11-01 01:01:09 -04:00
|
|
|
hs.serverHello.ticketSupported ||
|
|
|
|
|
hs.serverHello.secureRenegotiationSupported ||
|
|
|
|
|
len(hs.serverHello.secureRenegotiation) != 0 ||
|
|
|
|
|
len(hs.serverHello.alpnProtocol) != 0 ||
|
|
|
|
|
len(hs.serverHello.scts) != 0 {
|
|
|
|
|
c.sendAlert(alertUnsupportedExtension)
|
|
|
|
|
return errors.New("tls: server sent a ServerHello extension forbidden in TLS 1.3")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if !bytes.Equal(hs.hello.sessionId, hs.serverHello.sessionId) {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: server did not echo the legacy session ID")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if hs.serverHello.compressionMethod != compressionNone {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: server selected unsupported compression format")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
selectedSuite := mutualCipherSuiteTLS13(hs.hello.cipherSuites, hs.serverHello.cipherSuite)
|
|
|
|
|
if hs.suite != nil && selectedSuite != hs.suite {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: server changed cipher suite after a HelloRetryRequest")
|
|
|
|
|
}
|
|
|
|
|
if selectedSuite == nil {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: server chose an unconfigured cipher suite")
|
|
|
|
|
}
|
|
|
|
|
hs.suite = selectedSuite
|
|
|
|
|
c.cipherSuite = hs.suite.id
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-03 20:04:44 -04:00
|
|
|
// sendDummyChangeCipherSpec sends a ChangeCipherSpec record for compatibility
|
|
|
|
|
// with middleboxes that didn't implement TLS correctly. See RFC 8446, Appendix D.4.
|
|
|
|
|
func (hs *clientHandshakeStateTLS13) sendDummyChangeCipherSpec() error {
|
|
|
|
|
if hs.sentDummyCCS {
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
hs.sentDummyCCS = true
|
|
|
|
|
|
|
|
|
|
_, err := hs.c.writeRecord(recordTypeChangeCipherSpec, []byte{1})
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-01 01:01:09 -04:00
|
|
|
// processHelloRetryRequest handles the HRR in hs.serverHello, modifies and
|
|
|
|
|
// resends hs.hello, and reads the new ServerHello into hs.serverHello.
|
|
|
|
|
func (hs *clientHandshakeStateTLS13) processHelloRetryRequest() error {
|
|
|
|
|
c := hs.c
|
|
|
|
|
|
2018-11-04 18:41:37 -05:00
|
|
|
// The first ClientHello gets double-hashed into the transcript upon a
|
|
|
|
|
// HelloRetryRequest. See RFC 8446, Section 4.4.1.
|
|
|
|
|
chHash := hs.transcript.Sum(nil)
|
|
|
|
|
hs.transcript.Reset()
|
|
|
|
|
hs.transcript.Write([]byte{typeMessageHash, 0, 0, uint8(len(chHash))})
|
|
|
|
|
hs.transcript.Write(chHash)
|
|
|
|
|
hs.transcript.Write(hs.serverHello.marshal())
|
|
|
|
|
|
2018-11-01 01:01:09 -04:00
|
|
|
if hs.serverHello.serverShare.group != 0 {
|
|
|
|
|
c.sendAlert(alertDecodeError)
|
|
|
|
|
return errors.New("tls: received malformed key_share extension")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
curveID := hs.serverHello.selectedGroup
|
|
|
|
|
if curveID == 0 {
|
|
|
|
|
c.sendAlert(alertMissingExtension)
|
|
|
|
|
return errors.New("tls: received HelloRetryRequest without selected group")
|
|
|
|
|
}
|
|
|
|
|
curveOK := false
|
|
|
|
|
for _, id := range hs.hello.supportedCurves {
|
|
|
|
|
if id == curveID {
|
|
|
|
|
curveOK = true
|
|
|
|
|
break
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if !curveOK {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: server selected unsupported group")
|
|
|
|
|
}
|
|
|
|
|
if hs.ecdheParams.CurveID() == curveID {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: server sent an unnecessary HelloRetryRequest message")
|
|
|
|
|
}
|
|
|
|
|
if _, ok := curveForCurveID(curveID); curveID != X25519 && !ok {
|
|
|
|
|
c.sendAlert(alertInternalError)
|
|
|
|
|
return errors.New("tls: CurvePreferences includes unsupported curve")
|
|
|
|
|
}
|
|
|
|
|
params, err := generateECDHEParameters(c.config.rand(), curveID)
|
|
|
|
|
if err != nil {
|
|
|
|
|
c.sendAlert(alertInternalError)
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
hs.ecdheParams = params
|
|
|
|
|
hs.hello.keyShares = []keyShare{{group: curveID, data: params.PublicKey()}}
|
|
|
|
|
|
|
|
|
|
hs.hello.cookie = hs.serverHello.cookie
|
|
|
|
|
|
|
|
|
|
hs.hello.raw = nil
|
2018-11-04 18:41:37 -05:00
|
|
|
if len(hs.hello.pskIdentities) > 0 {
|
|
|
|
|
pskSuite := cipherSuiteTLS13ByID(hs.session.cipherSuite)
|
|
|
|
|
if pskSuite == nil {
|
|
|
|
|
return c.sendAlert(alertInternalError)
|
|
|
|
|
}
|
|
|
|
|
if pskSuite.hash == hs.suite.hash {
|
|
|
|
|
// Update binders and obfuscated_ticket_age.
|
|
|
|
|
ticketAge := uint32(c.config.time().Sub(hs.session.receivedAt) / time.Millisecond)
|
|
|
|
|
hs.hello.pskIdentities[0].obfuscatedTicketAge = ticketAge + hs.session.ageAdd
|
|
|
|
|
|
|
|
|
|
transcript := hs.suite.hash.New()
|
|
|
|
|
transcript.Write([]byte{typeMessageHash, 0, 0, uint8(len(chHash))})
|
|
|
|
|
transcript.Write(chHash)
|
|
|
|
|
transcript.Write(hs.serverHello.marshal())
|
|
|
|
|
transcript.Write(hs.hello.marshalWithoutBinders())
|
|
|
|
|
pskBinders := [][]byte{hs.suite.finishedHash(hs.binderKey, transcript)}
|
|
|
|
|
hs.hello.updateBinders(pskBinders)
|
|
|
|
|
} else {
|
|
|
|
|
// Server selected a cipher suite incompatible with the PSK.
|
|
|
|
|
hs.hello.pskIdentities = nil
|
|
|
|
|
hs.hello.pskBinders = nil
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
hs.transcript.Write(hs.hello.marshal())
|
2018-11-01 01:01:09 -04:00
|
|
|
if _, err := c.writeRecord(recordTypeHandshake, hs.hello.marshal()); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
msg, err := c.readHandshake()
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
serverHello, ok := msg.(*serverHelloMsg)
|
|
|
|
|
if !ok {
|
|
|
|
|
c.sendAlert(alertUnexpectedMessage)
|
|
|
|
|
return unexpectedMessageError(serverHello, msg)
|
|
|
|
|
}
|
|
|
|
|
hs.serverHello = serverHello
|
|
|
|
|
|
|
|
|
|
if err := hs.checkServerHelloOrHRR(); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (hs *clientHandshakeStateTLS13) processServerHello() error {
|
|
|
|
|
c := hs.c
|
|
|
|
|
|
|
|
|
|
if bytes.Equal(hs.serverHello.random, helloRetryRequestRandom) {
|
|
|
|
|
c.sendAlert(alertUnexpectedMessage)
|
|
|
|
|
return errors.New("tls: server sent two HelloRetryRequest messages")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if len(hs.serverHello.cookie) != 0 {
|
|
|
|
|
c.sendAlert(alertUnsupportedExtension)
|
|
|
|
|
return errors.New("tls: server sent a cookie in a normal ServerHello")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if hs.serverHello.selectedGroup != 0 {
|
|
|
|
|
c.sendAlert(alertDecodeError)
|
|
|
|
|
return errors.New("tls: malformed key_share extension")
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-04 18:41:37 -05:00
|
|
|
if hs.serverHello.serverShare.group == 0 {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: server did not send a key share")
|
|
|
|
|
}
|
2018-11-01 01:01:09 -04:00
|
|
|
if hs.serverHello.serverShare.group != hs.ecdheParams.CurveID() {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: server selected unsupported group")
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-04 18:41:37 -05:00
|
|
|
if !hs.serverHello.selectedIdentityPresent {
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if int(hs.serverHello.selectedIdentity) >= len(hs.hello.pskIdentities) {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: server selected an invalid PSK")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if len(hs.hello.pskIdentities) != 1 || hs.session == nil {
|
|
|
|
|
return c.sendAlert(alertInternalError)
|
|
|
|
|
}
|
|
|
|
|
pskSuite := cipherSuiteTLS13ByID(hs.session.cipherSuite)
|
|
|
|
|
if pskSuite == nil {
|
|
|
|
|
return c.sendAlert(alertInternalError)
|
|
|
|
|
}
|
|
|
|
|
if pskSuite.hash != hs.suite.hash {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: server selected an invalid PSK and cipher suite pair")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
hs.usingPSK = true
|
|
|
|
|
c.didResume = true
|
|
|
|
|
c.peerCertificates = hs.session.serverCertificates
|
|
|
|
|
c.verifiedChains = hs.session.verifiedChains
|
2018-11-01 01:01:09 -04:00
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (hs *clientHandshakeStateTLS13) establishHandshakeKeys() error {
|
|
|
|
|
c := hs.c
|
|
|
|
|
|
|
|
|
|
sharedKey := hs.ecdheParams.SharedKey(hs.serverHello.serverShare.data)
|
|
|
|
|
if sharedKey == nil {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: invalid server key share")
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-04 18:41:37 -05:00
|
|
|
earlySecret := hs.earlySecret
|
|
|
|
|
if !hs.usingPSK {
|
|
|
|
|
earlySecret = hs.suite.extract(nil, nil)
|
|
|
|
|
}
|
2018-11-01 01:01:09 -04:00
|
|
|
handshakeSecret := hs.suite.extract(sharedKey,
|
|
|
|
|
hs.suite.deriveSecret(earlySecret, "derived", nil))
|
|
|
|
|
|
|
|
|
|
clientSecret := hs.suite.deriveSecret(handshakeSecret,
|
|
|
|
|
clientHandshakeTrafficLabel, hs.transcript)
|
|
|
|
|
c.out.setTrafficSecret(hs.suite, clientSecret)
|
|
|
|
|
serverSecret := hs.suite.deriveSecret(handshakeSecret,
|
|
|
|
|
serverHandshakeTrafficLabel, hs.transcript)
|
|
|
|
|
c.in.setTrafficSecret(hs.suite, serverSecret)
|
|
|
|
|
|
2018-11-03 18:13:05 -04:00
|
|
|
err := c.config.writeKeyLog(keyLogLabelClientHandshake, hs.hello.random, clientSecret)
|
|
|
|
|
if err != nil {
|
|
|
|
|
c.sendAlert(alertInternalError)
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
err = c.config.writeKeyLog(keyLogLabelServerHandshake, hs.hello.random, serverSecret)
|
|
|
|
|
if err != nil {
|
|
|
|
|
c.sendAlert(alertInternalError)
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-01 01:01:09 -04:00
|
|
|
hs.masterSecret = hs.suite.extract(nil,
|
|
|
|
|
hs.suite.deriveSecret(handshakeSecret, "derived", nil))
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (hs *clientHandshakeStateTLS13) readServerParameters() error {
|
|
|
|
|
c := hs.c
|
|
|
|
|
|
|
|
|
|
msg, err := c.readHandshake()
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
encryptedExtensions, ok := msg.(*encryptedExtensionsMsg)
|
|
|
|
|
if !ok {
|
|
|
|
|
c.sendAlert(alertUnexpectedMessage)
|
|
|
|
|
return unexpectedMessageError(encryptedExtensions, msg)
|
|
|
|
|
}
|
|
|
|
|
hs.transcript.Write(encryptedExtensions.marshal())
|
|
|
|
|
|
|
|
|
|
if len(encryptedExtensions.alpnProtocol) != 0 && len(hs.hello.alpnProtocols) == 0 {
|
|
|
|
|
c.sendAlert(alertUnsupportedExtension)
|
|
|
|
|
return errors.New("tls: server advertised unrequested ALPN extension")
|
|
|
|
|
}
|
|
|
|
|
c.clientProtocol = encryptedExtensions.alpnProtocol
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-04 18:41:37 -05:00
|
|
|
func (hs *clientHandshakeStateTLS13) readServerCertificate() error {
|
2018-11-01 01:01:09 -04:00
|
|
|
c := hs.c
|
|
|
|
|
|
2018-11-04 18:41:37 -05:00
|
|
|
// Either a PSK or a certificate is always used, but not both.
|
|
|
|
|
// See RFC 8446, Section 4.1.1.
|
|
|
|
|
if hs.usingPSK {
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-01 01:01:09 -04:00
|
|
|
msg, err := c.readHandshake()
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
certReq, ok := msg.(*certificateRequestMsgTLS13)
|
|
|
|
|
if ok {
|
|
|
|
|
hs.transcript.Write(certReq.marshal())
|
|
|
|
|
|
|
|
|
|
hs.certReq = certReq
|
|
|
|
|
|
|
|
|
|
msg, err = c.readHandshake()
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
certMsg, ok := msg.(*certificateMsgTLS13)
|
|
|
|
|
if !ok {
|
|
|
|
|
c.sendAlert(alertUnexpectedMessage)
|
|
|
|
|
return unexpectedMessageError(certMsg, msg)
|
|
|
|
|
}
|
|
|
|
|
if len(certMsg.certificate.Certificate) == 0 {
|
|
|
|
|
c.sendAlert(alertDecodeError)
|
|
|
|
|
return errors.New("tls: received empty certificates message")
|
|
|
|
|
}
|
|
|
|
|
hs.transcript.Write(certMsg.marshal())
|
|
|
|
|
|
|
|
|
|
c.scts = certMsg.certificate.SignedCertificateTimestamps
|
|
|
|
|
c.ocspResponse = certMsg.certificate.OCSPStaple
|
|
|
|
|
|
|
|
|
|
if err := c.verifyServerCertificate(certMsg.certificate.Certificate); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
msg, err = c.readHandshake()
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
certVerify, ok := msg.(*certificateVerifyMsg)
|
|
|
|
|
if !ok {
|
|
|
|
|
c.sendAlert(alertUnexpectedMessage)
|
|
|
|
|
return unexpectedMessageError(certVerify, msg)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// See RFC 8446, Section 4.4.3.
|
crypto/tls: implement TLS 1.3 client authentication
Note that the SignatureSchemes passed to GetClientCertificate in TLS 1.2
are now filtered by the requested certificate type. This feels like an
improvement anyway, and the full list can be surfaced as well when
support for signature_algorithms_cert is added, which actually matches
the semantics of the CertificateRequest signature_algorithms in TLS 1.2.
Also, note a subtle behavior change in server side resumption: if a
certificate is requested but not required, and the resumed session did
not include one, it used not to invoke VerifyPeerCertificate. However,
if the resumed session did include a certificate, it would. (If a
certificate was required but not in the session, the session is rejected
in checkForResumption.) This inconsistency could be unexpected, even
dangerous, so now VerifyPeerCertificate is always invoked. Still not
consistent with the client behavior, which does not ever invoke
VerifyPeerCertificate on resumption, but it felt too surprising to
entirely change either.
Updates #9671
Change-Id: Ib2b0dbc30e659208dca3ac07d6c687a407d7aaaf
Reviewed-on: https://go-review.googlesource.com/c/147599
Reviewed-by: Adam Langley <agl@golang.org>
2018-11-05 19:23:25 -05:00
|
|
|
if !isSupportedSignatureAlgorithm(certVerify.signatureAlgorithm, supportedSignatureAlgorithms) {
|
2018-11-01 01:01:09 -04:00
|
|
|
c.sendAlert(alertIllegalParameter)
|
2019-10-29 16:46:26 -04:00
|
|
|
return errors.New("tls: certificate used with invalid signature algorithm")
|
2018-11-01 01:01:09 -04:00
|
|
|
}
|
2019-10-29 16:46:26 -04:00
|
|
|
sigType, sigHash, err := typeAndHashFromSignatureScheme(certVerify.signatureAlgorithm)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return c.sendAlert(alertInternalError)
|
2018-11-01 01:01:09 -04:00
|
|
|
}
|
|
|
|
|
if sigType == signaturePKCS1v15 || sigHash == crypto.SHA1 {
|
|
|
|
|
c.sendAlert(alertIllegalParameter)
|
2019-10-29 16:46:26 -04:00
|
|
|
return errors.New("tls: certificate used with invalid signature algorithm")
|
2018-11-01 01:01:09 -04:00
|
|
|
}
|
2019-05-16 19:13:29 -04:00
|
|
|
signed := signedMessage(sigHash, serverSignatureContext, hs.transcript)
|
2018-11-01 01:01:09 -04:00
|
|
|
if err := verifyHandshakeSignature(sigType, c.peerCertificates[0].PublicKey,
|
2019-05-16 19:13:29 -04:00
|
|
|
sigHash, signed, certVerify.signature); err != nil {
|
2018-11-01 01:01:09 -04:00
|
|
|
c.sendAlert(alertDecryptError)
|
2019-10-29 16:46:26 -04:00
|
|
|
return errors.New("tls: invalid signature by the server certificate: " + err.Error())
|
2018-11-01 01:01:09 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
hs.transcript.Write(certVerify.marshal())
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (hs *clientHandshakeStateTLS13) readServerFinished() error {
|
|
|
|
|
c := hs.c
|
|
|
|
|
|
|
|
|
|
msg, err := c.readHandshake()
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
finished, ok := msg.(*finishedMsg)
|
|
|
|
|
if !ok {
|
|
|
|
|
c.sendAlert(alertUnexpectedMessage)
|
|
|
|
|
return unexpectedMessageError(finished, msg)
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-04 18:41:37 -05:00
|
|
|
expectedMAC := hs.suite.finishedHash(c.in.trafficSecret, hs.transcript)
|
|
|
|
|
if !hmac.Equal(expectedMAC, finished.verifyData) {
|
2018-11-01 01:01:09 -04:00
|
|
|
c.sendAlert(alertDecryptError)
|
2018-11-04 18:41:37 -05:00
|
|
|
return errors.New("tls: invalid server finished hash")
|
2018-11-01 01:01:09 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
hs.transcript.Write(finished.marshal())
|
|
|
|
|
|
|
|
|
|
// Derive secrets that take context through the server Finished.
|
|
|
|
|
|
|
|
|
|
hs.trafficSecret = hs.suite.deriveSecret(hs.masterSecret,
|
|
|
|
|
clientApplicationTrafficLabel, hs.transcript)
|
|
|
|
|
serverSecret := hs.suite.deriveSecret(hs.masterSecret,
|
|
|
|
|
serverApplicationTrafficLabel, hs.transcript)
|
|
|
|
|
c.in.setTrafficSecret(hs.suite, serverSecret)
|
|
|
|
|
|
2018-11-03 18:13:05 -04:00
|
|
|
err = c.config.writeKeyLog(keyLogLabelClientTraffic, hs.hello.random, hs.trafficSecret)
|
|
|
|
|
if err != nil {
|
|
|
|
|
c.sendAlert(alertInternalError)
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
err = c.config.writeKeyLog(keyLogLabelServerTraffic, hs.hello.random, serverSecret)
|
|
|
|
|
if err != nil {
|
|
|
|
|
c.sendAlert(alertInternalError)
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-01 01:01:09 -04:00
|
|
|
c.ekm = hs.suite.exportKeyingMaterial(hs.masterSecret, hs.transcript)
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (hs *clientHandshakeStateTLS13) sendClientCertificate() error {
|
crypto/tls: implement TLS 1.3 client authentication
Note that the SignatureSchemes passed to GetClientCertificate in TLS 1.2
are now filtered by the requested certificate type. This feels like an
improvement anyway, and the full list can be surfaced as well when
support for signature_algorithms_cert is added, which actually matches
the semantics of the CertificateRequest signature_algorithms in TLS 1.2.
Also, note a subtle behavior change in server side resumption: if a
certificate is requested but not required, and the resumed session did
not include one, it used not to invoke VerifyPeerCertificate. However,
if the resumed session did include a certificate, it would. (If a
certificate was required but not in the session, the session is rejected
in checkForResumption.) This inconsistency could be unexpected, even
dangerous, so now VerifyPeerCertificate is always invoked. Still not
consistent with the client behavior, which does not ever invoke
VerifyPeerCertificate on resumption, but it felt too surprising to
entirely change either.
Updates #9671
Change-Id: Ib2b0dbc30e659208dca3ac07d6c687a407d7aaaf
Reviewed-on: https://go-review.googlesource.com/c/147599
Reviewed-by: Adam Langley <agl@golang.org>
2018-11-05 19:23:25 -05:00
|
|
|
c := hs.c
|
|
|
|
|
|
2018-11-01 01:01:09 -04:00
|
|
|
if hs.certReq == nil {
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
crypto/tls: implement TLS 1.3 client authentication
Note that the SignatureSchemes passed to GetClientCertificate in TLS 1.2
are now filtered by the requested certificate type. This feels like an
improvement anyway, and the full list can be surfaced as well when
support for signature_algorithms_cert is added, which actually matches
the semantics of the CertificateRequest signature_algorithms in TLS 1.2.
Also, note a subtle behavior change in server side resumption: if a
certificate is requested but not required, and the resumed session did
not include one, it used not to invoke VerifyPeerCertificate. However,
if the resumed session did include a certificate, it would. (If a
certificate was required but not in the session, the session is rejected
in checkForResumption.) This inconsistency could be unexpected, even
dangerous, so now VerifyPeerCertificate is always invoked. Still not
consistent with the client behavior, which does not ever invoke
VerifyPeerCertificate on resumption, but it felt too surprising to
entirely change either.
Updates #9671
Change-Id: Ib2b0dbc30e659208dca3ac07d6c687a407d7aaaf
Reviewed-on: https://go-review.googlesource.com/c/147599
Reviewed-by: Adam Langley <agl@golang.org>
2018-11-05 19:23:25 -05:00
|
|
|
cert, err := c.getClientCertificate(&CertificateRequestInfo{
|
|
|
|
|
AcceptableCAs: hs.certReq.certificateAuthorities,
|
|
|
|
|
SignatureSchemes: hs.certReq.supportedSignatureAlgorithms,
|
2019-11-01 19:40:05 -04:00
|
|
|
Version: c.vers,
|
crypto/tls: implement TLS 1.3 client authentication
Note that the SignatureSchemes passed to GetClientCertificate in TLS 1.2
are now filtered by the requested certificate type. This feels like an
improvement anyway, and the full list can be surfaced as well when
support for signature_algorithms_cert is added, which actually matches
the semantics of the CertificateRequest signature_algorithms in TLS 1.2.
Also, note a subtle behavior change in server side resumption: if a
certificate is requested but not required, and the resumed session did
not include one, it used not to invoke VerifyPeerCertificate. However,
if the resumed session did include a certificate, it would. (If a
certificate was required but not in the session, the session is rejected
in checkForResumption.) This inconsistency could be unexpected, even
dangerous, so now VerifyPeerCertificate is always invoked. Still not
consistent with the client behavior, which does not ever invoke
VerifyPeerCertificate on resumption, but it felt too surprising to
entirely change either.
Updates #9671
Change-Id: Ib2b0dbc30e659208dca3ac07d6c687a407d7aaaf
Reviewed-on: https://go-review.googlesource.com/c/147599
Reviewed-by: Adam Langley <agl@golang.org>
2018-11-05 19:23:25 -05:00
|
|
|
})
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
certMsg := new(certificateMsgTLS13)
|
|
|
|
|
|
|
|
|
|
certMsg.certificate = *cert
|
|
|
|
|
certMsg.scts = hs.certReq.scts && len(cert.SignedCertificateTimestamps) > 0
|
|
|
|
|
certMsg.ocspStapling = hs.certReq.ocspStapling && len(cert.OCSPStaple) > 0
|
|
|
|
|
|
|
|
|
|
hs.transcript.Write(certMsg.marshal())
|
|
|
|
|
if _, err := c.writeRecord(recordTypeHandshake, certMsg.marshal()); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-29 01:38:07 -05:00
|
|
|
// If we sent an empty certificate message, skip the CertificateVerify.
|
crypto/tls: implement TLS 1.3 client authentication
Note that the SignatureSchemes passed to GetClientCertificate in TLS 1.2
are now filtered by the requested certificate type. This feels like an
improvement anyway, and the full list can be surfaced as well when
support for signature_algorithms_cert is added, which actually matches
the semantics of the CertificateRequest signature_algorithms in TLS 1.2.
Also, note a subtle behavior change in server side resumption: if a
certificate is requested but not required, and the resumed session did
not include one, it used not to invoke VerifyPeerCertificate. However,
if the resumed session did include a certificate, it would. (If a
certificate was required but not in the session, the session is rejected
in checkForResumption.) This inconsistency could be unexpected, even
dangerous, so now VerifyPeerCertificate is always invoked. Still not
consistent with the client behavior, which does not ever invoke
VerifyPeerCertificate on resumption, but it felt too surprising to
entirely change either.
Updates #9671
Change-Id: Ib2b0dbc30e659208dca3ac07d6c687a407d7aaaf
Reviewed-on: https://go-review.googlesource.com/c/147599
Reviewed-by: Adam Langley <agl@golang.org>
2018-11-05 19:23:25 -05:00
|
|
|
if len(cert.Certificate) == 0 {
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
certVerifyMsg := new(certificateVerifyMsg)
|
|
|
|
|
certVerifyMsg.hasSignatureAlgorithm = true
|
|
|
|
|
|
crypto/tls: refactor certificate and signature algorithm logic
This refactors a lot of the certificate support logic to make it cleaner
and reusable where possible. These changes will make the following CLs
much simpler.
In particular, the heavily overloaded pickSignatureAlgorithm is gone.
That function used to cover both signing and verifying side, would work
both for pre-signature_algorithms TLS 1.0/1.1 and TLS 1.2, and returned
sigalg, type and hash.
Now, TLS 1.0/1.1 and 1.2 are differentiated at the caller, as they have
effectively completely different logic. TLS 1.0/1.1 simply use
legacyTypeAndHashFromPublicKey as they employ a fixed hash function and
signature algorithm for each public key type. TLS 1.2 is instead routed
through selectSignatureScheme (on the signing side) or
isSupportedSignatureAlgorithm (on the verifying side) and
typeAndHashFromSignatureScheme, like TLS 1.3.
On the signing side, signatureSchemesForCertificate was already version
aware (for PKCS#1 v1.5 vs PSS support), so selectSignatureScheme just
had to learn the Section 7.4.1.4.1 defaults for a missing
signature_algorithms to replace pickSignatureAlgorithm.
On the verifying side, pickSignatureAlgorithm was also checking the
public key type, while isSupportedSignatureAlgorithm +
typeAndHashFromSignatureScheme are not, but that check was redundant
with the one in verifyHandshakeSignature.
There should be no major change in behavior so far. A few minor changes
came from the refactor: we now correctly require signature_algorithms in
TLS 1.3 when using a certificate; we won't use Ed25519 in TLS 1.2 if the
client didn't send signature_algorithms; and we don't send
ec_points_format in the ServerHello (a compatibility measure) if we are
not doing ECDHE anyway because there are no mutually supported curves.
The tests also got simpler because they test simpler functions. The
caller logic switching between TLS 1.0/1.1 and 1.2 is tested by the
transcript tests.
Updates #32426
Change-Id: Ice9dcaea78d204718f661f8d60efdb408ba41577
Reviewed-on: https://go-review.googlesource.com/c/go/+/205061
Reviewed-by: Katie Hockman <katie@golang.org>
2019-11-01 19:00:33 -04:00
|
|
|
certVerifyMsg.signatureAlgorithm, err = selectSignatureScheme(c.vers, cert, hs.certReq.supportedSignatureAlgorithms)
|
|
|
|
|
if err != nil {
|
2018-11-29 01:38:07 -05:00
|
|
|
// getClientCertificate returned a certificate incompatible with the
|
|
|
|
|
// CertificateRequestInfo supported signature algorithms.
|
|
|
|
|
c.sendAlert(alertHandshakeFailure)
|
crypto/tls: refactor certificate and signature algorithm logic
This refactors a lot of the certificate support logic to make it cleaner
and reusable where possible. These changes will make the following CLs
much simpler.
In particular, the heavily overloaded pickSignatureAlgorithm is gone.
That function used to cover both signing and verifying side, would work
both for pre-signature_algorithms TLS 1.0/1.1 and TLS 1.2, and returned
sigalg, type and hash.
Now, TLS 1.0/1.1 and 1.2 are differentiated at the caller, as they have
effectively completely different logic. TLS 1.0/1.1 simply use
legacyTypeAndHashFromPublicKey as they employ a fixed hash function and
signature algorithm for each public key type. TLS 1.2 is instead routed
through selectSignatureScheme (on the signing side) or
isSupportedSignatureAlgorithm (on the verifying side) and
typeAndHashFromSignatureScheme, like TLS 1.3.
On the signing side, signatureSchemesForCertificate was already version
aware (for PKCS#1 v1.5 vs PSS support), so selectSignatureScheme just
had to learn the Section 7.4.1.4.1 defaults for a missing
signature_algorithms to replace pickSignatureAlgorithm.
On the verifying side, pickSignatureAlgorithm was also checking the
public key type, while isSupportedSignatureAlgorithm +
typeAndHashFromSignatureScheme are not, but that check was redundant
with the one in verifyHandshakeSignature.
There should be no major change in behavior so far. A few minor changes
came from the refactor: we now correctly require signature_algorithms in
TLS 1.3 when using a certificate; we won't use Ed25519 in TLS 1.2 if the
client didn't send signature_algorithms; and we don't send
ec_points_format in the ServerHello (a compatibility measure) if we are
not doing ECDHE anyway because there are no mutually supported curves.
The tests also got simpler because they test simpler functions. The
caller logic switching between TLS 1.0/1.1 and 1.2 is tested by the
transcript tests.
Updates #32426
Change-Id: Ice9dcaea78d204718f661f8d60efdb408ba41577
Reviewed-on: https://go-review.googlesource.com/c/go/+/205061
Reviewed-by: Katie Hockman <katie@golang.org>
2019-11-01 19:00:33 -04:00
|
|
|
return err
|
2018-11-29 01:38:07 -05:00
|
|
|
}
|
crypto/tls: implement TLS 1.3 client authentication
Note that the SignatureSchemes passed to GetClientCertificate in TLS 1.2
are now filtered by the requested certificate type. This feels like an
improvement anyway, and the full list can be surfaced as well when
support for signature_algorithms_cert is added, which actually matches
the semantics of the CertificateRequest signature_algorithms in TLS 1.2.
Also, note a subtle behavior change in server side resumption: if a
certificate is requested but not required, and the resumed session did
not include one, it used not to invoke VerifyPeerCertificate. However,
if the resumed session did include a certificate, it would. (If a
certificate was required but not in the session, the session is rejected
in checkForResumption.) This inconsistency could be unexpected, even
dangerous, so now VerifyPeerCertificate is always invoked. Still not
consistent with the client behavior, which does not ever invoke
VerifyPeerCertificate on resumption, but it felt too surprising to
entirely change either.
Updates #9671
Change-Id: Ib2b0dbc30e659208dca3ac07d6c687a407d7aaaf
Reviewed-on: https://go-review.googlesource.com/c/147599
Reviewed-by: Adam Langley <agl@golang.org>
2018-11-05 19:23:25 -05:00
|
|
|
|
2019-10-29 16:46:26 -04:00
|
|
|
sigType, sigHash, err := typeAndHashFromSignatureScheme(certVerifyMsg.signatureAlgorithm)
|
|
|
|
|
if err != nil {
|
2018-11-29 01:38:07 -05:00
|
|
|
return c.sendAlert(alertInternalError)
|
crypto/tls: implement TLS 1.3 client authentication
Note that the SignatureSchemes passed to GetClientCertificate in TLS 1.2
are now filtered by the requested certificate type. This feels like an
improvement anyway, and the full list can be surfaced as well when
support for signature_algorithms_cert is added, which actually matches
the semantics of the CertificateRequest signature_algorithms in TLS 1.2.
Also, note a subtle behavior change in server side resumption: if a
certificate is requested but not required, and the resumed session did
not include one, it used not to invoke VerifyPeerCertificate. However,
if the resumed session did include a certificate, it would. (If a
certificate was required but not in the session, the session is rejected
in checkForResumption.) This inconsistency could be unexpected, even
dangerous, so now VerifyPeerCertificate is always invoked. Still not
consistent with the client behavior, which does not ever invoke
VerifyPeerCertificate on resumption, but it felt too surprising to
entirely change either.
Updates #9671
Change-Id: Ib2b0dbc30e659208dca3ac07d6c687a407d7aaaf
Reviewed-on: https://go-review.googlesource.com/c/147599
Reviewed-by: Adam Langley <agl@golang.org>
2018-11-05 19:23:25 -05:00
|
|
|
}
|
|
|
|
|
|
2019-05-16 19:13:29 -04:00
|
|
|
signed := signedMessage(sigHash, clientSignatureContext, hs.transcript)
|
crypto/tls: implement TLS 1.3 client authentication
Note that the SignatureSchemes passed to GetClientCertificate in TLS 1.2
are now filtered by the requested certificate type. This feels like an
improvement anyway, and the full list can be surfaced as well when
support for signature_algorithms_cert is added, which actually matches
the semantics of the CertificateRequest signature_algorithms in TLS 1.2.
Also, note a subtle behavior change in server side resumption: if a
certificate is requested but not required, and the resumed session did
not include one, it used not to invoke VerifyPeerCertificate. However,
if the resumed session did include a certificate, it would. (If a
certificate was required but not in the session, the session is rejected
in checkForResumption.) This inconsistency could be unexpected, even
dangerous, so now VerifyPeerCertificate is always invoked. Still not
consistent with the client behavior, which does not ever invoke
VerifyPeerCertificate on resumption, but it felt too surprising to
entirely change either.
Updates #9671
Change-Id: Ib2b0dbc30e659208dca3ac07d6c687a407d7aaaf
Reviewed-on: https://go-review.googlesource.com/c/147599
Reviewed-by: Adam Langley <agl@golang.org>
2018-11-05 19:23:25 -05:00
|
|
|
signOpts := crypto.SignerOpts(sigHash)
|
|
|
|
|
if sigType == signatureRSAPSS {
|
|
|
|
|
signOpts = &rsa.PSSOptions{SaltLength: rsa.PSSSaltLengthEqualsHash, Hash: sigHash}
|
|
|
|
|
}
|
2019-05-16 19:13:29 -04:00
|
|
|
sig, err := cert.PrivateKey.(crypto.Signer).Sign(c.config.rand(), signed, signOpts)
|
crypto/tls: implement TLS 1.3 client authentication
Note that the SignatureSchemes passed to GetClientCertificate in TLS 1.2
are now filtered by the requested certificate type. This feels like an
improvement anyway, and the full list can be surfaced as well when
support for signature_algorithms_cert is added, which actually matches
the semantics of the CertificateRequest signature_algorithms in TLS 1.2.
Also, note a subtle behavior change in server side resumption: if a
certificate is requested but not required, and the resumed session did
not include one, it used not to invoke VerifyPeerCertificate. However,
if the resumed session did include a certificate, it would. (If a
certificate was required but not in the session, the session is rejected
in checkForResumption.) This inconsistency could be unexpected, even
dangerous, so now VerifyPeerCertificate is always invoked. Still not
consistent with the client behavior, which does not ever invoke
VerifyPeerCertificate on resumption, but it felt too surprising to
entirely change either.
Updates #9671
Change-Id: Ib2b0dbc30e659208dca3ac07d6c687a407d7aaaf
Reviewed-on: https://go-review.googlesource.com/c/147599
Reviewed-by: Adam Langley <agl@golang.org>
2018-11-05 19:23:25 -05:00
|
|
|
if err != nil {
|
|
|
|
|
c.sendAlert(alertInternalError)
|
|
|
|
|
return errors.New("tls: failed to sign handshake: " + err.Error())
|
|
|
|
|
}
|
|
|
|
|
certVerifyMsg.signature = sig
|
|
|
|
|
|
|
|
|
|
hs.transcript.Write(certVerifyMsg.marshal())
|
|
|
|
|
if _, err := c.writeRecord(recordTypeHandshake, certVerifyMsg.marshal()); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return nil
|
2018-11-01 01:01:09 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (hs *clientHandshakeStateTLS13) sendClientFinished() error {
|
|
|
|
|
c := hs.c
|
|
|
|
|
|
|
|
|
|
finished := &finishedMsg{
|
2018-11-04 18:41:37 -05:00
|
|
|
verifyData: hs.suite.finishedHash(c.out.trafficSecret, hs.transcript),
|
2018-11-01 01:01:09 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
hs.transcript.Write(finished.marshal())
|
|
|
|
|
if _, err := c.writeRecord(recordTypeHandshake, finished.marshal()); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
c.out.setTrafficSecret(hs.suite, hs.trafficSecret)
|
|
|
|
|
|
2018-11-04 18:41:37 -05:00
|
|
|
if !c.config.SessionTicketsDisabled && c.config.ClientSessionCache != nil {
|
|
|
|
|
c.resumptionSecret = hs.suite.deriveSecret(hs.masterSecret,
|
|
|
|
|
resumptionLabel, hs.transcript)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (c *Conn) handleNewSessionTicket(msg *newSessionTicketMsgTLS13) error {
|
|
|
|
|
if !c.isClient {
|
|
|
|
|
c.sendAlert(alertUnexpectedMessage)
|
|
|
|
|
return errors.New("tls: received new session ticket from a client")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if c.config.SessionTicketsDisabled || c.config.ClientSessionCache == nil {
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// See RFC 8446, Section 4.6.1.
|
|
|
|
|
if msg.lifetime == 0 {
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
lifetime := time.Duration(msg.lifetime) * time.Second
|
2018-11-05 15:59:08 -05:00
|
|
|
if lifetime > maxSessionTicketLifetime {
|
2018-11-04 18:41:37 -05:00
|
|
|
c.sendAlert(alertIllegalParameter)
|
|
|
|
|
return errors.New("tls: received a session ticket with invalid lifetime")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
cipherSuite := cipherSuiteTLS13ByID(c.cipherSuite)
|
|
|
|
|
if cipherSuite == nil || c.resumptionSecret == nil {
|
|
|
|
|
return c.sendAlert(alertInternalError)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Save the resumption_master_secret and nonce instead of deriving the PSK
|
|
|
|
|
// to do the least amount of work on NewSessionTicket messages before we
|
|
|
|
|
// know if the ticket will be used. Forward secrecy of resumed connections
|
|
|
|
|
// is guaranteed by the requirement for pskModeDHE.
|
|
|
|
|
session := &ClientSessionState{
|
|
|
|
|
sessionTicket: msg.label,
|
|
|
|
|
vers: c.vers,
|
|
|
|
|
cipherSuite: c.cipherSuite,
|
|
|
|
|
masterSecret: c.resumptionSecret,
|
|
|
|
|
serverCertificates: c.peerCertificates,
|
|
|
|
|
verifiedChains: c.verifiedChains,
|
|
|
|
|
receivedAt: c.config.time(),
|
|
|
|
|
nonce: msg.nonce,
|
|
|
|
|
useBy: c.config.time().Add(lifetime),
|
|
|
|
|
ageAdd: msg.ageAdd,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
cacheKey := clientSessionCacheKey(c.conn.RemoteAddr(), c.config)
|
|
|
|
|
c.config.ClientSessionCache.Put(cacheKey, session)
|
|
|
|
|
|
2018-11-01 01:01:09 -04:00
|
|
|
return nil
|
|
|
|
|
}
|