Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

[dev.cc] cmd/asm: fix the expression parser and add tests

Browse source 
Rewrite the grammar to have one more production so it parses
	~0*0
correctly and write tests to prove it.

Change-Id: I0dd652baf65b48a3f26c9287c420702db4eaec59
Reviewed-on: https://go-review.googlesource.com/3443
Reviewed-by: Russ Cox <rsc@golang.org>
This commit is contained in:
Rob Pike 2015-01-28 11:11:33 -08:00
parent ad82238653
commit 0012b83507
4 changed files with 132 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/cmd/asm/internal/lex/input.go
View file

@ -46,7 +46,7 @@ func predefine(defines flags.MultiFlag) map[string]*Macro {
if i > 0 {
name, value = name[:i], name[i+1:]
}
tokens := tokenize(name)
tokens := Tokenize(name)
if len(tokens) != 1 || tokens[0].ScanToken != scanner.Ident {
fmt.Fprintf(os.Stderr, "asm: parsing -D: %q is not a valid identifier name\n", tokens[0])
flags.Usage()
@ -54,7 +54,7 @@ func predefine(defines flags.MultiFlag) map[string]*Macro {
macros[name] = &Macro{
name: name,
args: nil,
tokens: tokenize(value),
tokens: Tokenize(value),
}
}
return macros