Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

rpc: clean up dregs from June 2010

Browse source 
In June 2010 I accidentally checked in pending
changes to package rpc in a compiler CL:
https://golang.org/cl/1736041

I backed them out by hand in a followup CL:
https://golang.org/cl/1736042

That followup CL missed the lines being deleted
in this CL, spotted by Petar.

hg diff -r 5678:5683 src/cmd/prof/gopprof \
        src/pkg/image/png/reader.go \
        src/pkg/rpc/client.go \
        src/pkg/rpc/jsonrpc/all_test.go \
        src/pkg/rpc/jsonrpc/server.go \
        src/pkg/rpc/server.go \
        test/arm-pass.txt

confirms that these lines in server.go are the
only ones that were missed by the original followup.

Fixes #1583.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4266046
This commit is contained in:
Russ Cox 2011-03-07 12:09:00 -05:00
parent ff40deee62
commit 02323c0e21
1 changed files with 0 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/pkg/rpc/server.go
View file

@ -166,12 +166,6 @@ type Response struct {
Error string // error, if any. Error string // error, if any.
} }
// ClientInfo records information about an RPC client connection.
type ClientInfo struct {
LocalAddr string
RemoteAddr string
}
// Server represents an RPC Server. // Server represents an RPC Server.
type Server struct { type Server struct {
sync.Mutex // protects the serviceMap sync.Mutex // protects the serviceMap
@ -269,13 +263,6 @@ func (server *Server) register(rcvr interface{}, name string, useName bool) os.E
log.Println(mname, "reply type not exported:", replyType) log.Println(mname, "reply type not exported:", replyType)
continue continue
} }
if mtype.NumIn() == 4 {
t := mtype.In(3)
if t != reflect.Typeof((*ClientInfo)(nil)) {
log.Println(mname, "last argument not *ClientInfo")
continue
}
}
// Method needs one out: os.Error. // Method needs one out: os.Error.
if mtype.NumOut() != 1 { if mtype.NumOut() != 1 {
log.Println("method", mname, "has wrong number of outs:", mtype.NumOut()) log.Println("method", mname, "has wrong number of outs:", mtype.NumOut())