mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
http: remove finalURL from Client.Get; move to Response
This CL:
-- removes Response.RequestMethod string
-- adds Response.Request *Request
-- removes the finalURL result parameter from client.Get()
-- adds a gofix rule for callers of http.Get which assign
the final url to the blank identifier; warning otherwise
Caller who did:
res, finalURL, err := http.Get(...)
now need to do:
res, err := http.Get(...)
if err != nil {
...
}
finalURL := res.Request.URL.String()
R=rsc
CC=golang-dev
https://golang.org/cl/4535056
This commit is contained in:
parent
4336116d3b
commit
05a1b7ec41
22 changed files with 203 additions and 100 deletions
|
|
@ -33,7 +33,7 @@ func TestReverseProxy(t *testing.T) {
|
|||
frontend := httptest.NewServer(proxyHandler)
|
||||
defer frontend.Close()
|
||||
|
||||
res, _, err := Get(frontend.URL)
|
||||
res, err := Get(frontend.URL)
|
||||
if err != nil {
|
||||
t.Fatalf("Get: %v", err)
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue