http: remove finalURL from Client.Get; move to Response

This CL:

-- removes Response.RequestMethod string
-- adds Response.Request *Request
-- removes the finalURL result parameter from client.Get()
-- adds a gofix rule for callers of http.Get which assign
   the final url to the blank identifier; warning otherwise

Caller who did:

res, finalURL, err := http.Get(...)

now need to do:

res, err := http.Get(...)
if err != nil {
   ...
}
finalURL := res.Request.URL.String()

R=rsc
CC=golang-dev
https://golang.org/cl/4535056
This commit is contained in:
Brad Fitzpatrick 2011-05-13 07:31:24 -07:00
parent 4336116d3b
commit 05a1b7ec41
22 changed files with 203 additions and 100 deletions

View file

@ -33,7 +33,7 @@ func TestReverseProxy(t *testing.T) {
frontend := httptest.NewServer(proxyHandler)
defer frontend.Close()
res, _, err := Get(frontend.URL)
res, err := Get(frontend.URL)
if err != nil {
t.Fatalf("Get: %v", err)
}