Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

net: disable TestDialTimeout on Windows

Browse source 
Filed issue 3016 to fix this, but I really want
to see a "ok" in the Windows column so we
know what is and is not working.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5658050
This commit is contained in:
Russ Cox 2012-02-13 23:30:40 -05:00
parent c2a1157680
commit 0603b9e446
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/pkg/net/dial_test.go
View file

@ -42,7 +42,7 @@ func TestDialTimeout(t *testing.T) {
errc <- err errc <- err
}() }()
} }
case "darwin", "windows": case "darwin":
// At least OS X 10.7 seems to accept any number of // At least OS X 10.7 seems to accept any number of
// connections, ignoring listen's backlog, so resort // connections, ignoring listen's backlog, so resort
// to connecting to a hopefully-dead 127/8 address. // to connecting to a hopefully-dead 127/8 address.
@ -55,6 +55,8 @@ func TestDialTimeout(t *testing.T) {
// TODO(bradfitz): // TODO(bradfitz):
// OpenBSD may have a reject route to 127/8 except 127.0.0.1/32 // OpenBSD may have a reject route to 127/8 except 127.0.0.1/32
// by default. FreeBSD likely works, but is untested. // by default. FreeBSD likely works, but is untested.
// TODO(rsc):
// The timeout never happens on Windows. Why? Issue 3016.
t.Logf("skipping test on %q; untested.", runtime.GOOS) t.Logf("skipping test on %q; untested.", runtime.GOOS)
return return
} }