Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

[release-branch.go1.9] cmd/go: clean up x.exe properly in TestImportMain

Browse source 
More generally I'm concerned about these tests using
$GOROOT/src/cmd/go as scratch space, especially
combined wtih tg.parallel() - it's easy to believe some other
test might inadvertently also try to write x.exe about the
same time. This CL only solves the "didn't clean up x.exe"
problem and leaves for another day the "probably shouldn't
write to cmd/go at all" problem.

Fixes #22266.

Change-Id: I651534d70e2d360138e0373fb4a316081872550b
Reviewed-on: https://go-review.googlesource.com/71410
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-on: https://go-review.googlesource.com/71530
This commit is contained in:
Russ Cox 2017-10-17 15:10:59 -04:00
parent d487b15a61
commit 0758d2b9da
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/go/go_test.go
View file

@ -2847,7 +2847,7 @@ func TestImportMain(t *testing.T) {
func TestFoo(t *testing.T) {} func TestFoo(t *testing.T) {}
`) `)
tg.setenv("GOPATH", tg.path(".")) tg.setenv("GOPATH", tg.path("."))
tg.creatingTemp("x") tg.creatingTemp("x" + exeSuffix)
tg.run("build", "x") tg.run("build", "x")
tg.run("test", "x") tg.run("test", "x")