Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: remove ODDDARG

Browse source 
No longer needed after the last CL. Separate commit because
renumbering Ops causes toolstash to complain.

Change-Id: I6223a790cc341f8184eccb503f95a1dfc32a81e4
Reviewed-on: https://go-review.googlesource.com/c/go/+/229760
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Matthew Dempsky 2020-04-23 11:37:33 -07:00
parent a44d06d3b4
commit 080a3ee8b2
5 changed files with 19 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/cmd/compile/internal/gc/fmt.go
View file

@ -1306,9 +1306,6 @@ func (n *Node) exprfmt(s fmt.State, prec int, mode fmtMode) {
case OPAREN: case OPAREN:
mode.Fprintf(s, "(%v)", n.Left) mode.Fprintf(s, "(%v)", n.Left)
case ODDDARG:
fmt.Fprint(s, "... argument")
case OLITERAL: // this is a bit of a mess case OLITERAL: // this is a bit of a mess
if mode == FErr { if mode == FErr {
if n.Orig != nil && n.Orig != n { if n.Orig != nil && n.Orig != n {

3
src/cmd/compile/internal/gc/iimport.go
View file

@ -790,9 +790,6 @@ func (r *importReader) node() *Node {
// case OPAREN: // case OPAREN:
// unreachable - unpacked by exporter // unreachable - unpacked by exporter
// case ODDDARG:
// unimplemented
case OLITERAL: case OLITERAL:
pos := r.pos() pos := r.pos()
typ, val := r.value() typ, val := r.value()

39
src/cmd/compile/internal/gc/op_string.go
View file

@ -1,4 +1,4 @@
// Code generated by "stringer -type Op -trimprefix O"; DO NOT EDIT. // Code generated by "stringer -type=Op -trimprefix=O"; DO NOT EDIT.
package gc package gc
@ -144,28 +144,27 @@ func _() {
_ = x[OTFUNC-133] _ = x[OTFUNC-133]
_ = x[OTARRAY-134] _ = x[OTARRAY-134]
_ = x[ODDD-135] _ = x[ODDD-135]
_ = x[ODDDARG-136] _ = x[OINLCALL-136]
_ = x[OINLCALL-137] _ = x[OEFACE-137]
_ = x[OEFACE-138] _ = x[OITAB-138]
_ = x[OITAB-139] _ = x[OIDATA-139]
_ = x[OIDATA-140] _ = x[OSPTR-140]
_ = x[OSPTR-141] _ = x[OCLOSUREVAR-141]
_ = x[OCLOSUREVAR-142] _ = x[OCFUNC-142]
_ = x[OCFUNC-143] _ = x[OCHECKNIL-143]
_ = x[OCHECKNIL-144] _ = x[OVARDEF-144]
_ = x[OVARDEF-145] _ = x[OVARKILL-145]
_ = x[OVARKILL-146] _ = x[OVARLIVE-146]
_ = x[OVARLIVE-147] _ = x[ORESULT-147]
_ = x[ORESULT-148] _ = x[OINLMARK-148]
_ = x[OINLMARK-149] _ = x[ORETJMP-149]
_ = x[ORETJMP-150] _ = x[OGETG-150]
_ = x[OGETG-151] _ = x[OEND-151]
_ = x[OEND-152]
} }
const _Op_name = "XXXNAMENONAMETYPEPACKLITERALADDSUBORXORADDSTRADDRANDANDAPPENDBYTES2STRBYTES2STRTMPRUNES2STRSTR2BYTESSTR2BYTESTMPSTR2RUNESASAS2AS2DOTTYPEAS2FUNCAS2MAPRAS2RECVASOPCALLCALLFUNCCALLMETHCALLINTERCALLPARTCAPCLOSECLOSURECOMPLITMAPLITSTRUCTLITARRAYLITSLICELITPTRLITCONVCONVIFACECONVNOPCOPYDCLDCLFUNCDCLFIELDDCLCONSTDCLTYPEDELETEDOTDOTPTRDOTMETHDOTINTERXDOTDOTTYPEDOTTYPE2EQNELTLEGEGTDEREFINDEXINDEXMAPKEYSTRUCTKEYLENMAKEMAKECHANMAKEMAPMAKESLICEMULDIVMODLSHRSHANDANDNOTNEWNEWOBJNOTBITNOTPLUSNEGORORPANICPRINTPRINTNPARENSENDSLICESLICEARRSLICESTRSLICE3SLICE3ARRSLICEHEADERRECOVERRECVRUNESTRSELRECVSELRECV2IOTAREALIMAGCOMPLEXALIGNOFOFFSETOFSIZEOFBLOCKBREAKCASECONTINUEDEFEREMPTYFALLFORFORUNTILGOTOIFLABELGORANGERETURNSELECTSWITCHTYPESWTCHANTMAPTSTRUCTTINTERTFUNCTARRAYDDDDDDARGINLCALLEFACEITABIDATASPTRCLOSUREVARCFUNCCHECKNILVARDEFVARKILLVARLIVERESULTINLMARKRETJMPGETGEND" const _Op_name = "XXXNAMENONAMETYPEPACKLITERALADDSUBORXORADDSTRADDRANDANDAPPENDBYTES2STRBYTES2STRTMPRUNES2STRSTR2BYTESSTR2BYTESTMPSTR2RUNESASAS2AS2DOTTYPEAS2FUNCAS2MAPRAS2RECVASOPCALLCALLFUNCCALLMETHCALLINTERCALLPARTCAPCLOSECLOSURECOMPLITMAPLITSTRUCTLITARRAYLITSLICELITPTRLITCONVCONVIFACECONVNOPCOPYDCLDCLFUNCDCLFIELDDCLCONSTDCLTYPEDELETEDOTDOTPTRDOTMETHDOTINTERXDOTDOTTYPEDOTTYPE2EQNELTLEGEGTDEREFINDEXINDEXMAPKEYSTRUCTKEYLENMAKEMAKECHANMAKEMAPMAKESLICEMULDIVMODLSHRSHANDANDNOTNEWNEWOBJNOTBITNOTPLUSNEGORORPANICPRINTPRINTNPARENSENDSLICESLICEARRSLICESTRSLICE3SLICE3ARRSLICEHEADERRECOVERRECVRUNESTRSELRECVSELRECV2IOTAREALIMAGCOMPLEXALIGNOFOFFSETOFSIZEOFBLOCKBREAKCASECONTINUEDEFEREMPTYFALLFORFORUNTILGOTOIFLABELGORANGERETURNSELECTSWITCHTYPESWTCHANTMAPTSTRUCTTINTERTFUNCTARRAYDDDINLCALLEFACEITABIDATASPTRCLOSUREVARCFUNCCHECKNILVARDEFVARKILLVARLIVERESULTINLMARKRETJMPGETGEND"
var _Op_index = [...]uint16{0, 3, 7, 13, 17, 21, 28, 31, 34, 36, 39, 45, 49, 55, 61, 70, 82, 91, 100, 112, 121, 123, 126, 136, 143, 150, 157, 161, 165, 173, 181, 190, 198, 201, 206, 213, 220, 226, 235, 243, 251, 257, 261, 270, 277, 281, 284, 291, 299, 307, 314, 320, 323, 329, 336, 344, 348, 355, 363, 365, 367, 369, 371, 373, 375, 380, 385, 393, 396, 405, 408, 412, 420, 427, 436, 439, 442, 445, 448, 451, 454, 460, 463, 469, 472, 478, 482, 485, 489, 494, 499, 505, 510, 514, 519, 527, 535, 541, 550, 561, 568, 572, 579, 586, 594, 598, 602, 606, 613, 620, 628, 634, 639, 644, 648, 656, 661, 666, 670, 673, 681, 685, 687, 692, 694, 699, 705, 711, 717, 723, 728, 732, 739, 745, 750, 756, 759, 765, 772, 777, 781, 786, 790, 800, 805, 813, 819, 826, 833, 839, 846, 852, 856, 859} var _Op_index = [...]uint16{0, 3, 7, 13, 17, 21, 28, 31, 34, 36, 39, 45, 49, 55, 61, 70, 82, 91, 100, 112, 121, 123, 126, 136, 143, 150, 157, 161, 165, 173, 181, 190, 198, 201, 206, 213, 220, 226, 235, 243, 251, 257, 261, 270, 277, 281, 284, 291, 299, 307, 314, 320, 323, 329, 336, 344, 348, 355, 363, 365, 367, 369, 371, 373, 375, 380, 385, 393, 396, 405, 408, 412, 420, 427, 436, 439, 442, 445, 448, 451, 454, 460, 463, 469, 472, 478, 482, 485, 489, 494, 499, 505, 510, 514, 519, 527, 535, 541, 550, 561, 568, 572, 579, 586, 594, 598, 602, 606, 613, 620, 628, 634, 639, 644, 648, 656, 661, 666, 670, 673, 681, 685, 687, 692, 694, 699, 705, 711, 717, 723, 728, 732, 739, 745, 750, 756, 759, 766, 771, 775, 780, 784, 794, 799, 807, 813, 820, 827, 833, 840, 846, 850, 853}
func (i Op) String() string { func (i Op) String() string {
if i >= Op(len(_Op_index)-1) { if i >= Op(len(_Op_index)-1) {

3
src/cmd/compile/internal/gc/order.go
View file

@ -1216,9 +1216,6 @@ func (o *Order) expr(n, lhs *Node) *Node {
prealloc[n] = o.newTemp(t, false) prealloc[n] = o.newTemp(t, false)
} }
case ODDDARG:
Fatalf("unreachable")
case ODOTTYPE, ODOTTYPE2: case ODOTTYPE, ODOTTYPE2:
n.Left = o.expr(n.Left, nil) n.Left = o.expr(n.Left, nil)
if !isdirectiface(n.Type) || instrumenting { if !isdirectiface(n.Type) || instrumenting {

1
src/cmd/compile/internal/gc/syntax.go
View file

@ -815,7 +815,6 @@ const (
// misc // misc
ODDD // func f(args ...int) or f(l...) or var a = [...]int{0, 1, 2}. ODDD // func f(args ...int) or f(l...) or var a = [...]int{0, 1, 2}.
ODDDARG // func f(args ...int), introduced by escape analysis.
OINLCALL // intermediary representation of an inlined call. OINLCALL // intermediary representation of an inlined call.
OEFACE // itable and data words of an empty-interface value. OEFACE // itable and data words of an empty-interface value.
OITAB // itable word of an interface value. OITAB // itable word of an interface value.