Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

os: add TODO about removing test exception

Browse source 
TestChtimesOmit excludes the failure on DragonFly BSD when both
atime and mtime are omitted.

The relevant Dragonfly BSD bug is now fixed in git (see [1]).

Add a TODO comment to remove the exclusion from the test once
the fix is generally available. This comment also addresses the
question why the exception exists.

Amends CL 591535.

[1]: c7c71870ed

Change-Id: I3b53582301d44feb76b53788aa337c380ba82592
Reviewed-on: https://go-review.googlesource.com/c/go/+/595958
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Than McIntosh <thanm@google.com>
This commit is contained in:
Kir Kolyshkin 2024-07-01 12:41:56 -07:00 • committed by Gopher Robot
parent 94982a0782
commit 09aeb6e33a
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/os/os_test.go
View file

@ -1440,6 +1440,9 @@ func testChtimesOmit(t *testing.T, omitAt, omitMt bool) {
gotAtime := Atime(fs)
gotMtime := fs.ModTime()
// TODO: remove the dragonfly omitAt && omitMt exceptions below once the
// fix (https://github.com/DragonFlyBSD/DragonFlyBSD/commit/c7c71870ed0)
// is available generally and on CI runners.
if !gotAtime.Equal(wantAtime) {
errormsg := fmt.Sprintf("atime mismatch, got: %q, want: %q", gotAtime, wantAtime)
switch runtime.GOOS {