Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/cgo: enforce typing of 0-sized types

Browse source 
cgo represents all 0-sized and unsized types internally as [0]byte. This means that pointers to incomplete types would be interchangable, even if given a name by typedef.

Fixes #7409.

LGTM=iant
R=golang-codereviews, bradfitz, iant
CC=golang-codereviews
https://golang.org/cl/76450043
This commit is contained in:
Daniel Morsing 2014-03-27 20:23:16 +00:00
parent 444dd26bf4
commit 0f82cfd3f0
3 changed files with 24 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/cmd/cgo/gcc.go
View file

@ -1327,9 +1327,12 @@ func (c *typeConv) Type(dtype dwarf.Type, pos token.Pos) *Type {
// be correct, so calling dtype.Size again will produce the correct value.
t.Size = dtype.Size()
if t.Size < 0 {
// Unsized types are [0]byte
// Unsized types are [0]byte, unless they're typedefs of other types.
// if so, use the name of the typedef for the go name.
t.Size = 0
t.Go = c.Opaque(0)
if _, ok := dtype.(*dwarf.TypedefType); !ok {
t.Go = c.Opaque(0)
}
if t.C.Empty() {
t.C.Set("void")
}