Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

[dev.typeparams] cmd/compile: use dictionary to convert arguments of ==, != to interfaces

Browse source 
When comparing a value whose type is a type parameter to an interface,
we need to convert that type parameter to an interface using the dictionary
entries.

Change-Id: I409c9e36e376fe4ef8163407d0fd4e84496d5b65
Reviewed-on: https://go-review.googlesource.com/c/go/+/334150
Trust: Keith Randall <khr@golang.org>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
This commit is contained in:
Keith Randall 2021-07-12 16:12:55 -07:00
parent ed9e109dc9
commit 10c8b7c1d7
2 changed files with 86 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/cmd/compile/internal/noder/stencil.go
View file

@ -1242,6 +1242,21 @@ func (subst *subster) node(n ir.Node) ir.Node {
if ix := subst.findDictType(t); ix >= 0 {
m = subst.convertUsingDictionary(x.Pos(), m.(*ir.ConvExpr).X, m.Type(), t, ix)
}
case ir.OEQ, ir.ONE:
// Equality between a non-interface and an interface requires the non-interface
// to be promoted to an interface.
x := x.(*ir.BinaryExpr)
m := m.(*ir.BinaryExpr)
if i := x.Y.Type(); i.IsInterface() {
if ix := subst.findDictType(x.X.Type()); ix >= 0 {
m.X = subst.convertUsingDictionary(m.X.Pos(), m.X, i, x.X.Type(), ix)
}
}
if i := x.X.Type(); i.IsInterface() {
if ix := subst.findDictType(x.Y.Type()); ix >= 0 {
m.Y = subst.convertUsingDictionary(m.Y.Pos(), m.Y, i, x.X.Type(), ix)
}
}
}
return m
}