Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

Revert "encoding/json: implement Is on all errors"

Browse source 
This reverts CL 254537.

Reason for revert: Reason for revert: The recommended way to check for a type of error is errors.As. API changes should also start with a proposal.

Change-Id: I07c37428575e99c80b17525833a61831d10963bb
Reviewed-on: https://go-review.googlesource.com/c/go/+/254857
Trust: Damien Neil <dneil@google.com>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
This commit is contained in:
Damien Neil 2020-09-14 21:00:52 +00:00
parent a408139bb0
commit 114719e16e
4 changed files with 1 additions and 84 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/encoding/json/decode.go
View file

@ -136,12 +136,6 @@ func (e *UnmarshalTypeError) Error() string {
return "json: cannot unmarshal " + e.Value + " into Go value of type " + e.Type.String()
}
// Is returns true if target is a UnmarshalTypeError.
func (e *UnmarshalTypeError) Is(target error) bool {
_, ok := target.(*UnmarshalTypeError)
return ok
}
// An UnmarshalFieldError describes a JSON object key that
// led to an unexported (and therefore unwritable) struct field.
//
@ -156,24 +150,12 @@ func (e *UnmarshalFieldError) Error() string {
return "json: cannot unmarshal object key " + strconv.Quote(e.Key) + " into unexported field " + e.Field.Name + " of type " + e.Type.String()
}
// Is returns true if target is a UnmarshalFieldError.
func (e *UnmarshalFieldError) Is(target error) bool {
_, ok := target.(*UnmarshalFieldError)
return ok
}
// An InvalidUnmarshalError describes an invalid argument passed to Unmarshal.
// (The argument to Unmarshal must be a non-nil pointer.)
type InvalidUnmarshalError struct {
Type reflect.Type
}
// Is returns true if target is a InvalidUnmarshalError.
func (e *InvalidUnmarshalError) Is(target error) bool {
_, ok := target.(*InvalidUnmarshalError)
return ok
}
func (e *InvalidUnmarshalError) Error() string {
if e.Type == nil {
return "json: Unmarshal(nil)"