mirror of
				https://github.com/golang/go.git
				synced 2025-11-04 02:30:57 +00:00 
			
		
		
		
	net/http: improve speed of default mux
The DefaultServeMux included in net/http uses a map to store routes, but iterates all keys for every request to allow longer paths. This change checks the map for an exact match first. To check performance was better, BenchmarkServeMux has been added - this adds >100 routes and checks the matches. Exact matches are faster and more predictable on this benchmark and on most existing package benchmarks. https://perf.golang.org/search?q=upload:20170312.1 ServeMux-4 2.02ms ± 2% 0.04ms ± 2% −98.08% (p=0.004 n=5+6) https://perf.golang.org/search?q=upload:20170312.2 ReadRequestChrome-4 184MB/s ± 8% 186MB/s ± 1% ~ ReadRequestCurl-4 45.0MB/s ± 1% 46.2MB/s ± 1% +2.71% Read...Apachebench-4 45.8MB/s ±13% 48.7MB/s ± 1% ~ ReadRequestSiege-4 63.6MB/s ± 5% 69.2MB/s ± 1% +8.75% ReadRequestWrk-4 30.9MB/s ± 9% 34.4MB/s ± 2% +11.25% Change-Id: I8afafcb956f07197419d545a9f1c03ecaa307384 Reviewed-on: https://go-review.googlesource.com/38057 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
		
							parent
							
								
									b5f81eae17
								
							
						
					
					
						commit
						1295b745d1
					
				
					 2 changed files with 50 additions and 2 deletions
				
			
		| 
						 | 
				
			
			@ -2167,9 +2167,16 @@ func cleanPath(p string) string {
 | 
			
		|||
	return np
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
// Find a handler on a handler map given a path string
 | 
			
		||||
// Most-specific (longest) pattern wins
 | 
			
		||||
// Find a handler on a handler map given a path string.
 | 
			
		||||
// Most-specific (longest) pattern wins.
 | 
			
		||||
func (mux *ServeMux) match(path string) (h Handler, pattern string) {
 | 
			
		||||
	// Check for exact match first.
 | 
			
		||||
	v, ok := mux.m[path]
 | 
			
		||||
	if ok {
 | 
			
		||||
		return v.h, v.pattern
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	// Check for longest valid match.
 | 
			
		||||
	var n = 0
 | 
			
		||||
	for k, v := range mux.m {
 | 
			
		||||
		if !pathMatch(k, path) {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue