From 12c8d14d947ba922e19e3360ce5decd2bb848257 Mon Sep 17 00:00:00 2001 From: Damien Neil Date: Mon, 27 Oct 2025 12:27:12 -0700 Subject: [PATCH] errors: document that the target of Is must be comparable If target is not comparable, then errors.Is(err, target) can panic. (Put another way, if target == target panics, then Is can panic.) Document that the target must be comparable. For #74488 Change-Id: I694dc4c91a608b80f044f06dd1c6ac32b8e77c9c Reviewed-on: https://go-review.googlesource.com/c/go/+/715440 Reviewed-by: Alan Donovan Auto-Submit: Damien Neil TryBot-Bypass: Damien Neil --- src/errors/wrap.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/errors/wrap.go b/src/errors/wrap.go index 2ebb951f1de..e4a5ca33d5e 100644 --- a/src/errors/wrap.go +++ b/src/errors/wrap.go @@ -25,6 +25,7 @@ func Unwrap(err error) error { } // Is reports whether any error in err's tree matches target. +// The target must be comparable. // // The tree consists of err itself, followed by the errors obtained by repeatedly // calling its Unwrap() error or Unwrap() []error method. When err wraps multiple