Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: call missing popdcl in various genxxx functions

Browse source 
Not calling popdcl doesn't have an impact on generated code but
the result is a growing (rather than empty) stack of symbols,
possibly causing more data to remain alive than necessary.

Also: minor cleanups.

Change-Id: Ic4fdbcd8843637d69ab1aa15e896a7e6339bc990
Reviewed-on: https://go-review.googlesource.com/20554
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Robert Griesemer <gri@golang.org>
This commit is contained in:
Robert Griesemer 2016-03-10 15:07:08 -08:00
parent 88a21ebb21
commit 157f069873
4 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/cmd/compile/internal/gc/parser.go
View file

@ -2142,8 +2142,8 @@ func (p *parser) structdcl() []*Node {
typ := p.ntype()
tag := p.oliteral()
if l := fields; len(l) == 0 || l[0].Sym.Name == "?" {
// ? symbol, during import (list1(nil) == nil)
if len(fields) == 0 || fields[0].Sym.Name == "?" {
// ? symbol, during import
n := typ
if n.Op == OIND {
n = n.Left