Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: don't discard inlineable but empty functions with binary export format

Browse source 
Change-Id: I0f016fa000f949d27847d645b4cdebe68a8abf20
Reviewed-on: https://go-review.googlesource.com/22474
Run-TryBot: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Robert Griesemer 2016-04-26 14:11:38 -07:00
parent 3a72d626a8
commit 17db07f9b5
1 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/cmd/compile/internal/gc/bimport.go
View file

@ -145,7 +145,16 @@ func Import(in *bufio.Reader) {
if f := p.funcList[i]; f != nil {
// function not yet imported - read body and set it
funchdr(f)
f.Func.Inl.Set(p.stmtList())
body := p.stmtList()
if body == nil {
// Make sure empty body is not interpreted as
// no inlineable body (see also parser.fnbody)
// (not doing so can cause significant performance
// degradation due to unnecessary calls to empty
// functions).
body = []*Node{Nod(OEMPTY, nil, nil)}
}
f.Func.Inl.Set(body)
funcbody(f)
} else {
// function already imported - read body but discard declarations