Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: stenciled conversions might be NOPs

Browse source 
A generic conversion might be required for when converting T->interface{}.
When stenciled with T=interface{}, then that conversion doesn't need
to do anything.

Fixes #48276

Change-Id: Ife65d01c99fbd0895cb7eec79df9e93e752b1fa5
Reviewed-on: https://go-review.googlesource.com/c/go/+/348736
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
This commit is contained in:
Keith Randall 2021-09-09 08:09:57 -07:00
parent a295b3cec8
commit 19457a58e5
4 changed files with 41 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/cmd/compile/internal/noder/stencil.go
View file

@ -1177,6 +1177,12 @@ func (subst *subster) node(n ir.Node) ir.Node {
case ir.OCONVIFACE:
x := x.(*ir.ConvExpr)
if m.Type().IsEmptyInterface() && m.(*ir.ConvExpr).X.Type().IsEmptyInterface() {
// Was T->interface{}, after stenciling it is now interface{}->interface{}.
// No longer need the conversion. See issue 48276.
m.(*ir.ConvExpr).SetOp(ir.OCONVNOP)
break
}
// Note: x's argument is still typed as a type parameter.
// m's argument now has an instantiated type.
if x.X.Type().HasTParam() || (x.X.Type().IsInterface() && x.Type().HasTParam()) {