mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
database/sql: close driver.Connector if it implements io.Closer
This change allows driver implementations to manage resources in
driver.Connector, e.g. to share the same underlying database handle
between multiple connections. That is, it allows embedded databases
with in-memory backends like SQLite and Genji to safely release the
resources once the sql.DB is closed.
This makes it possible to address oddities with in-memory stores in
SQLite and Genji drivers without introducing too much complexity in
the driver implementations.
See also:
- https://github.com/mattn/go-sqlite3/issues/204
- https://github.com/mattn/go-sqlite3/issues/511
- https://github.com/genjidb/genji/issues/210
Fixes #41790
Change-Id: Idbd19763134438ed38288b9d44f16608e4e97fd7
GitHub-Last-Rev: 962c785dfb
GitHub-Pull-Request: golang/go#41710
Reviewed-on: https://go-review.googlesource.com/c/go/+/258360
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Daniel Theophanes <kardianos@gmail.com>
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Go Bot <gobot@golang.org>
This commit is contained in:
parent
4ebb6f5110
commit
194b636f8f
4 changed files with 28 additions and 1 deletions
|
|
@ -4059,9 +4059,18 @@ func TestOpenConnector(t *testing.T) {
|
|||
}
|
||||
defer db.Close()
|
||||
|
||||
if _, is := db.connector.(*fakeConnector); !is {
|
||||
c, ok := db.connector.(*fakeConnector)
|
||||
if !ok {
|
||||
t.Fatal("not using *fakeConnector")
|
||||
}
|
||||
|
||||
if err := db.Close(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
if !c.closed {
|
||||
t.Fatal("connector is not closed")
|
||||
}
|
||||
}
|
||||
|
||||
type ctxOnlyDriver struct {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue