internal/coverage: minor code cleanups

Delete some unused code, various cleanups to fix staticcheck warnings.

Change-Id: Ie475d57735a83351a4977f0dd4bc1387ce06a20e
Reviewed-on: https://go-review.googlesource.com/c/go/+/441935
Reviewed-by: David Chase <drchase@google.com>
This commit is contained in:
Than McIntosh 2022-10-10 14:45:12 -04:00
parent 4274ffd4b8
commit 1b316e3571
9 changed files with 42 additions and 44 deletions

View file

@ -91,7 +91,12 @@ func TestCounterDataWriterReader(t *testing.T) {
// Decode the same file.
var cdr *decodecounter.CounterDataReader
inf, err := os.Open(cfpath)
defer inf.Close()
defer func() {
if err := inf.Close(); err != nil {
t.Fatalf("close failed with: %v", err)
}
}()
if err != nil {
t.Fatalf("reopening covcounters file: %v", err)
}
@ -182,7 +187,12 @@ func TestCounterDataAppendSegment(t *testing.T) {
// Read the result file.
var cdr *decodecounter.CounterDataReader
inf, err := os.Open(cfpath)
defer inf.Close()
defer func() {
if err := inf.Close(); err != nil {
t.Fatalf("close failed with: %v", err)
}
}()
if err != nil {
t.Fatalf("reopening covcounters file: %v", err)
}