Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

all: fix a few more printf arg bugs found by go vet

Browse source 
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/7413045
This commit is contained in:
Rob Pike 2013-02-28 11:33:08 -08:00
parent 3dc7f17e89
commit 1bf66f081f
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/pkg/math/big/rat_test.go
View file

@ -753,7 +753,7 @@ func TestFloat64SpecialCases(t *testing.T) {
// 4. Check exactness using slow algorithm. // 4. Check exactness using slow algorithm.
if wasExact := new(Rat).SetFloat64(f).Cmp(r) == 0; wasExact != exact { if wasExact := new(Rat).SetFloat64(f).Cmp(r) == 0; wasExact != exact {
t.Errorf("Rat.SetString(%q).Float64().exact = %b, want %b", input, exact, wasExact) t.Errorf("Rat.SetString(%q).Float64().exact = %t, want %t", input, exact, wasExact)
} }
} }
} }

6
src/pkg/reflect/set_test.go
View file

@ -81,7 +81,7 @@ func TestImplicitMapConversion(t *testing.T) {
t.Errorf("#5 after SetMapIndex(b1, b2): %p (!= %p), %t (map=%v)", x, b2, ok, m) t.Errorf("#5 after SetMapIndex(b1, b2): %p (!= %p), %t (map=%v)", x, b2, ok, m)
} }
if p := mv.MapIndex(ValueOf(b1)).Elem().Pointer(); p != uintptr(unsafe.Pointer(b2)) { if p := mv.MapIndex(ValueOf(b1)).Elem().Pointer(); p != uintptr(unsafe.Pointer(b2)) {
t.Errorf("#5 MapIndex(b1) = %p want %p", p, b2) t.Errorf("#5 MapIndex(b1) = %#x want %p", p, b2)
} }
} }
{ {
@ -96,7 +96,7 @@ func TestImplicitMapConversion(t *testing.T) {
t.Errorf("#6 after SetMapIndex(c1, c2): %p (!= %p), %t (map=%v)", x, c2, ok, m) t.Errorf("#6 after SetMapIndex(c1, c2): %p (!= %p), %t (map=%v)", x, c2, ok, m)
} }
if p := mv.MapIndex(ValueOf(c1)).Pointer(); p != ValueOf(c2).Pointer() { if p := mv.MapIndex(ValueOf(c1)).Pointer(); p != ValueOf(c2).Pointer() {
t.Errorf("#6 MapIndex(c1) = %p want %p", p, c2) t.Errorf("#6 MapIndex(c1) = %#x want %p", p, c2)
} }
} }
{ {
@ -115,7 +115,7 @@ func TestImplicitMapConversion(t *testing.T) {
t.Errorf("#7 after SetMapIndex(b1, b2): %p (!= %p), %t (map=%v)", x, b2, ok, m) t.Errorf("#7 after SetMapIndex(b1, b2): %p (!= %p), %t (map=%v)", x, b2, ok, m)
} }
if p := mv.MapIndex(ValueOf(b1)).Pointer(); p != uintptr(unsafe.Pointer(b2)) { if p := mv.MapIndex(ValueOf(b1)).Pointer(); p != uintptr(unsafe.Pointer(b2)) {
t.Errorf("#7 MapIndex(b1) = %p want %p", p, b2) t.Errorf("#7 MapIndex(b1) = %#x want %p", p, b2)
} }
} }

2
src/pkg/strings/strings_test.go
View file

@ -967,7 +967,7 @@ var ContainsRuneTests = []struct {
func TestContainsRune(t *testing.T) { func TestContainsRune(t *testing.T) {
for _, ct := range ContainsRuneTests { for _, ct := range ContainsRuneTests {
if ContainsRune(ct.str, ct.r) != ct.expected { if ContainsRune(ct.str, ct.r) != ct.expected {
t.Errorf("ContainsRune(%s, %s) = %v, want %v", t.Errorf("ContainsRune(%q, %q) = %v, want %v",
ct.str, ct.r, !ct.expected, ct.expected) ct.str, ct.r, !ct.expected, ct.expected)
} }
} }