Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile, runtime: a different approach to duplicate itabs

Browse source 
golang.org/issue/17594 was caused by additab being called more than once for
an itab. golang.org/cl/32131 fixed that by making the itabs local symbols,
but that in turn causes golang.org/issue/18252 because now there are now
multiple itab symbols in a process for a given (type,interface) pair and
different code paths can end up referring to different itabs which breaks
lots of reflection stuff. So this makes itabs global again and just takes
care to only call additab once for each itab.

Fixes #18252

Change-Id: I781a193e2f8dd80af145a3a971f6a25537f633ea
Reviewed-on: https://go-review.googlesource.com/34173
Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
This commit is contained in:
Michael Hudson-Doyle 2016-12-12 13:31:56 +13:00
parent 1106512db5
commit 1ec64e9b63
4 changed files with 25 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/runtime/runtime2.go
View file

@ -640,7 +640,7 @@ type itab struct {
_type *_type
link *itab
bad int32
unused int32
inhash int32 // has this itab been added to hash?
fun [1]uintptr // variable sized
}