Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/cgo/internal/testshared: strip newline from gccgo -dumpversion

Browse source 
Otherwise, gccgo tests may be quietly skipped.

For #60798

Change-Id: Iaad6b53c95ad4d407b917d8f62978979b82a4e81
Reviewed-on: https://go-review.googlesource.com/c/go/+/503495
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Paul Murphy <murp@ibm.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
Paul E. Murphy 2023-06-14 15:20:11 -05:00 • committed by Paul Murphy
parent cf7ae4f136
commit 23c5e48c4a
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cmd/cgo/internal/testshared/shared_test.go
View file

@ -748,7 +748,7 @@ func requireGccgo(t *testing.T) {
if dot > 0 { if dot > 0 {
output = output[:dot] output = output[:dot]
} }
major, err := strconv.Atoi(string(output)) major, err := strconv.Atoi(strings.TrimSpace(string(output)))
if err != nil { if err != nil {
t.Skipf("can't parse gccgo version number %s", output) t.Skipf("can't parse gccgo version number %s", output)
} }