Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd/compile: avoid assignment conversion in append(a, b...)

Browse source 
There's no need for a and b to match types. The typechecker already
ensured that a and b are both slices with the same base type, or
a and b are (possibly named) []byte and string.

The optimization to treat append(b, make([], ...)) as a zeroing
slice extension doesn't fire when there's a OCONVNOP wrapping the make.
Fixes #53888

Change-Id: Ied871ed0bbb8e4a4b35d280c71acbab8103691bc
Reviewed-on: https://go-review.googlesource.com/c/go/+/418475
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
This commit is contained in:
Keith Randall 2022-07-18 11:47:19 -07:00 • committed by Keith Randall
parent c3833a5543
commit 2493072db6
5 changed files with 58 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/runtime/slice.go
View file

@ -194,7 +194,7 @@ func growslice(et *_type, old slice, cap int) slice {
}
if cap < old.cap {
panic(errorString("growslice: cap out of range"))
panic(errorString("growslice: len out of range"))
}
if et.size == 0 {
@ -284,7 +284,7 @@ func growslice(et *_type, old slice, cap int) slice {
// print(len(s), "\n")
// }
if overflow || capmem > maxAlloc {
panic(errorString("growslice: cap out of range"))
panic(errorString("growslice: len out of range"))
}
var p unsafe.Pointer